Re: [PATCH] net:liquidio: use kmemdup

[David Miller]

From: Muhammad Falak R Wani 
Date: Thu, 19 May 2016 19:22:49 +0530

> Use kmemdup when some other buffer is immediately copied into allocated
> region. It replaces call to allocation followed by memcpy, by a single
> call to kmemdup.
> 
> Signed-off-by: Muhammad Falak R Wani 

Applied.

Re: [PATCH] net:liquidio: use kmemdup

[David Miller]

From: Muhammad Falak R Wani 
Date: Thu, 19 May 2016 19:22:49 +0530

> Use kmemdup when some other buffer is immediately copied into allocated
> region. It replaces call to allocation followed by memcpy, by a single
> call to kmemdup.
> 
> Signed-off-by: Muhammad Falak R Wani 

Applied.

[PATCH] net:liquidio: use kmemdup

[Muhammad Falak R Wani]

Use kmemdup when some other buffer is immediately copied into allocated
region. It replaces call to allocation followed by memcpy, by a single
call to kmemdup.

Signed-off-by: Muhammad Falak R Wani 
---
 drivers/net/ethernet/cavium/liquidio/octeon_device.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c 
b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
index f67641a..8e23e3f 100644
--- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c
+++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
@@ -602,12 +602,10 @@ int octeon_download_firmware(struct octeon_device *oct, 
const u8 *data,
snprintf(oct->fw_info.liquidio_firmware_version, 32, "LIQUIDIO: %s",
 h->version);
 
-   buffer = kmalloc(size, GFP_KERNEL);
+   buffer = kmemdup(data, size, GFP_KERNEL);
if (!buffer)
return -ENOMEM;
 
-   memcpy(buffer, data, size);
-
p = buffer + sizeof(struct octeon_firmware_file_header);
 
/* load all images */
-- 
1.9.1

[PATCH] net:liquidio: use kmemdup

[Muhammad Falak R Wani]

Use kmemdup when some other buffer is immediately copied into allocated
region. It replaces call to allocation followed by memcpy, by a single
call to kmemdup.

Signed-off-by: Muhammad Falak R Wani 
---
 drivers/net/ethernet/cavium/liquidio/octeon_device.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c 
b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
index f67641a..8e23e3f 100644
--- a/drivers/net/ethernet/cavium/liquidio/octeon_device.c
+++ b/drivers/net/ethernet/cavium/liquidio/octeon_device.c
@@ -602,12 +602,10 @@ int octeon_download_firmware(struct octeon_device *oct, 
const u8 *data,
snprintf(oct->fw_info.liquidio_firmware_version, 32, "LIQUIDIO: %s",
 h->version);
 
-   buffer = kmalloc(size, GFP_KERNEL);
+   buffer = kmemdup(data, size, GFP_KERNEL);
if (!buffer)
return -ENOMEM;
 
-   memcpy(buffer, data, size);
-
p = buffer + sizeof(struct octeon_firmware_file_header);
 
/* load all images */
-- 
1.9.1