Re: [PATCH] nfc: st-nci: remove unnecessary label

2021-04-13 Thread patchwork-bot+netdevbpf
Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Tue, 13 Apr 2021 17:45:30 +0800 you wrote:
> From: wengjianfeng 
> 
> in st_nci_spi_write function, first assign a value to a variable then
> goto exit label. return statement just follow the label and exit label
> just used once, so we should directly return and remove exit label.
> 
> Signed-off-by: wengjianfeng 
> 
> [...]

Here is the summary with links:
  - nfc: st-nci: remove unnecessary label
https://git.kernel.org/netdev/net-next/c/eba43fac8dfa

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




[PATCH] nfc: st-nci: remove unnecessary label

2021-04-13 Thread samirweng1979
From: wengjianfeng 

in st_nci_spi_write function, first assign a value to a variable then
goto exit label. return statement just follow the label and exit label
just used once, so we should directly return and remove exit label.

Signed-off-by: wengjianfeng 
---
 drivers/nfc/st-nci/spi.c | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/nfc/st-nci/spi.c b/drivers/nfc/st-nci/spi.c
index 8db323a..09df6ea 100644
--- a/drivers/nfc/st-nci/spi.c
+++ b/drivers/nfc/st-nci/spi.c
@@ -95,17 +95,14 @@ static int st_nci_spi_write(void *phy_id, struct sk_buff 
*skb)
 */
if (!r) {
skb_rx = alloc_skb(skb->len, GFP_KERNEL);
-   if (!skb_rx) {
-   r = -ENOMEM;
-   goto exit;
-   }
+   if (!skb_rx)
+   return -ENOMEM;
 
skb_put(skb_rx, skb->len);
memcpy(skb_rx->data, buf, skb->len);
ndlc_recv(phy->ndlc, skb_rx);
}
 
-exit:
return r;
 }
 
-- 
1.9.1