Re: [PATCH] pci: fix warning for struct hisi_pcie_platform_ops

2019-04-16 Thread Lorenzo Pieralisi 
On Mon, Apr 15, 2019 at 04:53:49PM +0800, Mao Wenan wrote:
> There is one warning exist while compiling 
> drivers/pci/controller/dwc/pcie-hisi.c.
> make allmodconfig ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
> make C=2 drivers/pci/controller/dwc/pcie-hisi.o ARCH=arm64 
> CROSS_COMPILE=aarch64-linux-gnu-
> drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning: symbol 
> 'hisi_pcie_platform_ops' was not declared. Should it be static?
> 
> Fixes: a2ec1996098("PCI: hisi: Add DT almost-ECAM support for Hip06/Hip07 
> host controllers")
> Reported-by: Hulk Robot 
> Signed-off-by: Mao Wenan 
> ---
>  drivers/pci/controller/dwc/pcie-hisi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to pci/misc, thanks.

Lorenzo

> diff --git a/drivers/pci/controller/dwc/pcie-hisi.c 
> b/drivers/pci/controller/dwc/pcie-hisi.c
> index 6d9e1b2..11f5ff7 100644
> --- a/drivers/pci/controller/dwc/pcie-hisi.c
> +++ b/drivers/pci/controller/dwc/pcie-hisi.c
> @@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct 
> pci_config_window *cfg)
>   return 0;
>  }
>  
> -struct pci_ecam_ops hisi_pcie_platform_ops = {
> +static struct pci_ecam_ops hisi_pcie_platform_ops = {
>   .bus_shift= 20,
>   .init =  hisi_pcie_platform_init,
>   .pci_ops  = {
> -- 
> 2.7.4
>

Re: [PATCH] pci: fix warning for struct hisi_pcie_platform_ops

2019-04-16 Thread Zhou Wang 
On 2019/4/15 16:53, Mao Wenan wrote:
> There is one warning exist while compiling 
> drivers/pci/controller/dwc/pcie-hisi.c.
> make allmodconfig ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
> make C=2 drivers/pci/controller/dwc/pcie-hisi.o ARCH=arm64 
> CROSS_COMPILE=aarch64-linux-gnu-
> drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning: symbol 
> 'hisi_pcie_platform_ops' was not declared. Should it be static?
> 
> Fixes: a2ec1996098("PCI: hisi: Add DT almost-ECAM support for Hip06/Hip07 
> host controllers")
> Reported-by: Hulk Robot 
> Signed-off-by: Mao Wenan 

Acked-by: Zhou Wang 

Thanks,
Zhou

> ---
>  drivers/pci/controller/dwc/pcie-hisi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-hisi.c 
> b/drivers/pci/controller/dwc/pcie-hisi.c
> index 6d9e1b2..11f5ff7 100644
> --- a/drivers/pci/controller/dwc/pcie-hisi.c
> +++ b/drivers/pci/controller/dwc/pcie-hisi.c
> @@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct 
> pci_config_window *cfg)
>   return 0;
>  }
>  
> -struct pci_ecam_ops hisi_pcie_platform_ops = {
> +static struct pci_ecam_ops hisi_pcie_platform_ops = {
>   .bus_shift= 20,
>   .init =  hisi_pcie_platform_init,
>   .pci_ops  = {
>

[PATCH] pci: fix warning for struct hisi_pcie_platform_ops

2019-04-15 Thread Mao Wenan 
There is one warning exist while compiling 
drivers/pci/controller/dwc/pcie-hisi.c.
make allmodconfig ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-
make C=2 drivers/pci/controller/dwc/pcie-hisi.o ARCH=arm64 
CROSS_COMPILE=aarch64-linux-gnu-
drivers/pci/controller/dwc/pcie-hisi.c:365:21: warning: symbol 
'hisi_pcie_platform_ops' was not declared. Should it be static?

Fixes: a2ec1996098("PCI: hisi: Add DT almost-ECAM support for Hip06/Hip07 host 
controllers")
Reported-by: Hulk Robot 
Signed-off-by: Mao Wenan 
---
 drivers/pci/controller/dwc/pcie-hisi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/dwc/pcie-hisi.c 
b/drivers/pci/controller/dwc/pcie-hisi.c
index 6d9e1b2..11f5ff7 100644
--- a/drivers/pci/controller/dwc/pcie-hisi.c
+++ b/drivers/pci/controller/dwc/pcie-hisi.c
@@ -362,7 +362,7 @@ static int hisi_pcie_platform_init(struct pci_config_window 
*cfg)
return 0;
 }
 
-struct pci_ecam_ops hisi_pcie_platform_ops = {
+static struct pci_ecam_ops hisi_pcie_platform_ops = {
.bus_shift= 20,
.init =  hisi_pcie_platform_init,
.pci_ops  = {
-- 
2.7.4