Re: [PATCH] perf/core: Mark perf_pmu_snapshot_aux() as static

2021-04-02 Thread Souptick Joarder
On Sat, Jan 9, 2021 at 7:47 AM Souptick Joarder  wrote:
>
> Kernel test robot throws below warning ->
>
>  kernel/events/core.c:6535:6: warning: no previous prototype for
> 'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
> 6535 | long perf_pmu_snapshot_aux(struct perf_buffer *rb,
>  |  ^
> Marking perf_pmu_snapshot_aux() as static as it is not used outside
> this file.
>
> Reported-by: kernel test robot 
> Signed-off-by: Souptick Joarder 

Any comment on this patch ?

> ---
>  kernel/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 55d1879..a4ba6fd 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -6532,7 +6532,7 @@ static unsigned long perf_prepare_sample_aux(struct 
> perf_event *event,
> return data->aux_size;
>  }
>
> -long perf_pmu_snapshot_aux(struct perf_buffer *rb,
> +static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
>struct perf_event *event,
>struct perf_output_handle *handle,
>unsigned long size)
> --
> 1.9.1
>


[PATCH] perf/core: Mark perf_pmu_snapshot_aux() as static

2021-01-08 Thread Souptick Joarder
Kernel test robot throws below warning ->

 kernel/events/core.c:6535:6: warning: no previous prototype for
'perf_pmu_snapshot_aux' [-Wmissing-prototypes]
6535 | long perf_pmu_snapshot_aux(struct perf_buffer *rb,
 |  ^
Marking perf_pmu_snapshot_aux() as static as it is not used outside
this file.

Reported-by: kernel test robot 
Signed-off-by: Souptick Joarder 
---
 kernel/events/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 55d1879..a4ba6fd 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -6532,7 +6532,7 @@ static unsigned long perf_prepare_sample_aux(struct 
perf_event *event,
return data->aux_size;
 }
 
-long perf_pmu_snapshot_aux(struct perf_buffer *rb,
+static long perf_pmu_snapshot_aux(struct perf_buffer *rb,
   struct perf_event *event,
   struct perf_output_handle *handle,
   unsigned long size)
-- 
1.9.1