Re: [PATCH] perf/x86/intel/pt: Fix base for single entry topa

2019-10-21 Thread Alexander Shishkin
Jiri Olsa  writes:

> Jan reported failing ltp test for pt. It looks like the reason
> is commit 38bb8d77d0b9, that did not keep the TOPA_SHIFT for
> entry base, adding it back.

Thanks for taking care of that so quickly!

Regards,
--
Alex


[PATCH] perf/x86/intel/pt: Fix base for single entry topa

2019-10-19 Thread Jiri Olsa
Jan reported failing ltp test for pt. It looks like the reason
is commit 38bb8d77d0b9, that did not keep the TOPA_SHIFT for
entry base, adding it back.

[1] 
https://github.com/linux-test-project/ltp/blob/master/testcases/kernel/tracing/pt_test/pt_test.c

Reported-by: Jan Stancek 
Fixes: 38bb8d77d0b9 ("perf/x86/intel/pt: Split ToPA metadata and page layout")
Signed-off-by: Jiri Olsa 
---
 arch/x86/events/intel/pt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/events/intel/pt.c b/arch/x86/events/intel/pt.c
index 74e80ed9c6c4..05e43d0f430b 100644
--- a/arch/x86/events/intel/pt.c
+++ b/arch/x86/events/intel/pt.c
@@ -627,7 +627,7 @@ static struct topa *topa_alloc(int cpu, gfp_t gfp)
 * link as the 2nd entry in the table
 */
if (!intel_pt_validate_hw_cap(PT_CAP_topa_multiple_entries)) {
-   TOPA_ENTRY(>topa, 1)->base = page_to_phys(p);
+   TOPA_ENTRY(>topa, 1)->base = page_to_phys(p) >> TOPA_SHIFT;
TOPA_ENTRY(>topa, 1)->end = 1;
}
 
-- 
2.21.0