[PATCH] perf: Use ACCESS_ONCE() instead of volatile cast
Use ACCESS_ONCE() instead of the cast to volatile and read. This is just a style change which is reader friendly. Signed-off-by: Pranith Kumar --- tools/perf/util/session.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h index 8dd41ca..ffb4404 100644 --- a/tools/perf/util/session.h +++ b/tools/perf/util/session.h @@ -126,5 +126,5 @@ int __perf_session__set_tracepoints_handlers(struct perf_session *session, extern volatile int session_done; -#define session_done() (*(volatile int *)(&session_done)) +#define session_done() ACCESS_ONCE(session_done) #endif /* __PERF_SESSION_H */ -- 2.1.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf: Use ACCESS_ONCE() instead of volatile cast
Hi Pranith, On Tue, 23 Sep 2014 10:55:08 -0400, Pranith Kumar wrote: > Use ACCESS_ONCE() instead of the cast to volatile and read. This is just a > style > change which is reader friendly. > > Signed-off-by: Pranith Kumar Acked-by: Namhyung Kim Thanks, Namhyung > --- > tools/perf/util/session.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/session.h b/tools/perf/util/session.h > index 8dd41ca..ffb4404 100644 > --- a/tools/perf/util/session.h > +++ b/tools/perf/util/session.h > @@ -126,5 +126,5 @@ int __perf_session__set_tracepoints_handlers(struct > perf_session *session, > > extern volatile int session_done; > > -#define session_done() (*(volatile int *)(&session_done)) > +#define session_done() ACCESS_ONCE(session_done) > #endif /* __PERF_SESSION_H */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf: Use ACCESS_ONCE() instead of volatile cast
Em Wed, Sep 24, 2014 at 11:31:07AM +0900, Namhyung Kim escreveu: > Hi Pranith, > > On Tue, 23 Sep 2014 10:55:08 -0400, Pranith Kumar wrote: > > Use ACCESS_ONCE() instead of the cast to volatile and read. This is just a > > style > > change which is reader friendly. > > > > Signed-off-by: Pranith Kumar > > Acked-by: Namhyung Kim Thanks, applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
