Re: [PATCH] perf report: Set proper sort__mode for the branch option
Em Wed, Aug 13, 2014 at 02:45:34PM +0900, Namhyung Kim escreveu:
> Hi Naohiro,
>
> (CC'ing Stephane)
>
> > When you specify "--branch-stack"("-b" for short) or
> > "--no-branch-stack", "branch_mode" variable is set to 1 or 0
> > respectively. However, the code is just checking if the variable is -1
> > or not, ignoring "branch_mode == 1" case. Thus "perf report -b" dose not
> > show its result with the branch sorted mode. This patch fix the problem.
> >
> > Signed-off-by: Naohiro Aota
>
> Acked-by: Namhyung Kim
>
> Thanks for fixing this!
> Namhyung
Thanks, applied.
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf report: Set proper sort__mode for the branch option
Em Wed, Aug 13, 2014 at 02:45:34PM +0900, Namhyung Kim escreveu: Hi Naohiro, (CC'ing Stephane) When you specify --branch-stack(-b for short) or --no-branch-stack, branch_mode variable is set to 1 or 0 respectively. However, the code is just checking if the variable is -1 or not, ignoring branch_mode == 1 case. Thus perf report -b dose not show its result with the branch sorted mode. This patch fix the problem. Signed-off-by: Naohiro Aota na...@elisp.net Acked-by: Namhyung Kim namhy...@kernel.org Thanks for fixing this! Namhyung Thanks, applied. - Arnaldo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf report: Set proper sort__mode for the branch option
Hi Naohiro,
(CC'ing Stephane)
> When you specify "--branch-stack"("-b" for short) or
> "--no-branch-stack", "branch_mode" variable is set to 1 or 0
> respectively. However, the code is just checking if the variable is -1
> or not, ignoring "branch_mode == 1" case. Thus "perf report -b" dose not
> show its result with the branch sorted mode. This patch fix the problem.
>
> Signed-off-by: Naohiro Aota
Acked-by: Namhyung Kim
Thanks for fixing this!
Namhyung
> ---
> tools/perf/builtin-report.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 21d830b..94dcf2d 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -719,7 +719,7 @@ repeat:
> has_br_stack = perf_header__has_feat(>header,
>HEADER_BRANCH_STACK);
>
> - if (branch_mode == -1 && has_br_stack) {
> + if ((branch_mode == -1 && has_br_stack) || branch_mode == 1) {
> sort__mode = SORT_MODE__BRANCH;
> symbol_conf.cumulate_callchain = false;
> }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] perf report: Set proper sort__mode for the branch option
Hi Naohiro,
(CC'ing Stephane)
When you specify --branch-stack(-b for short) or
--no-branch-stack, branch_mode variable is set to 1 or 0
respectively. However, the code is just checking if the variable is -1
or not, ignoring branch_mode == 1 case. Thus perf report -b dose not
show its result with the branch sorted mode. This patch fix the problem.
Signed-off-by: Naohiro Aota na...@elisp.net
Acked-by: Namhyung Kim namhy...@kernel.org
Thanks for fixing this!
Namhyung
---
tools/perf/builtin-report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 21d830b..94dcf2d 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -719,7 +719,7 @@ repeat:
has_br_stack = perf_header__has_feat(session-header,
HEADER_BRANCH_STACK);
- if (branch_mode == -1 has_br_stack) {
+ if ((branch_mode == -1 has_br_stack) || branch_mode == 1) {
sort__mode = SORT_MODE__BRANCH;
symbol_conf.cumulate_callchain = false;
}
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] perf report: Set proper sort__mode for the branch option
When you specify "--branch-stack"("-b" for short) or
"--no-branch-stack", "branch_mode" variable is set to 1 or 0
respectively. However, the code is just checking if the variable is -1
or not, ignoring "branch_mode == 1" case. Thus "perf report -b" dose not
show its result with the branch sorted mode. This patch fix the problem.
Signed-off-by: Naohiro Aota
---
tools/perf/builtin-report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 21d830b..94dcf2d 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -719,7 +719,7 @@ repeat:
has_br_stack = perf_header__has_feat(>header,
HEADER_BRANCH_STACK);
- if (branch_mode == -1 && has_br_stack) {
+ if ((branch_mode == -1 && has_br_stack) || branch_mode == 1) {
sort__mode = SORT_MODE__BRANCH;
symbol_conf.cumulate_callchain = false;
}
--
2.0.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] perf report: Set proper sort__mode for the branch option
When you specify --branch-stack(-b for short) or
--no-branch-stack, branch_mode variable is set to 1 or 0
respectively. However, the code is just checking if the variable is -1
or not, ignoring branch_mode == 1 case. Thus perf report -b dose not
show its result with the branch sorted mode. This patch fix the problem.
Signed-off-by: Naohiro Aota na...@elisp.net
---
tools/perf/builtin-report.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 21d830b..94dcf2d 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -719,7 +719,7 @@ repeat:
has_br_stack = perf_header__has_feat(session-header,
HEADER_BRANCH_STACK);
- if (branch_mode == -1 has_br_stack) {
+ if ((branch_mode == -1 has_br_stack) || branch_mode == 1) {
sort__mode = SORT_MODE__BRANCH;
symbol_conf.cumulate_callchain = false;
}
--
2.0.2
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
