Re: [PATCH] perf tools: use ARRAY_SIZE

2021-03-09 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 09, 2021 at 05:12:25PM +0800, Jiapeng Chong escreveu:
> Fix the following cppcheck warnings:
> 
> ./tools/perf/tests/demangle-ocaml-test.c:29:34-35: WARNING: Use
> ARRAY_SIZE.

Thanks, applied.

- Arnaldo

 
> Reported-by: Abaci Robot 
> Signed-off-by: Jiapeng Chong 
> ---
>  tools/perf/tests/demangle-ocaml-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/tests/demangle-ocaml-test.c 
> b/tools/perf/tests/demangle-ocaml-test.c
> index a273ed5..2fac7d7 100644
> --- a/tools/perf/tests/demangle-ocaml-test.c
> +++ b/tools/perf/tests/demangle-ocaml-test.c
> @@ -26,7 +26,7 @@ int test__demangle_ocaml(struct test *test __maybe_unused, 
> int subtest __maybe_u
> "Stdlib.bytes.++" },
>   };
>  
> - for (i = 0; i < sizeof(test_cases) / sizeof(test_cases[0]); i++) {
> + for (i = 0; i < ARRAY_SIZE(test_cases); i++) {
>   buf = ocaml_demangle_sym(test_cases[i].mangled);
>   if ((buf == NULL && test_cases[i].demangled != NULL)
>   || (buf != NULL && test_cases[i].demangled == 
> NULL)
> -- 
> 1.8.3.1
> 

-- 

- Arnaldo


[PATCH] perf tools: use ARRAY_SIZE

2021-03-09 Thread Jiapeng Chong
Fix the following cppcheck warnings:

./tools/perf/tests/demangle-ocaml-test.c:29:34-35: WARNING: Use
ARRAY_SIZE.

Reported-by: Abaci Robot 
Signed-off-by: Jiapeng Chong 
---
 tools/perf/tests/demangle-ocaml-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/tests/demangle-ocaml-test.c 
b/tools/perf/tests/demangle-ocaml-test.c
index a273ed5..2fac7d7 100644
--- a/tools/perf/tests/demangle-ocaml-test.c
+++ b/tools/perf/tests/demangle-ocaml-test.c
@@ -26,7 +26,7 @@ int test__demangle_ocaml(struct test *test __maybe_unused, 
int subtest __maybe_u
  "Stdlib.bytes.++" },
};
 
-   for (i = 0; i < sizeof(test_cases) / sizeof(test_cases[0]); i++) {
+   for (i = 0; i < ARRAY_SIZE(test_cases); i++) {
buf = ocaml_demangle_sym(test_cases[i].mangled);
if ((buf == NULL && test_cases[i].demangled != NULL)
|| (buf != NULL && test_cases[i].demangled == 
NULL)
-- 
1.8.3.1