Re: [PATCH] phy: mediatek: statify mtk_hdmi_phy_driver

2020-12-05 Thread Chun-Kuang Hu
Hi, Vinod:

Vinod Koul  於 2020年12月5日 週六 下午5:11寫道:
>
> mtk_hdmi_phy_driver is not declared as static, so statify it.
>
> drivers/phy/mediatek/phy-mtk-hdmi.c:204:24: warning: symbol 
> 'mtk_hdmi_phy_driver' was not declared. Should it be static?
>

Acked-by: Chun-Kuang Hu 

> Signed-off-by: Vinod Koul 
> ---
>  drivers/phy/mediatek/phy-mtk-hdmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c 
> b/drivers/phy/mediatek/phy-mtk-hdmi.c
> index 47c029d4b270..c5c61f5a9ea0 100644
> --- a/drivers/phy/mediatek/phy-mtk-hdmi.c
> +++ b/drivers/phy/mediatek/phy-mtk-hdmi.c
> @@ -201,7 +201,7 @@ static const struct of_device_id mtk_hdmi_phy_match[] = {
> {},
>  };
>
> -struct platform_driver mtk_hdmi_phy_driver = {
> +static struct platform_driver mtk_hdmi_phy_driver = {
> .probe = mtk_hdmi_phy_probe,
> .driver = {
> .name = "mediatek-hdmi-phy",
> --
> 2.26.2
>


[PATCH] phy: mediatek: statify mtk_hdmi_phy_driver

2020-12-05 Thread Vinod Koul
mtk_hdmi_phy_driver is not declared as static, so statify it.

drivers/phy/mediatek/phy-mtk-hdmi.c:204:24: warning: symbol 
'mtk_hdmi_phy_driver' was not declared. Should it be static?

Signed-off-by: Vinod Koul 
---
 drivers/phy/mediatek/phy-mtk-hdmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/mediatek/phy-mtk-hdmi.c 
b/drivers/phy/mediatek/phy-mtk-hdmi.c
index 47c029d4b270..c5c61f5a9ea0 100644
--- a/drivers/phy/mediatek/phy-mtk-hdmi.c
+++ b/drivers/phy/mediatek/phy-mtk-hdmi.c
@@ -201,7 +201,7 @@ static const struct of_device_id mtk_hdmi_phy_match[] = {
{},
 };
 
-struct platform_driver mtk_hdmi_phy_driver = {
+static struct platform_driver mtk_hdmi_phy_driver = {
.probe = mtk_hdmi_phy_probe,
.driver = {
.name = "mediatek-hdmi-phy",
-- 
2.26.2