Re: [PATCH] phy: rockchip-usb: power down phy when rockchip phy probe

[Doug Anderson]

hl,

On Fri, Jul 17, 2015 at 12:29 AM, huang lin  wrote:
> rockchip phy are enable when soc reset, to save power consumption,
> we disable it when probe, and enable each phy when it use
>
> Signed-off-by: huang lin 
> ---
>  drivers/phy/phy-rockchip-usb.c | 6 ++
>  1 file changed, 6 insertions(+)

Looks right to me.

Reviewed-by: Douglas Anderson 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] phy: rockchip-usb: power down phy when rockchip phy probe

[huang lin]

rockchip phy are enable when soc reset, to save power consumption,
we disable it when probe, and enable each phy when it use

Signed-off-by: huang lin 
---
 drivers/phy/phy-rockchip-usb.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/drivers/phy/phy-rockchip-usb.c b/drivers/phy/phy-rockchip-usb.c
index 7d4c336..3b92d7f 100644
--- a/drivers/phy/phy-rockchip-usb.c
+++ b/drivers/phy/phy-rockchip-usb.c
@@ -98,6 +98,7 @@ static int rockchip_usb_phy_probe(struct platform_device 
*pdev)
struct device_node *child;
struct regmap *grf;
unsigned int reg_offset;
+   int err;
 
grf = syscon_regmap_lookup_by_phandle(dev->of_node, "rockchip,grf");
if (IS_ERR(grf)) {
@@ -129,6 +130,11 @@ static int rockchip_usb_phy_probe(struct platform_device 
*pdev)
return PTR_ERR(rk_phy->phy);
}
phy_set_drvdata(rk_phy->phy, rk_phy);
+
+   /* only power up usb phy when it use, so disable it when init*/
+   err = rockchip_usb_phy_power(rk_phy, 1);
+   if (err)
+   return err;
}
 
phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/