Re: [PATCH] pinctrl: rza1: Remove suffix from gpiochip label

2017-08-31 Thread Linus Walleij
On Thu, Aug 24, 2017 at 10:52 AM, Jacopo Mondi
 wrote:

> The OF node name already contains the gpio chip identifier, no need to
> append it when creating the label.
>
> The following debug message clearly shows the suffix is not required
> "pinctrl-rza1 fcfe3000.pin-controller: Parsed gpiochip gpio-0-0 with 6
> pins"
>
> Signed-off-by: Jacopo Mondi 

Patch applied.

Yours,
Linus Walleij


Re: [PATCH] pinctrl: rza1: Remove suffix from gpiochip label

2017-08-31 Thread Linus Walleij
On Thu, Aug 24, 2017 at 10:52 AM, Jacopo Mondi
 wrote:

> The OF node name already contains the gpio chip identifier, no need to
> append it when creating the label.
>
> The following debug message clearly shows the suffix is not required
> "pinctrl-rza1 fcfe3000.pin-controller: Parsed gpiochip gpio-0-0 with 6
> pins"
>
> Signed-off-by: Jacopo Mondi 

Patch applied.

Yours,
Linus Walleij


[PATCH] pinctrl: rza1: Remove suffix from gpiochip label

2017-08-24 Thread Jacopo Mondi
The OF node name already contains the gpio chip identifier, no need to
append it when creating the label.

The following debug message clearly shows the suffix is not required
"pinctrl-rza1 fcfe3000.pin-controller: Parsed gpiochip gpio-0-0 with 6
pins"

Signed-off-by: Jacopo Mondi 
---
 drivers/pinctrl/pinctrl-rza1.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c
index dc164da..7e896bd 100644
--- a/drivers/pinctrl/pinctrl-rza1.c
+++ b/drivers/pinctrl/pinctrl-rza1.c
@@ -1096,8 +1096,8 @@ static int rza1_parse_gpiochip(struct rza1_pinctrl 
*rza1_pctl,

*chip   = rza1_gpiochip_template;
chip->base  = -1;
-   chip->label = devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%s-%u",
-np->name, gpioport);
+   chip->label = devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%s",
+np->name);
chip->ngpio = of_args.args[2];
chip->of_node   = np;
chip->parent= rza1_pctl->dev;
--
2.7.4



[PATCH] pinctrl: rza1: Remove suffix from gpiochip label

2017-08-24 Thread Jacopo Mondi
The OF node name already contains the gpio chip identifier, no need to
append it when creating the label.

The following debug message clearly shows the suffix is not required
"pinctrl-rza1 fcfe3000.pin-controller: Parsed gpiochip gpio-0-0 with 6
pins"

Signed-off-by: Jacopo Mondi 
---
 drivers/pinctrl/pinctrl-rza1.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c
index dc164da..7e896bd 100644
--- a/drivers/pinctrl/pinctrl-rza1.c
+++ b/drivers/pinctrl/pinctrl-rza1.c
@@ -1096,8 +1096,8 @@ static int rza1_parse_gpiochip(struct rza1_pinctrl 
*rza1_pctl,

*chip   = rza1_gpiochip_template;
chip->base  = -1;
-   chip->label = devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%s-%u",
-np->name, gpioport);
+   chip->label = devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%s",
+np->name);
chip->ngpio = of_args.args[2];
chip->of_node   = np;
chip->parent= rza1_pctl->dev;
--
2.7.4