Re: [PATCH] pinctrl: sprd: Fix the incorrect pull-up definition

2020-05-16 Thread Linus Walleij 
On Thu, May 7, 2020 at 5:47 AM Baolin Wang  wrote:

> The bits of pull up resistor selection were defined mistakenly,
> thus fix them.
>
> Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver")
> Signed-off-by: Baolin Wang 

Patch applied.

Yours,
Linus Walleij

[PATCH] pinctrl: sprd: Fix the incorrect pull-up definition

2020-05-06 Thread Baolin Wang 
The bits of pull up resistor selection were defined mistakenly,
thus fix them.

Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver")
Signed-off-by: Baolin Wang 
---
 drivers/pinctrl/sprd/pinctrl-sprd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/sprd/pinctrl-sprd.c 
b/drivers/pinctrl/sprd/pinctrl-sprd.c
index 48cbf2a..08dc193 100644
--- a/drivers/pinctrl/sprd/pinctrl-sprd.c
+++ b/drivers/pinctrl/sprd/pinctrl-sprd.c
@@ -68,8 +68,8 @@
 #define SLEEP_PULL_UP_MASK 0x1
 #define SLEEP_PULL_UP_SHIFT3
 
-#define PULL_UP_20K(BIT(12) | BIT(7))
-#define PULL_UP_4_7K   BIT(12)
+#define PULL_UP_4_7K   (BIT(12) | BIT(7))
+#define PULL_UP_20KBIT(7)
 #define PULL_UP_MASK   0x21
 #define PULL_UP_SHIFT  7
 
-- 
1.9.1