Re: [PATCH] ppc: remove unused amiga_request_irq and mach_request_irq
On Wed, 2007-08-22 at 13:28 -0500, Linas Vepstas wrote: > On Wed, Aug 22, 2007 at 07:44:41PM +1000, Paul Mackerras wrote: > > Fernando Luis Vázquez Cao writes: > > > > > amiga_request_irq and mach_request_irq are never used, so delete them. > > > > OK, but is there a particular reason you want to do this? > > > > The whole of arch/ppc is going away eventually, so I don't think we > > need to remove it piece by piece. > > Its often easier to port/move stuff if you clean it up first. Agreed. It would make things easier for me too. Fernando - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ppc: remove unused amiga_request_irq and mach_request_irq
On Wed, 2007-08-22 at 19:44 +1000, Paul Mackerras wrote: > Fernando Luis Vázquez Cao writes: > > > amiga_request_irq and mach_request_irq are never used, so delete them. > > OK, but is there a particular reason you want to do this? Hi Paul, Thank you for your reply. I am currently auditing all the interrupt handlers and related code (request_irq(), free_irq(), and others of that ilk) and, in the process, I found some dead code. Getting rid of this cruft would just make my life easier. The final goal of this audit is to determine whether the Linux interrupt handlers are kdump-ready. With the advent of kdump it is now possible that device drivers have to handle pending interrupts generated in the context of a previous kernel. Any pending interrupts will come in as soon as the IRQ is allocated, but, unfortunately, not all the device drivers handle this situation properly. Besides, I am also trying to determine if applying this patch: http://lkml.org/lkml/2007/7/19/687 is a sane thing to do. > The whole of arch/ppc is going away eventually, so I don't think we > need to remove it piece by piece. As Linas mentioned in his reply, cleaning things up first will probably make things easier for you too. Please consider merging the four patches I sent to the PPC mailing list. Fernando - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ppc: remove unused amiga_request_irq and mach_request_irq
On Wed, Aug 22, 2007 at 07:44:41PM +1000, Paul Mackerras wrote: > Fernando Luis Vázquez Cao writes: > > > amiga_request_irq and mach_request_irq are never used, so delete them. > > OK, but is there a particular reason you want to do this? > > The whole of arch/ppc is going away eventually, so I don't think we > need to remove it piece by piece. Its often easier to port/move stuff if you clean it up first. --linas - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] ppc: remove unused amiga_request_irq and mach_request_irq
Fernando Luis Vázquez Cao writes: > amiga_request_irq and mach_request_irq are never used, so delete them. OK, but is there a particular reason you want to do this? The whole of arch/ppc is going away eventually, so I don't think we need to remove it piece by piece. Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] ppc: remove unused amiga_request_irq and mach_request_irq
amiga_request_irq and mach_request_irq are never used, so delete them. Signed-off-by: Fernando Luis Vazquez Cao <[EMAIL PROTECTED]> --- diff -urNp linux-2.6.23-rc3-orig/arch/ppc/amiga/config.c linux-2.6.23-rc3/arch/ppc/amiga/config.c --- linux-2.6.23-rc3-orig/arch/ppc/amiga/config.c 2007-07-09 08:32:17.0 +0900 +++ linux-2.6.23-rc3/arch/ppc/amiga/config.c2007-08-22 15:45:51.0 +0900 @@ -72,10 +72,6 @@ static void amiga_sched_init(irqreturn_t /* amiga specific irq functions */ extern void amiga_init_IRQ (void); extern void (*amiga_default_handler[]) (int, void *, struct pt_regs *); -extern int amiga_request_irq (unsigned int irq, - void (*handler)(int, void *, struct pt_regs *), - unsigned long flags, const char *devname, - void *dev_id); extern void amiga_free_irq (unsigned int irq, void *dev_id); extern void amiga_enable_irq (unsigned int); extern void amiga_disable_irq (unsigned int); @@ -382,7 +378,6 @@ void __init config_amiga(void) mach_init_IRQ= amiga_init_IRQ; #ifndef CONFIG_APUS mach_default_handler = &amiga_default_handler; - mach_request_irq = amiga_request_irq; mach_free_irq= amiga_free_irq; enable_irq = amiga_enable_irq; disable_irq = amiga_disable_irq; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
