Re: [PATCH] pps: kc: fix non-tickless system config dependency
Hi Andrew, Could you take this patch, please? Thanks, Maciej On 21.03.2016 15:38, Rodolfo Giometti wrote: > On Mon, Mar 21, 2016 at 03:28:26PM +0100, Maciej S. Szmigiero wrote: >> Hi Rodolfo, >> >> On 06.03.2016 20:13, Rodolfo Giometti wrote: >>> On Sat, Mar 05, 2016 at 06:37:39PM +0100, Maciej S. Szmigiero wrote: CONFIG_NO_HZ currently only sets the default value of dynticks config so if PPS kernel consumer needs periodic timer ticks it should depend on !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. Otherwise it is possible to enable it even on tickless system which has CONFIG_NO_HZ not set and CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set. Signed-off-by: Maciej S. Szmigiero>>> >>> It's ok for me. >> >> Thanks for review, do you know who should merge it then? > > Usually I ask to Andrew Morton > > Ciao, > > Rodolfo >
Re: [PATCH] pps: kc: fix non-tickless system config dependency
Hi Andrew, Could you take this patch, please? Thanks, Maciej On 21.03.2016 15:38, Rodolfo Giometti wrote: > On Mon, Mar 21, 2016 at 03:28:26PM +0100, Maciej S. Szmigiero wrote: >> Hi Rodolfo, >> >> On 06.03.2016 20:13, Rodolfo Giometti wrote: >>> On Sat, Mar 05, 2016 at 06:37:39PM +0100, Maciej S. Szmigiero wrote: CONFIG_NO_HZ currently only sets the default value of dynticks config so if PPS kernel consumer needs periodic timer ticks it should depend on !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. Otherwise it is possible to enable it even on tickless system which has CONFIG_NO_HZ not set and CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set. Signed-off-by: Maciej S. Szmigiero >>> >>> It's ok for me. >> >> Thanks for review, do you know who should merge it then? > > Usually I ask to Andrew Morton > > Ciao, > > Rodolfo >
Re: [PATCH] pps: kc: fix non-tickless system config dependency
On Mon, Mar 21, 2016 at 03:28:26PM +0100, Maciej S. Szmigiero wrote: > Hi Rodolfo, > > On 06.03.2016 20:13, Rodolfo Giometti wrote: > > On Sat, Mar 05, 2016 at 06:37:39PM +0100, Maciej S. Szmigiero wrote: > >> CONFIG_NO_HZ currently only sets the default value > >> of dynticks config so if PPS kernel consumer needs > >> periodic timer ticks it should depend on > >> !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. > >> > >> Otherwise it is possible to enable it even on > >> tickless system which has CONFIG_NO_HZ not set and > >> CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set. > >> > >> Signed-off-by: Maciej S. Szmigiero> > > > It's ok for me. > > Thanks for review, do you know who should merge it then? Usually I ask to Andrew Morton Ciao, Rodolfo -- HCE Engineering e-mail: giome...@hce-engineering.com GNU/Linux Solutions giome...@enneenne.com Linux Device Driver giome...@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti Cosino Project - the quick prototyping embedded system - www.cosino.io Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
Re: [PATCH] pps: kc: fix non-tickless system config dependency
On Mon, Mar 21, 2016 at 03:28:26PM +0100, Maciej S. Szmigiero wrote: > Hi Rodolfo, > > On 06.03.2016 20:13, Rodolfo Giometti wrote: > > On Sat, Mar 05, 2016 at 06:37:39PM +0100, Maciej S. Szmigiero wrote: > >> CONFIG_NO_HZ currently only sets the default value > >> of dynticks config so if PPS kernel consumer needs > >> periodic timer ticks it should depend on > >> !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. > >> > >> Otherwise it is possible to enable it even on > >> tickless system which has CONFIG_NO_HZ not set and > >> CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set. > >> > >> Signed-off-by: Maciej S. Szmigiero > > > > It's ok for me. > > Thanks for review, do you know who should merge it then? Usually I ask to Andrew Morton Ciao, Rodolfo -- HCE Engineering e-mail: giome...@hce-engineering.com GNU/Linux Solutions giome...@enneenne.com Linux Device Driver giome...@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti Cosino Project - the quick prototyping embedded system - www.cosino.io Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
Re: [PATCH] pps: kc: fix non-tickless system config dependency
Hi Rodolfo, On 06.03.2016 20:13, Rodolfo Giometti wrote: > On Sat, Mar 05, 2016 at 06:37:39PM +0100, Maciej S. Szmigiero wrote: >> CONFIG_NO_HZ currently only sets the default value >> of dynticks config so if PPS kernel consumer needs >> periodic timer ticks it should depend on >> !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. >> >> Otherwise it is possible to enable it even on >> tickless system which has CONFIG_NO_HZ not set and >> CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set. >> >> Signed-off-by: Maciej S. Szmigiero> > It's ok for me. Thanks for review, do you know who should merge it then? > Ciao, > > Rodolfo Best regards, Maciej
Re: [PATCH] pps: kc: fix non-tickless system config dependency
Hi Rodolfo, On 06.03.2016 20:13, Rodolfo Giometti wrote: > On Sat, Mar 05, 2016 at 06:37:39PM +0100, Maciej S. Szmigiero wrote: >> CONFIG_NO_HZ currently only sets the default value >> of dynticks config so if PPS kernel consumer needs >> periodic timer ticks it should depend on >> !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. >> >> Otherwise it is possible to enable it even on >> tickless system which has CONFIG_NO_HZ not set and >> CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set. >> >> Signed-off-by: Maciej S. Szmigiero > > It's ok for me. Thanks for review, do you know who should merge it then? > Ciao, > > Rodolfo Best regards, Maciej
Re: [PATCH] pps: kc: fix non-tickless system config dependency
On Sat, Mar 05, 2016 at 06:37:39PM +0100, Maciej S. Szmigiero wrote: > CONFIG_NO_HZ currently only sets the default value > of dynticks config so if PPS kernel consumer needs > periodic timer ticks it should depend on > !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. > > Otherwise it is possible to enable it even on > tickless system which has CONFIG_NO_HZ not set and > CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set. > > Signed-off-by: Maciej S. SzmigieroIt's ok for me. Ciao, Rodolfo -- HCE Engineering e-mail: giome...@hce-engineering.com GNU/Linux Solutions giome...@enneenne.com Linux Device Driver giome...@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti Cosino Project - the quick prototyping embedded system - www.cosino.io Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
Re: [PATCH] pps: kc: fix non-tickless system config dependency
On Sat, Mar 05, 2016 at 06:37:39PM +0100, Maciej S. Szmigiero wrote: > CONFIG_NO_HZ currently only sets the default value > of dynticks config so if PPS kernel consumer needs > periodic timer ticks it should depend on > !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. > > Otherwise it is possible to enable it even on > tickless system which has CONFIG_NO_HZ not set and > CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set. > > Signed-off-by: Maciej S. Szmigiero It's ok for me. Ciao, Rodolfo -- HCE Engineering e-mail: giome...@hce-engineering.com GNU/Linux Solutions giome...@enneenne.com Linux Device Driver giome...@linux.it Embedded Systems phone: +39 349 2432127 UNIX programming skype: rodolfo.giometti Cosino Project - the quick prototyping embedded system - www.cosino.io Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it
[PATCH] pps: kc: fix non-tickless system config dependency
CONFIG_NO_HZ currently only sets the default value of dynticks config so if PPS kernel consumer needs periodic timer ticks it should depend on !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. Otherwise it is possible to enable it even on tickless system which has CONFIG_NO_HZ not set and CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set. Signed-off-by: Maciej S. Szmigiero--- drivers/pps/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig index 7512e98e9311..564a51abeece 100644 --- a/drivers/pps/Kconfig +++ b/drivers/pps/Kconfig @@ -31,7 +31,7 @@ config PPS_DEBUG config NTP_PPS bool "PPS kernel consumer support" - depends on !NO_HZ + depends on !NO_HZ_COMMON help This option adds support for direct in-kernel time synchronization using an external PPS signal.
[PATCH] pps: kc: fix non-tickless system config dependency
CONFIG_NO_HZ currently only sets the default value of dynticks config so if PPS kernel consumer needs periodic timer ticks it should depend on !CONFIG_NO_HZ_COMMON instead of !CONFIG_NO_HZ. Otherwise it is possible to enable it even on tickless system which has CONFIG_NO_HZ not set and CONFIG_NO_HZ_IDLE (or CONFIG_NO_HZ_FULL) set. Signed-off-by: Maciej S. Szmigiero --- drivers/pps/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pps/Kconfig b/drivers/pps/Kconfig index 7512e98e9311..564a51abeece 100644 --- a/drivers/pps/Kconfig +++ b/drivers/pps/Kconfig @@ -31,7 +31,7 @@ config PPS_DEBUG config NTP_PPS bool "PPS kernel consumer support" - depends on !NO_HZ + depends on !NO_HZ_COMMON help This option adds support for direct in-kernel time synchronization using an external PPS signal.