Re: [PATCH] pwm: twl: Use to_twl() instead of container_of()
On Sat, Feb 16, 2013 at 08:54:32PM +0100, Johannes Thumshirn wrote: > Always use to_twl() for converting into private data instead of container_of() > > Signed-off-by: Johannes Thumshirn > --- > drivers/pwm/pwm-twl.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) I've squashed this patch into the previous one and applied to the for-next branch. Thanks, Thierry pgpnRr1zNxf8Y.pgp Description: PGP signature
[PATCH] pwm: twl: Use to_twl() instead of container_of()
Always use to_twl() for converting into private data instead of container_of()
Signed-off-by: Johannes Thumshirn
---
drivers/pwm/pwm-twl.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c
index a34c235..9cd2c9a 100644
--- a/drivers/pwm/pwm-twl.c
+++ b/drivers/pwm/pwm-twl.c
@@ -200,8 +200,7 @@ out:
static void twl4030_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
{
- struct twl_pwm_chip *twl = container_of(chip, struct twl_pwm_chip,
- chip);
+ struct twl_pwm_chip *twl = to_twl(chip);
int ret;
u8 val, mask;
@@ -231,8 +230,7 @@ out:
static int twl6030_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
{
- struct twl_pwm_chip *twl = container_of(chip, struct twl_pwm_chip,
- chip);
+ struct twm_pwm_chip *twl = to_twl(chip);
int ret;
u8 val;
--
1.8.1.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pwm: twl: Use to_twl() instead of container_of()
On Sat, Feb 16, 2013 at 07:56:18PM +0100, Thierry Reding wrote: > On Sat, Feb 16, 2013 at 07:20:51PM +0100, Johannes Thumshirn wrote: > > In twl6030_pwm_disable() use to_twl() instead of container_of() like in the > > rest of the driver. > > > > Signed-off-by: Johannes Thumshirn > > --- > > drivers/pwm/pwm-twl.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > Hi Johannes, > > I see that container_of() is also still used in twl4030_pwm_free() and > twl6030_pwm_enable(). Would you mind fixing those up as well? > > Thierry Oh sorry haven't seen them, I'll take care of it. Johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pwm: twl: Use to_twl() instead of container_of()
On Sat, Feb 16, 2013 at 07:20:51PM +0100, Johannes Thumshirn wrote: > In twl6030_pwm_disable() use to_twl() instead of container_of() like in the > rest of the driver. > > Signed-off-by: Johannes Thumshirn > --- > drivers/pwm/pwm-twl.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Hi Johannes, I see that container_of() is also still used in twl4030_pwm_free() and twl6030_pwm_enable(). Would you mind fixing those up as well? Thierry pgpY7jvkQ9y7U.pgp Description: PGP signature
[PATCH] pwm: twl: Use to_twl() instead of container_of()
In twl6030_pwm_disable() use to_twl() instead of container_of() like in the
rest of the driver.
Signed-off-by: Johannes Thumshirn
---
drivers/pwm/pwm-twl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c
index f783efc..a34c235 100644
--- a/drivers/pwm/pwm-twl.c
+++ b/drivers/pwm/pwm-twl.c
@@ -255,8 +255,7 @@ out:
static void twl6030_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
{
- struct twl_pwm_chip *twl = container_of(chip, struct twl_pwm_chip,
- chip);
+ struct twl_pwm_chip *twl = to_twl(chip);
int ret;
u8 val;
--
1.8.1.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] pwm: twl: Use to_twl() instead of container_of()
In twl6030_pwm_disable() use to_twl() instead of container_of() like in the
rest of the driver.
Signed-off-by: Johannes Thumshirn morbid...@gmail.com
---
drivers/pwm/pwm-twl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c
index f783efc..a34c235 100644
--- a/drivers/pwm/pwm-twl.c
+++ b/drivers/pwm/pwm-twl.c
@@ -255,8 +255,7 @@ out:
static void twl6030_pwm_disable(struct pwm_chip *chip, struct pwm_device *pwm)
{
- struct twl_pwm_chip *twl = container_of(chip, struct twl_pwm_chip,
- chip);
+ struct twl_pwm_chip *twl = to_twl(chip);
int ret;
u8 val;
--
1.8.1.3
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pwm: twl: Use to_twl() instead of container_of()
On Sat, Feb 16, 2013 at 07:20:51PM +0100, Johannes Thumshirn wrote: In twl6030_pwm_disable() use to_twl() instead of container_of() like in the rest of the driver. Signed-off-by: Johannes Thumshirn morbid...@gmail.com --- drivers/pwm/pwm-twl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Hi Johannes, I see that container_of() is also still used in twl4030_pwm_free() and twl6030_pwm_enable(). Would you mind fixing those up as well? Thierry pgpY7jvkQ9y7U.pgp Description: PGP signature
Re: [PATCH] pwm: twl: Use to_twl() instead of container_of()
On Sat, Feb 16, 2013 at 07:56:18PM +0100, Thierry Reding wrote: On Sat, Feb 16, 2013 at 07:20:51PM +0100, Johannes Thumshirn wrote: In twl6030_pwm_disable() use to_twl() instead of container_of() like in the rest of the driver. Signed-off-by: Johannes Thumshirn morbid...@gmail.com --- drivers/pwm/pwm-twl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Hi Johannes, I see that container_of() is also still used in twl4030_pwm_free() and twl6030_pwm_enable(). Would you mind fixing those up as well? Thierry Oh sorry haven't seen them, I'll take care of it. Johannes -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] pwm: twl: Use to_twl() instead of container_of()
Always use to_twl() for converting into private data instead of container_of()
Signed-off-by: Johannes Thumshirn morbid...@gmail.com
---
drivers/pwm/pwm-twl.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/pwm/pwm-twl.c b/drivers/pwm/pwm-twl.c
index a34c235..9cd2c9a 100644
--- a/drivers/pwm/pwm-twl.c
+++ b/drivers/pwm/pwm-twl.c
@@ -200,8 +200,7 @@ out:
static void twl4030_pwm_free(struct pwm_chip *chip, struct pwm_device *pwm)
{
- struct twl_pwm_chip *twl = container_of(chip, struct twl_pwm_chip,
- chip);
+ struct twl_pwm_chip *twl = to_twl(chip);
int ret;
u8 val, mask;
@@ -231,8 +230,7 @@ out:
static int twl6030_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
{
- struct twl_pwm_chip *twl = container_of(chip, struct twl_pwm_chip,
- chip);
+ struct twm_pwm_chip *twl = to_twl(chip);
int ret;
u8 val;
--
1.8.1.3
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] pwm: twl: Use to_twl() instead of container_of()
On Sat, Feb 16, 2013 at 08:54:32PM +0100, Johannes Thumshirn wrote: Always use to_twl() for converting into private data instead of container_of() Signed-off-by: Johannes Thumshirn morbid...@gmail.com --- drivers/pwm/pwm-twl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) I've squashed this patch into the previous one and applied to the for-next branch. Thanks, Thierry pgpnRr1zNxf8Y.pgp Description: PGP signature
