Re: [PATCH] regulator: arizona-ldo1: constify regulator_ops structure

[Charles Keepax]

On Sat, Jan 28, 2017 at 07:08:41PM +0530, Bhumika Goyal wrote:
> Declare regulator_ops structure as const as it is only stored in the ops
> field of a regulator_desc structure. This field is of type const, so
> regulator_ops structures having this property can be made const too.
> 
> File size before: drivers/regulator/arizona-ldo1.o
>text  data bss dec hex filename
>1890   720   02610 a32 drivers/regulator/arizona-ldo1.o
> 
> File size after: drivers/regulator/arizona-ldo1.o
>text  data bss dec hex filename
>2402   192   02594 a22 drivers/regulator/arizona-ldo1.o
> 
> Signed-off-by: Bhumika Goyal 
> ---

Patch looks fine but CCing patc...@opensource.wolfsonmicro.com on
patches to the Arizona driver would be greatly appreciated.

Thanks,
Charles

[PATCH] regulator: arizona-ldo1: constify regulator_ops structure

[Bhumika Goyal]

Declare regulator_ops structure as const as it is only stored in the ops
field of a regulator_desc structure. This field is of type const, so
regulator_ops structures having this property can be made const too.

File size before: drivers/regulator/arizona-ldo1.o
   textdata bss dec hex filename
   1890 720   02610 a32 drivers/regulator/arizona-ldo1.o

File size after: drivers/regulator/arizona-ldo1.o
   textdata bss dec hex filename
   2402 192   02594 a22 drivers/regulator/arizona-ldo1.o

Signed-off-by: Bhumika Goyal 
---
 drivers/regulator/arizona-ldo1.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/arizona-ldo1.c b/drivers/regulator/arizona-ldo1.c
index 302b57c..e76d094 100644
--- a/drivers/regulator/arizona-ldo1.c
+++ b/drivers/regulator/arizona-ldo1.c
@@ -109,7 +109,7 @@ static int arizona_ldo1_hc_get_voltage_sel(struct 
regulator_dev *rdev)
return (val & ARIZONA_LDO1_VSEL_MASK) >> ARIZONA_LDO1_VSEL_SHIFT;
 }
 
-static struct regulator_ops arizona_ldo1_hc_ops = {
+static const struct regulator_ops arizona_ldo1_hc_ops = {
.list_voltage = arizona_ldo1_hc_list_voltage,
.map_voltage = arizona_ldo1_hc_map_voltage,
.get_voltage_sel = arizona_ldo1_hc_get_voltage_sel,
@@ -135,7 +135,7 @@ static int arizona_ldo1_hc_get_voltage_sel(struct 
regulator_dev *rdev)
.owner = THIS_MODULE,
 };
 
-static struct regulator_ops arizona_ldo1_ops = {
+static const struct regulator_ops arizona_ldo1_ops = {
.list_voltage = regulator_list_voltage_linear,
.map_voltage = regulator_map_voltage_linear,
.get_voltage_sel = regulator_get_voltage_sel_regmap,
-- 
1.9.1