Re: [PATCH] regulator: fixed: constify regulator_ops structure

2017-01-31 Thread Mark Brown 
On Sat, Jan 28, 2017 at 07:36:09PM +0530, Bhumika Goyal wrote:
> Declare regulator_ops structure as const as it is only stored in the ops
> field of a regulator_desc structure. This field is of type const, so
> regulator_ops structures having this property can be made const too.

Sorry, it's *this* change that doens't apply - my mistake.


signature.asc
Description: PGP signature

[PATCH] regulator: fixed: constify regulator_ops structure

2017-01-28 Thread Bhumika Goyal 
Declare regulator_ops structure as const as it is only stored in the ops
field of a regulator_desc structure. This field is of type const, so
regulator_ops structures having this property can be made const too.

File size before: drivers/regulator/fixed.o
   textdata bss dec hex filename
  1239  192   01431 597 drivers/regulator/fixed.o

File size after: drivers/regulator/fixed.o
   textdata bss dec hex filename
  1592  100 1281820 71c drivers/regulator/fixed.o

Signed-off-by: Bhumika Goyal 
---
 drivers/regulator/fixed.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/fixed.c b/drivers/regulator/fixed.c
index a43b0e8..9619022 100644
--- a/drivers/regulator/fixed.c
+++ b/drivers/regulator/fixed.c
@@ -135,7 +135,7 @@ struct fixed_voltage_data {
return config;
 }
 
-static struct regulator_ops fixed_voltage_ops = {
+static const struct regulator_ops fixed_voltage_ops = {
 };
 
 static int reg_fixed_voltage_probe(struct platform_device *pdev)
-- 
1.9.1