Re: [PATCH] reject creation of netdev names with colons

2015-02-21 Thread David Miller 
From: Matthew Thode 
Date: Tue, 17 Feb 2015 18:31:57 -0600

> colons are used as a separator in netdev device lookup in dev_ioctl.c
> 
> Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME
> 
> Signed-off-by: Matthew Thode 

Applied thanks.

Please put a proper subsystem prefix in your Subject line
for future patches.  In this case an appropriate prefix
would have been "net: reject..."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] reject creation of netdev names with colons

2015-02-21 Thread David Miller 
From: Matthew Thode mth...@mthode.org
Date: Tue, 17 Feb 2015 18:31:57 -0600

 colons are used as a separator in netdev device lookup in dev_ioctl.c
 
 Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME
 
 Signed-off-by: Matthew Thode mth...@mthode.org

Applied thanks.

Please put a proper subsystem prefix in your Subject line
for future patches.  In this case an appropriate prefix
would have been net: reject...
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] reject creation of netdev names with colons

2015-02-17 Thread Matthew Thode 
colons are used as a separator in netdev device lookup in dev_ioctl.c

Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME

Signed-off-by: Matthew Thode 
---
 net/core/dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index d030575..efbad386 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -946,7 +946,7 @@ bool dev_valid_name(const char *name)
return false;
 
while (*name) {
-   if (*name == '/' || isspace(*name))
+   if (*name == '/' || *name == ':' || isspace(*name))
return false;
name++;
}
-- 
2.0.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] reject creation of netdev names with colons

2015-02-17 Thread Matthew Thode 
colons are used as a separator in netdev device lookup in dev_ioctl.c

Specific functions are SIOCGIFTXQLEN SIOCETHTOOL SIOCSIFNAME

Signed-off-by: Matthew Thode mth...@mthode.org
---
 net/core/dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index d030575..efbad386 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -946,7 +946,7 @@ bool dev_valid_name(const char *name)
return false;
 
while (*name) {
-   if (*name == '/' || isspace(*name))
+   if (*name == '/' || *name == ':' || isspace(*name))
return false;
name++;
}
-- 
2.0.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/