Re: [PATCH] reset: Add optional resets and stubs
On 03/07/14 16:30, Philipp Zabel wrote: This patch adds device_reset_optional and (devm_)reset_control_get_optional variants that drivers can use to indicate they can function without control over the reset line. For those functions, stubs are added so the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled. Also, device_reset is annotated with __must_check. Drivers ignoring the return value should use device_reset_optional instead. Signed-off-by: Philipp Zabel Thanks. Reviewed-by: Ivan T. Ivanov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] reset: Add optional resets and stubs
On 03/07/14 16:30, Philipp Zabel wrote: This patch adds device_reset_optional and (devm_)reset_control_get_optional variants that drivers can use to indicate they can function without control over the reset line. For those functions, stubs are added so the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled. Also, device_reset is annotated with __must_check. Drivers ignoring the return value should use device_reset_optional instead. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Thanks. Reviewed-by: Ivan T. Ivanov iiva...@mm-sol.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] reset: Add optional resets and stubs
On Fri, Mar 07, 2014 at 03:30:23PM +0100, Philipp Zabel wrote: > This patch adds device_reset_optional and (devm_)reset_control_get_optional > variants that drivers can use to indicate they can function without control > over the reset line. For those functions, stubs are added so the drivers can > be compiled with CONFIG_RESET_CONTROLLER disabled. > Also, device_reset is annotated with __must_check. Drivers ignoring the return > value should use device_reset_optional instead. > > Signed-off-by: Philipp Zabel Acked-by: Wolfram Sang signature.asc Description: Digital signature
Re: [PATCH] reset: Add optional resets and stubs
On Friday, March 07, 2014 at 03:30:23 PM, Philipp Zabel wrote: > This patch adds device_reset_optional and (devm_)reset_control_get_optional > variants that drivers can use to indicate they can function without control > over the reset line. For those functions, stubs are added so the drivers > can be compiled with CONFIG_RESET_CONTROLLER disabled. > Also, device_reset is annotated with __must_check. Drivers ignoring the > return value should use device_reset_optional instead. > > Signed-off-by: Philipp Zabel Nice. Reviewed-by: Marek Vasut Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] reset: Add optional resets and stubs
On Friday, March 07, 2014 at 03:30:23 PM, Philipp Zabel wrote: This patch adds device_reset_optional and (devm_)reset_control_get_optional variants that drivers can use to indicate they can function without control over the reset line. For those functions, stubs are added so the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled. Also, device_reset is annotated with __must_check. Drivers ignoring the return value should use device_reset_optional instead. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Nice. Reviewed-by: Marek Vasut ma...@denx.de Best regards, Marek Vasut -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] reset: Add optional resets and stubs
On Fri, Mar 07, 2014 at 03:30:23PM +0100, Philipp Zabel wrote: This patch adds device_reset_optional and (devm_)reset_control_get_optional variants that drivers can use to indicate they can function without control over the reset line. For those functions, stubs are added so the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled. Also, device_reset is annotated with __must_check. Drivers ignoring the return value should use device_reset_optional instead. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Acked-by: Wolfram Sang w...@the-dreams.de signature.asc Description: Digital signature
Re: [PATCH] reset: Add optional resets and stubs
Hi Philipp, On Fri, Mar 07, 2014 at 03:30:23PM +0100, Philipp Zabel wrote: > This patch adds device_reset_optional and (devm_)reset_control_get_optional > variants that drivers can use to indicate they can function without control > over the reset line. For those functions, stubs are added so the drivers can > be compiled with CONFIG_RESET_CONTROLLER disabled. > Also, device_reset is annotated with __must_check. Drivers ignoring the return > value should use device_reset_optional instead. > > Signed-off-by: Philipp Zabel Reviewed-by: Maxime Ripard Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature
Re: [PATCH] reset: Add optional resets and stubs
Hi Wolfram, Am Freitag, den 07.03.2014, 16:39 +0100 schrieb Wolfram Sang: > On Fri, Mar 07, 2014 at 03:30:23PM +0100, Philipp Zabel wrote: > > This patch adds device_reset_optional and (devm_)reset_control_get_optional > > variants that drivers can use to indicate they can function without control > > over the reset line. For those functions, stubs are added so the drivers can > > be compiled with CONFIG_RESET_CONTROLLER disabled. > > Also, device_reset is annotated with __must_check. Drivers ignoring the > > return > > value should use device_reset_optional instead. > > > > Signed-off-by: Philipp Zabel > > Yay, thanks for fixing that! Do you pick it up yourself? yes, I can do that. Does this work for all interested parties? regards Philipp -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] reset: Add optional resets and stubs
On Fri, Mar 07, 2014 at 03:30:23PM +0100, Philipp Zabel wrote: > This patch adds device_reset_optional and (devm_)reset_control_get_optional > variants that drivers can use to indicate they can function without control > over the reset line. For those functions, stubs are added so the drivers can > be compiled with CONFIG_RESET_CONTROLLER disabled. > Also, device_reset is annotated with __must_check. Drivers ignoring the return > value should use device_reset_optional instead. > > Signed-off-by: Philipp Zabel Yay, thanks for fixing that! Do you pick it up yourself? signature.asc Description: Digital signature
[PATCH] reset: Add optional resets and stubs
This patch adds device_reset_optional and (devm_)reset_control_get_optional
variants that drivers can use to indicate they can function without control
over the reset line. For those functions, stubs are added so the drivers can
be compiled with CONFIG_RESET_CONTROLLER disabled.
Also, device_reset is annotated with __must_check. Drivers ignoring the return
value should use device_reset_optional instead.
Signed-off-by: Philipp Zabel
---
include/linux/reset.h | 71 ++-
1 file changed, 64 insertions(+), 7 deletions(-)
diff --git a/include/linux/reset.h b/include/linux/reset.h
index 10c44ab..c0eda50 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -1,23 +1,80 @@
#ifndef _LINUX_RESET_H_
#define _LINUX_RESET_H_
-#include
-
struct device;
struct reset_control;
+#ifdef CONFIG_RESET_CONTROLLER
+
int reset_control_reset(struct reset_control *rstc);
-int reset_control_reset_udelay(struct reset_control *rstc, unsigned long
usecs);
-int reset_control_reset_msleep(struct reset_control *rstc, unsigned long
msecs);
int reset_control_assert(struct reset_control *rstc);
int reset_control_deassert(struct reset_control *rstc);
-struct reset_control *of_reset_control_get(struct device_node *node,
- const char *id);
struct reset_control *reset_control_get(struct device *dev, const char *id);
void reset_control_put(struct reset_control *rstc);
struct reset_control *devm_reset_control_get(struct device *dev, const char
*id);
-int device_reset(struct device *dev);
+int __must_check device_reset(struct device *dev);
+
+static inline int device_reset_optional(struct device *dev)
+{
+ return device_reset(dev);
+}
+
+static inline struct reset_control *reset_control_get_optional(
+ struct device *dev, const char *id)
+{
+ return reset_control_get(dev, id);
+}
+
+static inline struct reset_control *devm_reset_control_get_optional(
+ struct device *dev, const char *id)
+{
+ return devm_reset_control_get(dev, id);
+}
+
+#else
+
+static inline int reset_control_reset(struct reset_control *rstc)
+{
+ WARN_ON(1);
+ return 0;
+}
+
+static inline int reset_control_assert(struct reset_control *rstc)
+{
+ WARN_ON(1);
+ return 0;
+}
+
+static inline int reset_control_deassert(struct reset_control *rstc)
+{
+ WARN_ON(1);
+ return 0;
+}
+
+static inline void reset_control_put(struct reset_control *rstc)
+{
+ WARN_ON(1);
+}
+
+static inline int device_reset_optional(struct device *dev)
+{
+ return -ENOSYS;
+}
+
+static inline struct reset_control *reset_control_get_optional(
+ struct device *dev, const char *id)
+{
+ return ERR_PTR(-ENOSYS);
+}
+
+static inline struct reset_control *devm_reset_control_get_optional(
+ struct device *dev, const char *id)
+{
+ return ERR_PTR(-ENOSYS);
+}
+
+#endif /* CONFIG_RESET_CONTROLLER */
#endif
--
1.9.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] reset: Add optional resets and stubs
This patch adds device_reset_optional and (devm_)reset_control_get_optional
variants that drivers can use to indicate they can function without control
over the reset line. For those functions, stubs are added so the drivers can
be compiled with CONFIG_RESET_CONTROLLER disabled.
Also, device_reset is annotated with __must_check. Drivers ignoring the return
value should use device_reset_optional instead.
Signed-off-by: Philipp Zabel p.za...@pengutronix.de
---
include/linux/reset.h | 71 ++-
1 file changed, 64 insertions(+), 7 deletions(-)
diff --git a/include/linux/reset.h b/include/linux/reset.h
index 10c44ab..c0eda50 100644
--- a/include/linux/reset.h
+++ b/include/linux/reset.h
@@ -1,23 +1,80 @@
#ifndef _LINUX_RESET_H_
#define _LINUX_RESET_H_
-#include linux/of.h
-
struct device;
struct reset_control;
+#ifdef CONFIG_RESET_CONTROLLER
+
int reset_control_reset(struct reset_control *rstc);
-int reset_control_reset_udelay(struct reset_control *rstc, unsigned long
usecs);
-int reset_control_reset_msleep(struct reset_control *rstc, unsigned long
msecs);
int reset_control_assert(struct reset_control *rstc);
int reset_control_deassert(struct reset_control *rstc);
-struct reset_control *of_reset_control_get(struct device_node *node,
- const char *id);
struct reset_control *reset_control_get(struct device *dev, const char *id);
void reset_control_put(struct reset_control *rstc);
struct reset_control *devm_reset_control_get(struct device *dev, const char
*id);
-int device_reset(struct device *dev);
+int __must_check device_reset(struct device *dev);
+
+static inline int device_reset_optional(struct device *dev)
+{
+ return device_reset(dev);
+}
+
+static inline struct reset_control *reset_control_get_optional(
+ struct device *dev, const char *id)
+{
+ return reset_control_get(dev, id);
+}
+
+static inline struct reset_control *devm_reset_control_get_optional(
+ struct device *dev, const char *id)
+{
+ return devm_reset_control_get(dev, id);
+}
+
+#else
+
+static inline int reset_control_reset(struct reset_control *rstc)
+{
+ WARN_ON(1);
+ return 0;
+}
+
+static inline int reset_control_assert(struct reset_control *rstc)
+{
+ WARN_ON(1);
+ return 0;
+}
+
+static inline int reset_control_deassert(struct reset_control *rstc)
+{
+ WARN_ON(1);
+ return 0;
+}
+
+static inline void reset_control_put(struct reset_control *rstc)
+{
+ WARN_ON(1);
+}
+
+static inline int device_reset_optional(struct device *dev)
+{
+ return -ENOSYS;
+}
+
+static inline struct reset_control *reset_control_get_optional(
+ struct device *dev, const char *id)
+{
+ return ERR_PTR(-ENOSYS);
+}
+
+static inline struct reset_control *devm_reset_control_get_optional(
+ struct device *dev, const char *id)
+{
+ return ERR_PTR(-ENOSYS);
+}
+
+#endif /* CONFIG_RESET_CONTROLLER */
#endif
--
1.9.0
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] reset: Add optional resets and stubs
On Fri, Mar 07, 2014 at 03:30:23PM +0100, Philipp Zabel wrote: This patch adds device_reset_optional and (devm_)reset_control_get_optional variants that drivers can use to indicate they can function without control over the reset line. For those functions, stubs are added so the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled. Also, device_reset is annotated with __must_check. Drivers ignoring the return value should use device_reset_optional instead. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Yay, thanks for fixing that! Do you pick it up yourself? signature.asc Description: Digital signature
Re: [PATCH] reset: Add optional resets and stubs
Hi Wolfram, Am Freitag, den 07.03.2014, 16:39 +0100 schrieb Wolfram Sang: On Fri, Mar 07, 2014 at 03:30:23PM +0100, Philipp Zabel wrote: This patch adds device_reset_optional and (devm_)reset_control_get_optional variants that drivers can use to indicate they can function without control over the reset line. For those functions, stubs are added so the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled. Also, device_reset is annotated with __must_check. Drivers ignoring the return value should use device_reset_optional instead. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Yay, thanks for fixing that! Do you pick it up yourself? yes, I can do that. Does this work for all interested parties? regards Philipp -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] reset: Add optional resets and stubs
Hi Philipp, On Fri, Mar 07, 2014 at 03:30:23PM +0100, Philipp Zabel wrote: This patch adds device_reset_optional and (devm_)reset_control_get_optional variants that drivers can use to indicate they can function without control over the reset line. For those functions, stubs are added so the drivers can be compiled with CONFIG_RESET_CONTROLLER disabled. Also, device_reset is annotated with __must_check. Drivers ignoring the return value should use device_reset_optional instead. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Reviewed-by: Maxime Ripard maxime.rip...@free-electrons.com Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com signature.asc Description: Digital signature
