Re: [PATCH] rtc: test: make array pdev static
On 24/06/2018 11:38:03+0100, Colin King wrote: > From: Colin Ian King > > The array pdev is local to the source and does not need to be in > global scope, so make it static. > > Cleans up sparse warning: > symbol 'pdev' was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > drivers/rtc/rtc-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
Re: [PATCH] rtc: test: make array pdev static
On 24/06/2018 11:38:03+0100, Colin King wrote: > From: Colin Ian King > > The array pdev is local to the source and does not need to be in > global scope, so make it static. > > Cleans up sparse warning: > symbol 'pdev' was not declared. Should it be static? > > Signed-off-by: Colin Ian King > --- > drivers/rtc/rtc-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com
[PATCH] rtc: test: make array pdev static
From: Colin Ian King
The array pdev is local to the source and does not need to be in
global scope, so make it static.
Cleans up sparse warning:
symbol 'pdev' was not declared. Should it be static?
Signed-off-by: Colin Ian King
---
drivers/rtc/rtc-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-test.c b/drivers/rtc/rtc-test.c
index 8469256edc2a..ade6a82709be 100644
--- a/drivers/rtc/rtc-test.c
+++ b/drivers/rtc/rtc-test.c
@@ -22,7 +22,7 @@ struct rtc_test_data {
bool alarm_en;
};
-struct platform_device *pdev[MAX_RTC_TEST];
+static struct platform_device *pdev[MAX_RTC_TEST];
static int test_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
{
--
2.17.0
[PATCH] rtc: test: make array pdev static
From: Colin Ian King
The array pdev is local to the source and does not need to be in
global scope, so make it static.
Cleans up sparse warning:
symbol 'pdev' was not declared. Should it be static?
Signed-off-by: Colin Ian King
---
drivers/rtc/rtc-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/rtc/rtc-test.c b/drivers/rtc/rtc-test.c
index 8469256edc2a..ade6a82709be 100644
--- a/drivers/rtc/rtc-test.c
+++ b/drivers/rtc/rtc-test.c
@@ -22,7 +22,7 @@ struct rtc_test_data {
bool alarm_en;
};
-struct platform_device *pdev[MAX_RTC_TEST];
+static struct platform_device *pdev[MAX_RTC_TEST];
static int test_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
{
--
2.17.0
