Re: [PATCH] samples/kprobes: Add riscv support

[Palmer Dabbelt]

On Mon, 29 Mar 2021 11:04:16 PDT (-0700), jszha...@mail.ustc.edu.cn wrote:

From: Jisheng Zhang 

Add riscv specific info dump in both handler_pre() and handler_post().

Signed-off-by: Jisheng Zhang 
---
 samples/kprobes/kprobe_example.c | 8 
 1 file changed, 8 insertions(+)

diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
index 331dcf151532..c495664c0a9b 100644
--- a/samples/kprobes/kprobe_example.c
+++ b/samples/kprobes/kprobe_example.c
@@ -47,6 +47,10 @@ static int __kprobes handler_pre(struct kprobe *p, struct 
pt_regs *regs)
pr_info("<%s> pre_handler: p->addr = 0x%p, pc = 0x%lx, cpsr = 0x%lx\n",
p->symbol_name, p->addr, (long)regs->ARM_pc, 
(long)regs->ARM_cpsr);
 #endif
+#ifdef CONFIG_RISCV
+   pr_info("<%s> pre_handler: p->addr = 0x%p, pc = 0x%lx, status = 
0x%lx\n",
+   p->symbol_name, p->addr, regs->epc, regs->status);
+#endif
 #ifdef CONFIG_S390
pr_info("<%s> pre_handler: p->addr, 0x%p, ip = 0x%lx, flags = 0x%lx\n",
p->symbol_name, p->addr, regs->psw.addr, regs->flags);
@@ -80,6 +84,10 @@ static void __kprobes handler_post(struct kprobe *p, struct 
pt_regs *regs,
pr_info("<%s> post_handler: p->addr = 0x%p, cpsr = 0x%lx\n",
p->symbol_name, p->addr, (long)regs->ARM_cpsr);
 #endif
+#ifdef CONFIG_RISCV
+   pr_info("<%s> post_handler: p->addr = 0x%p, status = 0x%lx\n",
+   p->symbol_name, p->addr, regs->status);
+#endif
 #ifdef CONFIG_S390
pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n",
p->symbol_name, p->addr, regs->flags);


Thanks, this is on for-next.

Re: [PATCH] samples/kprobes: Add riscv support

[Masami Hiramatsu]

On Tue, 30 Mar 2021 02:04:16 +0800
Jisheng Zhang  wrote:

> From: Jisheng Zhang 
> 
> Add riscv specific info dump in both handler_pre() and handler_post().
> 

Looks good to me.

Acked-by: Masami Hiramatsu 

Thanks!

> Signed-off-by: Jisheng Zhang 
> ---
>  samples/kprobes/kprobe_example.c | 8 
>  1 file changed, 8 insertions(+)
> 
> diff --git a/samples/kprobes/kprobe_example.c 
> b/samples/kprobes/kprobe_example.c
> index 331dcf151532..c495664c0a9b 100644
> --- a/samples/kprobes/kprobe_example.c
> +++ b/samples/kprobes/kprobe_example.c
> @@ -47,6 +47,10 @@ static int __kprobes handler_pre(struct kprobe *p, struct 
> pt_regs *regs)
>   pr_info("<%s> pre_handler: p->addr = 0x%p, pc = 0x%lx, cpsr = 0x%lx\n",
>   p->symbol_name, p->addr, (long)regs->ARM_pc, 
> (long)regs->ARM_cpsr);
>  #endif
> +#ifdef CONFIG_RISCV
> + pr_info("<%s> pre_handler: p->addr = 0x%p, pc = 0x%lx, status = 
> 0x%lx\n",
> + p->symbol_name, p->addr, regs->epc, regs->status);
> +#endif
>  #ifdef CONFIG_S390
>   pr_info("<%s> pre_handler: p->addr, 0x%p, ip = 0x%lx, flags = 0x%lx\n",
>   p->symbol_name, p->addr, regs->psw.addr, regs->flags);
> @@ -80,6 +84,10 @@ static void __kprobes handler_post(struct kprobe *p, 
> struct pt_regs *regs,
>   pr_info("<%s> post_handler: p->addr = 0x%p, cpsr = 0x%lx\n",
>   p->symbol_name, p->addr, (long)regs->ARM_cpsr);
>  #endif
> +#ifdef CONFIG_RISCV
> + pr_info("<%s> post_handler: p->addr = 0x%p, status = 0x%lx\n",
> + p->symbol_name, p->addr, regs->status);
> +#endif
>  #ifdef CONFIG_S390
>   pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n",
>   p->symbol_name, p->addr, regs->flags);
> -- 
> 2.31.0
> 
> 


-- 
Masami Hiramatsu 

[PATCH] samples/kprobes: Add riscv support

[Jisheng Zhang]

From: Jisheng Zhang 

Add riscv specific info dump in both handler_pre() and handler_post().

Signed-off-by: Jisheng Zhang 
---
 samples/kprobes/kprobe_example.c | 8 
 1 file changed, 8 insertions(+)

diff --git a/samples/kprobes/kprobe_example.c b/samples/kprobes/kprobe_example.c
index 331dcf151532..c495664c0a9b 100644
--- a/samples/kprobes/kprobe_example.c
+++ b/samples/kprobes/kprobe_example.c
@@ -47,6 +47,10 @@ static int __kprobes handler_pre(struct kprobe *p, struct 
pt_regs *regs)
pr_info("<%s> pre_handler: p->addr = 0x%p, pc = 0x%lx, cpsr = 0x%lx\n",
p->symbol_name, p->addr, (long)regs->ARM_pc, 
(long)regs->ARM_cpsr);
 #endif
+#ifdef CONFIG_RISCV
+   pr_info("<%s> pre_handler: p->addr = 0x%p, pc = 0x%lx, status = 
0x%lx\n",
+   p->symbol_name, p->addr, regs->epc, regs->status);
+#endif
 #ifdef CONFIG_S390
pr_info("<%s> pre_handler: p->addr, 0x%p, ip = 0x%lx, flags = 0x%lx\n",
p->symbol_name, p->addr, regs->psw.addr, regs->flags);
@@ -80,6 +84,10 @@ static void __kprobes handler_post(struct kprobe *p, struct 
pt_regs *regs,
pr_info("<%s> post_handler: p->addr = 0x%p, cpsr = 0x%lx\n",
p->symbol_name, p->addr, (long)regs->ARM_cpsr);
 #endif
+#ifdef CONFIG_RISCV
+   pr_info("<%s> post_handler: p->addr = 0x%p, status = 0x%lx\n",
+   p->symbol_name, p->addr, regs->status);
+#endif
 #ifdef CONFIG_S390
pr_info("<%s> pre_handler: p->addr, 0x%p, flags = 0x%lx\n",
p->symbol_name, p->addr, regs->flags);
-- 
2.31.0