Re: [PATCH] sched/fair: fix coccinelle warnings

[Peter Zijlstra]

On Mon, Jul 15, 2019 at 10:45:26AM +0800, Yi Wang wrote:
> This fixes the following coccinelle warning:
> ./kernel/sched/fair.c:8688:9-10: WARNING: return of 0/1 in function 
> 'voluntary_active_balance' with return type bool
> 
> Return type bool instead of 0/1.

I don't much appreciate these patches. I think 0/1 are perfectly fine
return values for a boolean function.

[PATCH] sched/fair: fix coccinelle warnings

[Yi Wang]

This fixes the following coccinelle warning:
./kernel/sched/fair.c:8688:9-10: WARNING: return of 0/1 in function 
'voluntary_active_balance' with return type bool

Return type bool instead of 0/1.

Signed-off-by: Yi Wang 
---
 kernel/sched/fair.c | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 036be95..c44b157 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8685,7 +8685,7 @@ static struct rq *find_busiest_queue(struct lb_env *env,
struct sched_domain *sd = env->sd;
 
if (asym_active_balance(env))
-   return 1;
+   return true;
 
/*
 * The dst_cpu is idle and the src_cpu CPU has only 1 CFS task.
@@ -8697,13 +8697,13 @@ static struct rq *find_busiest_queue(struct lb_env *env,
(env->src_rq->cfs.h_nr_running == 1)) {
if ((check_cpu_capacity(env->src_rq, sd)) &&
(capacity_of(env->src_cpu)*sd->imbalance_pct < 
capacity_of(env->dst_cpu)*100))
-   return 1;
+   return true;
}
 
if (env->src_grp_type == group_misfit_task)
-   return 1;
+   return true;
 
-   return 0;
+   return false;
 }
 
 static int need_active_balance(struct lb_env *env)
-- 
1.8.3.1