In the case of a failed retry, a positive value EIO is returned here.
I think this is a typo error. It is necessary to return an error value.
Fixes: 0691094ff3f2c ("scsi: qla2xxx: Add logic to detect ABTS hang and
response completion")
Cc: Quinn Tran
Signed-off-by: Tianjia Zhang
---
drivers/scsi/qla2xxx/qla_target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c
b/drivers/scsi/qla2xxx/qla_target.c
index c2c0e6049da4..f2bb841c2059 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -5668,7 +5668,7 @@ static int qlt_chk_unresolv_exchg(struct scsi_qla_host
*vha,
/* found existing exchange */
qpair->retry_term_cnt++;
if (qpair->retry_term_cnt >= 5) {
- rc = EIO;
+ rc = -EIO;
qpair->retry_term_cnt = 0;
ql_log(ql_log_warn, vha, 0x,
"Unable to send ABTS Respond. Dumping firmware.\n");
--
2.26.2