Re: [PATCH] selftests/futex: Check ANSI terminal color support
On 10/10/2016 05:15 PM, SeongJae Park wrote: > Hi, > > > Shuah, may I ask your comment about this patch? > > Looks good to me. I also see Daren's Ack. I will get this into 4.9-rc1. thanks, -- Shuah
Re: [PATCH] selftests/futex: Check ANSI terminal color support
Hi, Shuah, may I ask your comment about this patch? Thanks, SeongJae Park On Sun, Oct 2, 2016 at 11:02 AM, SeongJae Park wrote: > Because test for color support of the running shell does not aware ANSI > type terminals, it does not print colorful messages on some environemnt. > This commit modifies the test to aware ANSI type terminal, too. > > Signed-off-by: SeongJae Park > --- > tools/testing/selftests/futex/functional/run.sh | 2 +- > tools/testing/selftests/futex/run.sh| 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/futex/functional/run.sh > b/tools/testing/selftests/futex/functional/run.sh > index e87dbe2a0b0d..7ff002eed624 100755 > --- a/tools/testing/selftests/futex/functional/run.sh > +++ b/tools/testing/selftests/futex/functional/run.sh > @@ -24,7 +24,7 @@ > > # Test for a color capable console > if [ -z "$USE_COLOR" ]; then > -tput setf 7 > +tput setf 7 || tput setaf 7 > if [ $? -eq 0 ]; then > USE_COLOR=1 > tput sgr0 > diff --git a/tools/testing/selftests/futex/run.sh > b/tools/testing/selftests/futex/run.sh > index 4126312ad64e..88bcb1767362 100755 > --- a/tools/testing/selftests/futex/run.sh > +++ b/tools/testing/selftests/futex/run.sh > @@ -23,7 +23,7 @@ > > # Test for a color capable shell and pass the result to the subdir scripts > USE_COLOR=0 > -tput setf 7 > +tput setf 7 || tput setaf 7 > if [ $? -eq 0 ]; then > USE_COLOR=1 > tput sgr0 > -- > 2.10.0 >
Re: [PATCH] selftests/futex: Check ANSI terminal color support
On Sun, Oct 02, 2016 at 11:02:18AM +0900, SeongJae Park wrote: > Because test for color support of the running shell does not aware ANSI > type terminals, it does not print colorful messages on some environemnt. > This commit modifies the test to aware ANSI type terminal, too. > > Signed-off-by: SeongJae Park No objection. Terminfo slists these separately, and I don't see a way to handle ANSI in a single command. Acked-by: Darren Hart > --- > tools/testing/selftests/futex/functional/run.sh | 2 +- > tools/testing/selftests/futex/run.sh| 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/futex/functional/run.sh > b/tools/testing/selftests/futex/functional/run.sh > index e87dbe2a0b0d..7ff002eed624 100755 > --- a/tools/testing/selftests/futex/functional/run.sh > +++ b/tools/testing/selftests/futex/functional/run.sh > @@ -24,7 +24,7 @@ > > # Test for a color capable console > if [ -z "$USE_COLOR" ]; then > -tput setf 7 > +tput setf 7 || tput setaf 7 > if [ $? -eq 0 ]; then > USE_COLOR=1 > tput sgr0 > diff --git a/tools/testing/selftests/futex/run.sh > b/tools/testing/selftests/futex/run.sh > index 4126312ad64e..88bcb1767362 100755 > --- a/tools/testing/selftests/futex/run.sh > +++ b/tools/testing/selftests/futex/run.sh > @@ -23,7 +23,7 @@ > > # Test for a color capable shell and pass the result to the subdir scripts > USE_COLOR=0 > -tput setf 7 > +tput setf 7 || tput setaf 7 > if [ $? -eq 0 ]; then > USE_COLOR=1 > tput sgr0 > -- > 2.10.0 > > -- Darren Hart Intel Open Source Technology Center
[PATCH] selftests/futex: Check ANSI terminal color support
Because test for color support of the running shell does not aware ANSI type terminals, it does not print colorful messages on some environemnt. This commit modifies the test to aware ANSI type terminal, too. Signed-off-by: SeongJae Park --- tools/testing/selftests/futex/functional/run.sh | 2 +- tools/testing/selftests/futex/run.sh| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/futex/functional/run.sh b/tools/testing/selftests/futex/functional/run.sh index e87dbe2a0b0d..7ff002eed624 100755 --- a/tools/testing/selftests/futex/functional/run.sh +++ b/tools/testing/selftests/futex/functional/run.sh @@ -24,7 +24,7 @@ # Test for a color capable console if [ -z "$USE_COLOR" ]; then -tput setf 7 +tput setf 7 || tput setaf 7 if [ $? -eq 0 ]; then USE_COLOR=1 tput sgr0 diff --git a/tools/testing/selftests/futex/run.sh b/tools/testing/selftests/futex/run.sh index 4126312ad64e..88bcb1767362 100755 --- a/tools/testing/selftests/futex/run.sh +++ b/tools/testing/selftests/futex/run.sh @@ -23,7 +23,7 @@ # Test for a color capable shell and pass the result to the subdir scripts USE_COLOR=0 -tput setf 7 +tput setf 7 || tput setaf 7 if [ $? -eq 0 ]; then USE_COLOR=1 tput sgr0 -- 2.10.0
