Re: [PATCH] serial: efm32: add module_exit

2014-05-25 Thread Uwe Kleine-König
On Sun, May 25, 2014 at 11:13:05PM +0200, Vincent Stehlé wrote:
> Add missing specification of efm32_uart_exit as module_exit.
> 
> This fixes the following compilation warning:
> 
>   drivers/tty/serial/efm32-uart.c:840:123: warning: ‘efm32_uart_exit’ defined 
> but not used [-Wunused-function]
This warning doesn't occur in my builds, probably because I have
MODULES=n. I can reproduce it on allmodconfig though.
 
> Signed-off-by: Vincent Stehlé 
> Cc: Uwe Kleine-König 
Acked-by: Uwe Kleine-König 

Thanks
Uwe

-- 
Pengutronix e.K.   | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] serial: efm32: add module_exit

2014-05-25 Thread Vincent Stehlé
Add missing specification of efm32_uart_exit as module_exit.

This fixes the following compilation warning:

  drivers/tty/serial/efm32-uart.c:840:123: warning: ‘efm32_uart_exit’ defined 
but not used [-Wunused-function]

Signed-off-by: Vincent Stehlé 
Cc: Uwe Kleine-König 
Cc: Greg Kroah-Hartman 
Cc: Jiri Slaby 
---

Hi,

This can be seen with e.g. arm allmodconfig.

Best regards,

V.

 drivers/tty/serial/efm32-uart.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/efm32-uart.c b/drivers/tty/serial/efm32-uart.c
index c167a71..b373f64 100644
--- a/drivers/tty/serial/efm32-uart.c
+++ b/drivers/tty/serial/efm32-uart.c
@@ -842,6 +842,7 @@ static void __exit efm32_uart_exit(void)
platform_driver_unregister(_uart_driver);
uart_unregister_driver(_uart_reg);
 }
+module_exit(efm32_uart_exit);
 
 MODULE_AUTHOR("Uwe Kleine-Koenig ");
 MODULE_DESCRIPTION("EFM32 UART/USART driver");
-- 
2.0.0.rc2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] serial: efm32: add module_exit

2014-05-25 Thread Vincent Stehlé
Add missing specification of efm32_uart_exit as module_exit.

This fixes the following compilation warning:

  drivers/tty/serial/efm32-uart.c:840:123: warning: ‘efm32_uart_exit’ defined 
but not used [-Wunused-function]

Signed-off-by: Vincent Stehlé vincent.ste...@laposte.net
Cc: Uwe Kleine-König u.kleine-koe...@pengutronix.de
Cc: Greg Kroah-Hartman gre...@suse.de
Cc: Jiri Slaby jsl...@suse.cz
---

Hi,

This can be seen with e.g. arm allmodconfig.

Best regards,

V.

 drivers/tty/serial/efm32-uart.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/efm32-uart.c b/drivers/tty/serial/efm32-uart.c
index c167a71..b373f64 100644
--- a/drivers/tty/serial/efm32-uart.c
+++ b/drivers/tty/serial/efm32-uart.c
@@ -842,6 +842,7 @@ static void __exit efm32_uart_exit(void)
platform_driver_unregister(efm32_uart_driver);
uart_unregister_driver(efm32_uart_reg);
 }
+module_exit(efm32_uart_exit);
 
 MODULE_AUTHOR(Uwe Kleine-Koenig u.kleine-koe...@pengutronix.de);
 MODULE_DESCRIPTION(EFM32 UART/USART driver);
-- 
2.0.0.rc2

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] serial: efm32: add module_exit

2014-05-25 Thread Uwe Kleine-König
On Sun, May 25, 2014 at 11:13:05PM +0200, Vincent Stehlé wrote:
 Add missing specification of efm32_uart_exit as module_exit.
 
 This fixes the following compilation warning:
 
   drivers/tty/serial/efm32-uart.c:840:123: warning: ‘efm32_uart_exit’ defined 
 but not used [-Wunused-function]
This warning doesn't occur in my builds, probably because I have
MODULES=n. I can reproduce it on allmodconfig though.
 
 Signed-off-by: Vincent Stehlé vincent.ste...@laposte.net
 Cc: Uwe Kleine-König u.kleine-koe...@pengutronix.de
Acked-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de

Thanks
Uwe

-- 
Pengutronix e.K.   | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/