Re: [PATCH] serial: stm32: fix initialization of RS485 mode

[Arnd Bergmann]

On Thu, Mar 15, 2018 at 9:44 AM, Bich HEMON  wrote:
> Configure RS485 mode during port initialization.
>
> Fixes: 1bcda09d291081a7732fcaa9d1745312404a4e36 ("serial: stm32: add
> support for RS485 hardware control mode")
>
> Signed-off-by: Bich Hemon 

I noticed the unused-function warning from the original patch, and the
patch also fixes that (besides looking like it does the right thing).

Acked-by: Arnd Bergmann 

Re: [PATCH] serial: stm32: fix initialization of RS485 mode

[Arnd Bergmann]

On Thu, Mar 15, 2018 at 9:44 AM, Bich HEMON  wrote:
> Configure RS485 mode during port initialization.
>
> Fixes: 1bcda09d291081a7732fcaa9d1745312404a4e36 ("serial: stm32: add
> support for RS485 hardware control mode")
>
> Signed-off-by: Bich Hemon 

I noticed the unused-function warning from the original patch, and the
patch also fixes that (besides looking like it does the right thing).

Acked-by: Arnd Bergmann 

[PATCH] serial: stm32: fix initialization of RS485 mode

[Bich HEMON]

Configure RS485 mode during port initialization.

Fixes: 1bcda09d291081a7732fcaa9d1745312404a4e36 ("serial: stm32: add
support for RS485 hardware control mode")

Signed-off-by: Bich Hemon 
---
 drivers/tty/serial/stm32-usart.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
index 345fbf3..e8d7a7b 100644
--- a/drivers/tty/serial/stm32-usart.c
+++ b/drivers/tty/serial/stm32-usart.c
@@ -809,6 +809,10 @@ static int stm32_init_port(struct stm32_port *stm32port,
port->ops   = _uart_ops;
port->dev   = >dev;
port->irq   = platform_get_irq(pdev, 0);
+   port->rs485_config = stm32_config_rs485;
+
+   stm32_init_rs485(port, pdev);
+
stm32port->wakeirq = platform_get_irq(pdev, 1);
stm32port->fifoen = stm32port->info->cfg.has_fifo;
 
-- 
1.9.1

[PATCH] serial: stm32: fix initialization of RS485 mode

[Bich HEMON]

Configure RS485 mode during port initialization.

Fixes: 1bcda09d291081a7732fcaa9d1745312404a4e36 ("serial: stm32: add
support for RS485 hardware control mode")

Signed-off-by: Bich Hemon 
---
 drivers/tty/serial/stm32-usart.c | 4 
 1 file changed, 4 insertions(+)

diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-usart.c
index 345fbf3..e8d7a7b 100644
--- a/drivers/tty/serial/stm32-usart.c
+++ b/drivers/tty/serial/stm32-usart.c
@@ -809,6 +809,10 @@ static int stm32_init_port(struct stm32_port *stm32port,
port->ops   = _uart_ops;
port->dev   = >dev;
port->irq   = platform_get_irq(pdev, 0);
+   port->rs485_config = stm32_config_rs485;
+
+   stm32_init_rs485(port, pdev);
+
stm32port->wakeirq = platform_get_irq(pdev, 1);
stm32port->fifoen = stm32port->info->cfg.has_fifo;
 
-- 
1.9.1