Re: [PATCH] slub: assign refcount for kmalloc_caches
On Thu, Jan 24, 2013 at 10:32:32PM -0500, CAI Qian wrote: > > > - Original Message - > > From: "Greg Kroah-Hartman" > > To: "Joonsoo Kim" > > Cc: "Paul Hargrove" , "Pekka Enberg" > > , linux-kernel@vger.kernel.org, > > linux...@kvack.org, "Christoph Lameter" > > Sent: Tuesday, January 15, 2013 3:23:36 AM > > Subject: Re: [PATCH] slub: assign refcount for kmalloc_caches > > > > On Fri, Jan 11, 2013 at 04:52:54PM +0900, Joonsoo Kim wrote: > > > On Thu, Jan 10, 2013 at 08:47:39PM -0800, Paul Hargrove wrote: > > > > I just had a look at patch-3.7.2-rc1, and this change doesn't > > > > appear to > > > > have made it in yet. > > > > Am I missing something? > > > > > > > > -Paul > > > > > > I try to check it. > > > Ccing to Greg. > > > > > > Hello, Pekka and Greg. > > > > > > v3.8-rcX has already fixed by another stuff, but it is not simple > > > change. > > > So I made a new patch and sent it. > > > > > > How this kind of patch (only for stable v3.7) go into stable tree? > > > through Pekka's slab tree? or send it to Greg, directly? > > > > > > I don't know how to submit this kind of patch to stable tree > > > exactly. > > > Could anyone help me? > > > > Please redo it, and send it to sta...@vger.kernel.org, and say > > exactly > > why it isn't in Linus's tree, and that it should only be applied to > > 3.7-stable. > I also met this during the testing, so I'll re-send it then. Hello, CAI Qian. I totally forget this. Thanks for this work. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] slub: assign refcount for kmalloc_caches
On Thu, Jan 24, 2013 at 10:32:32PM -0500, CAI Qian wrote: - Original Message - From: Greg Kroah-Hartman gre...@linuxfoundation.org To: Joonsoo Kim iamjoonsoo@lge.com Cc: Paul Hargrove phhargr...@lbl.gov, Pekka Enberg penb...@kernel.org, linux-kernel@vger.kernel.org, linux...@kvack.org, Christoph Lameter c...@linux.com Sent: Tuesday, January 15, 2013 3:23:36 AM Subject: Re: [PATCH] slub: assign refcount for kmalloc_caches On Fri, Jan 11, 2013 at 04:52:54PM +0900, Joonsoo Kim wrote: On Thu, Jan 10, 2013 at 08:47:39PM -0800, Paul Hargrove wrote: I just had a look at patch-3.7.2-rc1, and this change doesn't appear to have made it in yet. Am I missing something? -Paul I try to check it. Ccing to Greg. Hello, Pekka and Greg. v3.8-rcX has already fixed by another stuff, but it is not simple change. So I made a new patch and sent it. How this kind of patch (only for stable v3.7) go into stable tree? through Pekka's slab tree? or send it to Greg, directly? I don't know how to submit this kind of patch to stable tree exactly. Could anyone help me? Please redo it, and send it to sta...@vger.kernel.org, and say exactly why it isn't in Linus's tree, and that it should only be applied to 3.7-stable. I also met this during the testing, so I'll re-send it then. Hello, CAI Qian. I totally forget this. Thanks for this work. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] slub: assign refcount for kmalloc_caches
- Original Message - > From: "Greg Kroah-Hartman" > To: "Joonsoo Kim" > Cc: "Paul Hargrove" , "Pekka Enberg" > , linux-kernel@vger.kernel.org, > linux...@kvack.org, "Christoph Lameter" > Sent: Tuesday, January 15, 2013 3:23:36 AM > Subject: Re: [PATCH] slub: assign refcount for kmalloc_caches > > On Fri, Jan 11, 2013 at 04:52:54PM +0900, Joonsoo Kim wrote: > > On Thu, Jan 10, 2013 at 08:47:39PM -0800, Paul Hargrove wrote: > > > I just had a look at patch-3.7.2-rc1, and this change doesn't > > > appear to > > > have made it in yet. > > > Am I missing something? > > > > > > -Paul > > > > I try to check it. > > Ccing to Greg. > > > > Hello, Pekka and Greg. > > > > v3.8-rcX has already fixed by another stuff, but it is not simple > > change. > > So I made a new patch and sent it. > > > > How this kind of patch (only for stable v3.7) go into stable tree? > > through Pekka's slab tree? or send it to Greg, directly? > > > > I don't know how to submit this kind of patch to stable tree > > exactly. > > Could anyone help me? > > Please redo it, and send it to sta...@vger.kernel.org, and say > exactly > why it isn't in Linus's tree, and that it should only be applied to > 3.7-stable. I also met this during the testing, so I'll re-send it then. > > thanks, > > greg k-h > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majord...@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: mailto:"d...@kvack.org;> em...@kvack.org > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] slub: assign refcount for kmalloc_caches
- Original Message - From: Greg Kroah-Hartman gre...@linuxfoundation.org To: Joonsoo Kim iamjoonsoo@lge.com Cc: Paul Hargrove phhargr...@lbl.gov, Pekka Enberg penb...@kernel.org, linux-kernel@vger.kernel.org, linux...@kvack.org, Christoph Lameter c...@linux.com Sent: Tuesday, January 15, 2013 3:23:36 AM Subject: Re: [PATCH] slub: assign refcount for kmalloc_caches On Fri, Jan 11, 2013 at 04:52:54PM +0900, Joonsoo Kim wrote: On Thu, Jan 10, 2013 at 08:47:39PM -0800, Paul Hargrove wrote: I just had a look at patch-3.7.2-rc1, and this change doesn't appear to have made it in yet. Am I missing something? -Paul I try to check it. Ccing to Greg. Hello, Pekka and Greg. v3.8-rcX has already fixed by another stuff, but it is not simple change. So I made a new patch and sent it. How this kind of patch (only for stable v3.7) go into stable tree? through Pekka's slab tree? or send it to Greg, directly? I don't know how to submit this kind of patch to stable tree exactly. Could anyone help me? Please redo it, and send it to sta...@vger.kernel.org, and say exactly why it isn't in Linus's tree, and that it should only be applied to 3.7-stable. I also met this during the testing, so I'll re-send it then. thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majord...@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: a href=mailto:d...@kvack.org; em...@kvack.org /a -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] slub: assign refcount for kmalloc_caches
On Fri, Jan 11, 2013 at 04:52:54PM +0900, Joonsoo Kim wrote: > On Thu, Jan 10, 2013 at 08:47:39PM -0800, Paul Hargrove wrote: > > I just had a look at patch-3.7.2-rc1, and this change doesn't appear to > > have made it in yet. > > Am I missing something? > > > > -Paul > > I try to check it. > Ccing to Greg. > > Hello, Pekka and Greg. > > v3.8-rcX has already fixed by another stuff, but it is not simple change. > So I made a new patch and sent it. > > How this kind of patch (only for stable v3.7) go into stable tree? > through Pekka's slab tree? or send it to Greg, directly? > > I don't know how to submit this kind of patch to stable tree exactly. > Could anyone help me? Please redo it, and send it to sta...@vger.kernel.org, and say exactly why it isn't in Linus's tree, and that it should only be applied to 3.7-stable. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] slub: assign refcount for kmalloc_caches
On Fri, Jan 11, 2013 at 04:52:54PM +0900, Joonsoo Kim wrote: On Thu, Jan 10, 2013 at 08:47:39PM -0800, Paul Hargrove wrote: I just had a look at patch-3.7.2-rc1, and this change doesn't appear to have made it in yet. Am I missing something? -Paul I try to check it. Ccing to Greg. Hello, Pekka and Greg. v3.8-rcX has already fixed by another stuff, but it is not simple change. So I made a new patch and sent it. How this kind of patch (only for stable v3.7) go into stable tree? through Pekka's slab tree? or send it to Greg, directly? I don't know how to submit this kind of patch to stable tree exactly. Could anyone help me? Please redo it, and send it to sta...@vger.kernel.org, and say exactly why it isn't in Linus's tree, and that it should only be applied to 3.7-stable. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] slub: assign refcount for kmalloc_caches
On Thu, Jan 10, 2013 at 08:47:39PM -0800, Paul Hargrove wrote:
> I just had a look at patch-3.7.2-rc1, and this change doesn't appear to
> have made it in yet.
> Am I missing something?
>
> -Paul
I try to check it.
Ccing to Greg.
Hello, Pekka and Greg.
v3.8-rcX has already fixed by another stuff, but it is not simple change.
So I made a new patch and sent it.
How this kind of patch (only for stable v3.7) go into stable tree?
through Pekka's slab tree? or send it to Greg, directly?
I don't know how to submit this kind of patch to stable tree exactly.
Could anyone help me?
Thanks.
> On Tue, Dec 25, 2012 at 7:30 AM, JoonSoo Kim wrote:
>
> > 2012/12/26 Joonsoo Kim :
> > > commit cce89f4f6911286500cf7be0363f46c9b0a12ce0('Move kmem_cache
> > > refcounting to common code') moves some refcount manipulation code to
> > > common code. Unfortunately, it also removed refcount assignment for
> > > kmalloc_caches. So, kmalloc_caches's refcount is initially 0.
> > > This makes errornous situation.
> > >
> > > Paul Hargrove report that when he create a 8-byte kmem_cache and
> > > destory it, he encounter below message.
> > > 'Objects remaining in kmalloc-8 on kmem_cache_close()'
> > >
> > > 8-byte kmem_cache merge with 8-byte kmalloc cache and refcount is
> > > increased by one. So, resulting refcount is 1. When destory it, it hit
> > > refcount = 0, then kmem_cache_close() is executed and error message is
> > > printed.
> > >
> > > This patch assign initial refcount 1 to kmalloc_caches, so fix this
> > > errornous situtation.
> > >
> > > Cc: # v3.7
> > > Cc: Christoph Lameter
> > > Reported-by: Paul Hargrove
> > > Signed-off-by: Joonsoo Kim
> > >
> > > diff --git a/mm/slub.c b/mm/slub.c
> > > index a0d6984..321afab 100644
> > > --- a/mm/slub.c
> > > +++ b/mm/slub.c
> > > @@ -3279,6 +3279,7 @@ static struct kmem_cache *__init
> > create_kmalloc_cache(const char *name,
> > > if (kmem_cache_open(s, flags))
> > > goto panic;
> > >
> > > + s->refcount = 1;
> > > list_add(>list, _caches);
> > > return s;
> > >
> > > --
> > > 1.7.9.5
> > >
> >
> > I missed some explanation.
> > In v3.8-rc1, this problem is already solved.
> > See create_kmalloc_cache() in mm/slab_common.c.
> > So this patch is just for v3.7 stable.
> >
>
>
>
> --
> Paul H. Hargrove phhargr...@lbl.gov
> Future Technologies Group
> Computer and Data Sciences Department Tel: +1-510-495-2352
> Lawrence Berkeley National Laboratory Fax: +1-510-486-6900
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] slub: assign refcount for kmalloc_caches
On Thu, Jan 10, 2013 at 08:47:39PM -0800, Paul Hargrove wrote:
I just had a look at patch-3.7.2-rc1, and this change doesn't appear to
have made it in yet.
Am I missing something?
-Paul
I try to check it.
Ccing to Greg.
Hello, Pekka and Greg.
v3.8-rcX has already fixed by another stuff, but it is not simple change.
So I made a new patch and sent it.
How this kind of patch (only for stable v3.7) go into stable tree?
through Pekka's slab tree? or send it to Greg, directly?
I don't know how to submit this kind of patch to stable tree exactly.
Could anyone help me?
Thanks.
On Tue, Dec 25, 2012 at 7:30 AM, JoonSoo Kim js1...@gmail.com wrote:
2012/12/26 Joonsoo Kim js1...@gmail.com:
commit cce89f4f6911286500cf7be0363f46c9b0a12ce0('Move kmem_cache
refcounting to common code') moves some refcount manipulation code to
common code. Unfortunately, it also removed refcount assignment for
kmalloc_caches. So, kmalloc_caches's refcount is initially 0.
This makes errornous situation.
Paul Hargrove report that when he create a 8-byte kmem_cache and
destory it, he encounter below message.
'Objects remaining in kmalloc-8 on kmem_cache_close()'
8-byte kmem_cache merge with 8-byte kmalloc cache and refcount is
increased by one. So, resulting refcount is 1. When destory it, it hit
refcount = 0, then kmem_cache_close() is executed and error message is
printed.
This patch assign initial refcount 1 to kmalloc_caches, so fix this
errornous situtation.
Cc: sta...@vger.kernel.org # v3.7
Cc: Christoph Lameter c...@linux.com
Reported-by: Paul Hargrove phhargr...@lbl.gov
Signed-off-by: Joonsoo Kim js1...@gmail.com
diff --git a/mm/slub.c b/mm/slub.c
index a0d6984..321afab 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3279,6 +3279,7 @@ static struct kmem_cache *__init
create_kmalloc_cache(const char *name,
if (kmem_cache_open(s, flags))
goto panic;
+ s-refcount = 1;
list_add(s-list, slab_caches);
return s;
--
1.7.9.5
I missed some explanation.
In v3.8-rc1, this problem is already solved.
See create_kmalloc_cache() in mm/slab_common.c.
So this patch is just for v3.7 stable.
--
Paul H. Hargrove phhargr...@lbl.gov
Future Technologies Group
Computer and Data Sciences Department Tel: +1-510-495-2352
Lawrence Berkeley National Laboratory Fax: +1-510-486-6900
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] slub: assign refcount for kmalloc_caches
On Wed, 26 Dec 2012, Joonsoo Kim wrote: > This patch assign initial refcount 1 to kmalloc_caches, so fix this > errornous situtation. Ok Only for 3.7: Acked-by: Christoph Lameter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] slub: assign refcount for kmalloc_caches
On Wed, 26 Dec 2012, Joonsoo Kim wrote: This patch assign initial refcount 1 to kmalloc_caches, so fix this errornous situtation. Ok Only for 3.7: Acked-by: Christoph Lameter c...@linux.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] slub: assign refcount for kmalloc_caches
2012/12/26 Joonsoo Kim :
> commit cce89f4f6911286500cf7be0363f46c9b0a12ce0('Move kmem_cache
> refcounting to common code') moves some refcount manipulation code to
> common code. Unfortunately, it also removed refcount assignment for
> kmalloc_caches. So, kmalloc_caches's refcount is initially 0.
> This makes errornous situation.
>
> Paul Hargrove report that when he create a 8-byte kmem_cache and
> destory it, he encounter below message.
> 'Objects remaining in kmalloc-8 on kmem_cache_close()'
>
> 8-byte kmem_cache merge with 8-byte kmalloc cache and refcount is
> increased by one. So, resulting refcount is 1. When destory it, it hit
> refcount = 0, then kmem_cache_close() is executed and error message is
> printed.
>
> This patch assign initial refcount 1 to kmalloc_caches, so fix this
> errornous situtation.
>
> Cc: # v3.7
> Cc: Christoph Lameter
> Reported-by: Paul Hargrove
> Signed-off-by: Joonsoo Kim
>
> diff --git a/mm/slub.c b/mm/slub.c
> index a0d6984..321afab 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -3279,6 +3279,7 @@ static struct kmem_cache *__init
> create_kmalloc_cache(const char *name,
> if (kmem_cache_open(s, flags))
> goto panic;
>
> + s->refcount = 1;
> list_add(>list, _caches);
> return s;
>
> --
> 1.7.9.5
>
I missed some explanation.
In v3.8-rc1, this problem is already solved.
See create_kmalloc_cache() in mm/slab_common.c.
So this patch is just for v3.7 stable.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] slub: assign refcount for kmalloc_caches
commit cce89f4f6911286500cf7be0363f46c9b0a12ce0('Move kmem_cache
refcounting to common code') moves some refcount manipulation code to
common code. Unfortunately, it also removed refcount assignment for
kmalloc_caches. So, kmalloc_caches's refcount is initially 0.
This makes errornous situation.
Paul Hargrove report that when he create a 8-byte kmem_cache and
destory it, he encounter below message.
'Objects remaining in kmalloc-8 on kmem_cache_close()'
8-byte kmem_cache merge with 8-byte kmalloc cache and refcount is
increased by one. So, resulting refcount is 1. When destory it, it hit
refcount = 0, then kmem_cache_close() is executed and error message is
printed.
This patch assign initial refcount 1 to kmalloc_caches, so fix this
errornous situtation.
Cc: # v3.7
Cc: Christoph Lameter
Reported-by: Paul Hargrove
Signed-off-by: Joonsoo Kim
diff --git a/mm/slub.c b/mm/slub.c
index a0d6984..321afab 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3279,6 +3279,7 @@ static struct kmem_cache *__init
create_kmalloc_cache(const char *name,
if (kmem_cache_open(s, flags))
goto panic;
+ s->refcount = 1;
list_add(>list, _caches);
return s;
--
1.7.9.5
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] slub: assign refcount for kmalloc_caches
commit cce89f4f6911286500cf7be0363f46c9b0a12ce0('Move kmem_cache
refcounting to common code') moves some refcount manipulation code to
common code. Unfortunately, it also removed refcount assignment for
kmalloc_caches. So, kmalloc_caches's refcount is initially 0.
This makes errornous situation.
Paul Hargrove report that when he create a 8-byte kmem_cache and
destory it, he encounter below message.
'Objects remaining in kmalloc-8 on kmem_cache_close()'
8-byte kmem_cache merge with 8-byte kmalloc cache and refcount is
increased by one. So, resulting refcount is 1. When destory it, it hit
refcount = 0, then kmem_cache_close() is executed and error message is
printed.
This patch assign initial refcount 1 to kmalloc_caches, so fix this
errornous situtation.
Cc: sta...@vger.kernel.org # v3.7
Cc: Christoph Lameter c...@linux.com
Reported-by: Paul Hargrove phhargr...@lbl.gov
Signed-off-by: Joonsoo Kim js1...@gmail.com
diff --git a/mm/slub.c b/mm/slub.c
index a0d6984..321afab 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3279,6 +3279,7 @@ static struct kmem_cache *__init
create_kmalloc_cache(const char *name,
if (kmem_cache_open(s, flags))
goto panic;
+ s-refcount = 1;
list_add(s-list, slab_caches);
return s;
--
1.7.9.5
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] slub: assign refcount for kmalloc_caches
2012/12/26 Joonsoo Kim js1...@gmail.com:
commit cce89f4f6911286500cf7be0363f46c9b0a12ce0('Move kmem_cache
refcounting to common code') moves some refcount manipulation code to
common code. Unfortunately, it also removed refcount assignment for
kmalloc_caches. So, kmalloc_caches's refcount is initially 0.
This makes errornous situation.
Paul Hargrove report that when he create a 8-byte kmem_cache and
destory it, he encounter below message.
'Objects remaining in kmalloc-8 on kmem_cache_close()'
8-byte kmem_cache merge with 8-byte kmalloc cache and refcount is
increased by one. So, resulting refcount is 1. When destory it, it hit
refcount = 0, then kmem_cache_close() is executed and error message is
printed.
This patch assign initial refcount 1 to kmalloc_caches, so fix this
errornous situtation.
Cc: sta...@vger.kernel.org # v3.7
Cc: Christoph Lameter c...@linux.com
Reported-by: Paul Hargrove phhargr...@lbl.gov
Signed-off-by: Joonsoo Kim js1...@gmail.com
diff --git a/mm/slub.c b/mm/slub.c
index a0d6984..321afab 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -3279,6 +3279,7 @@ static struct kmem_cache *__init
create_kmalloc_cache(const char *name,
if (kmem_cache_open(s, flags))
goto panic;
+ s-refcount = 1;
list_add(s-list, slab_caches);
return s;
--
1.7.9.5
I missed some explanation.
In v3.8-rc1, this problem is already solved.
See create_kmalloc_cache() in mm/slab_common.c.
So this patch is just for v3.7 stable.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
