Re: [PATCH] sound/core.h: include sound/driver.h
On Mon, Dec 17, 2007 at 10:30:01AM +0100, Takashi Iwai wrote: > At Sun, 16 Dec 2007 02:58:31 +0100, > Marcin Slusarz wrote: > > > > On Fri, Dec 14, 2007 at 12:02:46PM +0100, Takashi Iwai wrote: > > > At Sat, 8 Dec 2007 21:50:45 +0100, > > > Marcin Ślusarz wrote: > > > > > > > > sound/core.h: include sound/driver.h > > > > > > > > include sound/driver.h in sound/core.h because core.h > > > > uses SNDRV_CARDS (which is defined in sound/driver.h) > > > > > > > > Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> > > > > > > Right now I have another (bigger) change for this include path, so > > > this patch won't be needed any more. > > > > > > I applied the patches to sound/* except for this one and > > > sound/memory.c. Thanks! > > > > > Is there anything wrong with patch for rawmidi [1]? > > Ah, sorry, forgot to mention it. > > I'm still considering whether it's the best way. The changes look > exaggerated just for fixing sparse warnings. It think it will let future code inspections a bit easier. But if you have a better idea how to fix it, let me know. Marcin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] sound/core.h: include sound/driver.h
On Mon, Dec 17, 2007 at 10:30:01AM +0100, Takashi Iwai wrote: At Sun, 16 Dec 2007 02:58:31 +0100, Marcin Slusarz wrote: On Fri, Dec 14, 2007 at 12:02:46PM +0100, Takashi Iwai wrote: At Sat, 8 Dec 2007 21:50:45 +0100, Marcin Ślusarz wrote: sound/core.h: include sound/driver.h include sound/driver.h in sound/core.h because core.h uses SNDRV_CARDS (which is defined in sound/driver.h) Signed-off-by: Marcin Ślusarz [EMAIL PROTECTED] Right now I have another (bigger) change for this include path, so this patch won't be needed any more. I applied the patches to sound/* except for this one and sound/memory.c. Thanks! Is there anything wrong with patch for rawmidi [1]? Ah, sorry, forgot to mention it. I'm still considering whether it's the best way. The changes look exaggerated just for fixing sparse warnings. It think it will let future code inspections a bit easier. But if you have a better idea how to fix it, let me know. Marcin -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] sound/core.h: include sound/driver.h
At Sun, 16 Dec 2007 02:58:31 +0100, Marcin Slusarz wrote: > > On Fri, Dec 14, 2007 at 12:02:46PM +0100, Takashi Iwai wrote: > > At Sat, 8 Dec 2007 21:50:45 +0100, > > Marcin Ślusarz wrote: > > > > > > sound/core.h: include sound/driver.h > > > > > > include sound/driver.h in sound/core.h because core.h > > > uses SNDRV_CARDS (which is defined in sound/driver.h) > > > > > > Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> > > > > Right now I have another (bigger) change for this include path, so > > this patch won't be needed any more. > > > > I applied the patches to sound/* except for this one and > > sound/memory.c. Thanks! > > > Is there anything wrong with patch for rawmidi [1]? Ah, sorry, forgot to mention it. I'm still considering whether it's the best way. The changes look exaggerated just for fixing sparse warnings. Takashi > > Marcin > > [1] http://lkml.org/lkml/2007/12/8/164 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] sound/core.h: include sound/driver.h
At Sun, 16 Dec 2007 02:58:31 +0100, Marcin Slusarz wrote: On Fri, Dec 14, 2007 at 12:02:46PM +0100, Takashi Iwai wrote: At Sat, 8 Dec 2007 21:50:45 +0100, Marcin Ślusarz wrote: sound/core.h: include sound/driver.h include sound/driver.h in sound/core.h because core.h uses SNDRV_CARDS (which is defined in sound/driver.h) Signed-off-by: Marcin Ślusarz [EMAIL PROTECTED] Right now I have another (bigger) change for this include path, so this patch won't be needed any more. I applied the patches to sound/* except for this one and sound/memory.c. Thanks! Is there anything wrong with patch for rawmidi [1]? Ah, sorry, forgot to mention it. I'm still considering whether it's the best way. The changes look exaggerated just for fixing sparse warnings. Takashi Marcin [1] http://lkml.org/lkml/2007/12/8/164 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] sound/core.h: include sound/driver.h
On Fri, Dec 14, 2007 at 12:02:46PM +0100, Takashi Iwai wrote: > At Sat, 8 Dec 2007 21:50:45 +0100, > Marcin Ślusarz wrote: > > > > sound/core.h: include sound/driver.h > > > > include sound/driver.h in sound/core.h because core.h > > uses SNDRV_CARDS (which is defined in sound/driver.h) > > > > Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> > > Right now I have another (bigger) change for this include path, so > this patch won't be needed any more. > > I applied the patches to sound/* except for this one and > sound/memory.c. Thanks! > Is there anything wrong with patch for rawmidi [1]? Marcin [1] http://lkml.org/lkml/2007/12/8/164 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] sound/core.h: include sound/driver.h
On Fri, Dec 14, 2007 at 12:02:46PM +0100, Takashi Iwai wrote: At Sat, 8 Dec 2007 21:50:45 +0100, Marcin Ślusarz wrote: sound/core.h: include sound/driver.h include sound/driver.h in sound/core.h because core.h uses SNDRV_CARDS (which is defined in sound/driver.h) Signed-off-by: Marcin Ślusarz [EMAIL PROTECTED] Right now I have another (bigger) change for this include path, so this patch won't be needed any more. I applied the patches to sound/* except for this one and sound/memory.c. Thanks! Is there anything wrong with patch for rawmidi [1]? Marcin [1] http://lkml.org/lkml/2007/12/8/164 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] sound/core.h: include sound/driver.h
At Sat, 8 Dec 2007 21:50:45 +0100, Marcin Ślusarz wrote: > > sound/core.h: include sound/driver.h > > include sound/driver.h in sound/core.h because core.h > uses SNDRV_CARDS (which is defined in sound/driver.h) > > Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> Right now I have another (bigger) change for this include path, so this patch won't be needed any more. I applied the patches to sound/* except for this one and sound/memory.c. Thanks! Takashi > --- > include/sound/core.h |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/include/sound/core.h b/include/sound/core.h > index 6954836..3b0903a 100644 > --- a/include/sound/core.h > +++ b/include/sound/core.h > @@ -27,6 +27,7 @@ > #include /* struct rw_semaphore */ > #include /* pm_message_t */ > #include > +#include > > /* forward declarations */ > #ifdef CONFIG_PCI > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] sound/core.h: include sound/driver.h
At Sat, 8 Dec 2007 21:50:45 +0100, Marcin Ślusarz wrote: sound/core.h: include sound/driver.h include sound/driver.h in sound/core.h because core.h uses SNDRV_CARDS (which is defined in sound/driver.h) Signed-off-by: Marcin Ślusarz [EMAIL PROTECTED] Right now I have another (bigger) change for this include path, so this patch won't be needed any more. I applied the patches to sound/* except for this one and sound/memory.c. Thanks! Takashi --- include/sound/core.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/sound/core.h b/include/sound/core.h index 6954836..3b0903a 100644 --- a/include/sound/core.h +++ b/include/sound/core.h @@ -27,6 +27,7 @@ #include linux/rwsem.h /* struct rw_semaphore */ #include linux/pm.h/* pm_message_t */ #include linux/device.h +#include sound/driver.h /* forward declarations */ #ifdef CONFIG_PCI -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] sound/core.h: include sound/driver.h
sound/core.h: include sound/driver.h include sound/driver.h in sound/core.h because core.h uses SNDRV_CARDS (which is defined in sound/driver.h) Signed-off-by: Marcin Ślusarz <[EMAIL PROTECTED]> --- include/sound/core.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/sound/core.h b/include/sound/core.h index 6954836..3b0903a 100644 --- a/include/sound/core.h +++ b/include/sound/core.h @@ -27,6 +27,7 @@ #include/* struct rw_semaphore */ #include /* pm_message_t */ #include +#include /* forward declarations */ #ifdef CONFIG_PCI -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] sound/core.h: include sound/driver.h
sound/core.h: include sound/driver.h include sound/driver.h in sound/core.h because core.h uses SNDRV_CARDS (which is defined in sound/driver.h) Signed-off-by: Marcin Ślusarz [EMAIL PROTECTED] --- include/sound/core.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/sound/core.h b/include/sound/core.h index 6954836..3b0903a 100644 --- a/include/sound/core.h +++ b/include/sound/core.h @@ -27,6 +27,7 @@ #include linux/rwsem.h /* struct rw_semaphore */ #include linux/pm.h /* pm_message_t */ #include linux/device.h +#include sound/driver.h /* forward declarations */ #ifdef CONFIG_PCI -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
