Re: [PATCH] sound: soc-acpi: fix implicit header use of module.h/export.h

[Mark Brown]

On Sat, Apr 13, 2019 at 11:15:18AM -0400, Paul Gortmaker wrote:
> This file is implicitly relying on an instance of including
> module.h from .

Please use subject lines matching the style for the subsystem.  This
makes it easier for people to identify relevant patches.


signature.asc
Description: PGP signature

[PATCH] sound: soc-acpi: fix implicit header use of module.h/export.h

[Paul Gortmaker]

This file is implicitly relying on an instance of including
module.h from .

Ideally, header files under include/linux shouldn't be adding
includes of other headers, in anticipation of their consumers,
but just the headers needed for the header itself to pass
parsing with CPP.

The module.h is particularly bad in this sense, as it itself does
include a whole bunch of other headers, due to the complexity of
module support.

Here, we make the include explicit, in order to allow the future
removal of module.h from linux/acpi.h without causing build breakage.

Cc: Liam Girdwood 
Cc: Mark Brown 
Cc: Jaroslav Kysela 
Cc: Takashi Iwai 
Signed-off-by: Paul Gortmaker 

diff --git a/sound/soc/soc-acpi.c b/sound/soc/soc-acpi.c
index 4fb29f0e561e..444ce0602f76 100644
--- a/sound/soc/soc-acpi.c
+++ b/sound/soc/soc-acpi.c
@@ -4,6 +4,8 @@
 //
 // Copyright (c) 2013-15, Intel Corporation.
 
+#include 
+#include 
 #include 
 
 struct snd_soc_acpi_mach *
-- 
2.11.0