Re: [PATCH] spi/spi-fsl-espi.c: Add spi cs polarity support
On Wed, Jan 06, 2016 at 02:00:40PM +0100, Andreas Werner wrote: > Hi, > any comments for this patches? > > Regards > Andy Please don't send content free pings and please allow a reasonable time for review. People get busy, go on holiday, attend conferences and so on so unless there is some reason for urgency (like critical bug fixes) please allow at least a couple of weeks for review. Sending content free pings just adds to the mail volume (if they are seen at all) and if something has gone wrong you'll have to resend the patches anyway. signature.asc Description: PGP signature
Re: [PATCH] spi/spi-fsl-espi.c: Add spi cs polarity support
Hi, any comments for this patches? Regards Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH] spi/spi-fsl-espi.c: Add spi cs polarity support
Add CS polarity flag to be able to set the CS polarity via the DT property spi-cs-high. Signed-off-by: Andreas Werner --- drivers/spi/spi-fsl-espi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-fsl-espi.c b/drivers/spi/spi-fsl-espi.c index c27124a..2dc70953 100644 --- a/drivers/spi/spi-fsl-espi.c +++ b/drivers/spi/spi-fsl-espi.c @@ -495,7 +495,7 @@ static int fsl_espi_setup(struct spi_device *spi) ®_base->csmode[spi->chip_select]); /* mask out bits we are going to set */ cs->hw_mode &= ~(CSMODE_CP_BEGIN_EDGECLK | CSMODE_CI_INACTIVEHIGH -| CSMODE_REV); +| CSMODE_REV | CSMODE_POL_1); if (spi->mode & SPI_CPHA) cs->hw_mode |= CSMODE_CP_BEGIN_EDGECLK; @@ -503,6 +503,8 @@ static int fsl_espi_setup(struct spi_device *spi) cs->hw_mode |= CSMODE_CI_INACTIVEHIGH; if (!(spi->mode & SPI_LSB_FIRST)) cs->hw_mode |= CSMODE_REV; + if (!(spi->mode & SPI_CS_HIGH)) + cs->hw_mode |= CSMODE_POL_1; /* Handle the loop mode */ loop_mode = mpc8xxx_spi_read_reg(®_base->mode); -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/