Re: [PATCH] spi-nor: use true/false for bool

2017-02-12 Thread Nicholas Mc Guire 
On Sun, Feb 12, 2017 at 11:01:44PM +0100, Boris Brezillon wrote:
> +Mika
> 
> On Sun, 12 Feb 2017 22:50:44 +0100
> Boris Brezillon  wrote:
> 
> > On Sun, 12 Feb 2017 17:43:31 +0100
> > Nicholas Mc Guire  wrote:
> > 
> > > writeable in struct intel_spi is a boolean and assignment should be to 
> > > true/false not 1/0 as recommended by boolinit.cocci.
> > > 
> > > Signed-off-by: Nicholas Mc Guire   
> > 
> > Acked-by: Boris Brezillon 
> 
> As asked in my other review, please use the 'mtd: spi-nor: intel'
> prefix (or anything that would clarify the scope of this patch, like
> 'mtd: spi-nor/intel: ').
>

yup - will fix it up - just not yet clear how
to find the proper prefix next time - the method I
had been using seems insufficient.

thx!
hofrat
 
> 
> > 
> > > ---
> > > 
> > > make coccicheck complained with:
> > >  ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool 
> > > to 0/1
> > > 
> > > Patch was compile tested with: multi_v7_defconfig (implies 
> > > CONFIG_MTD_SPI_NOR=y)
> > > 
> > > Patch is against 4.10-rc6 (localversion-next is next-20170210)
> > > 
> > >  drivers/mtd/spi-nor/intel-spi.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/mtd/spi-nor/intel-spi.c 
> > > b/drivers/mtd/spi-nor/intel-spi.c
> > > index a10f602..e43ce63 100644
> > > --- a/drivers/mtd/spi-nor/intel-spi.c
> > > +++ b/drivers/mtd/spi-nor/intel-spi.c
> > > @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi 
> > > *ispi,
> > >* whole partition read-only to be on the safe side.
> > >*/
> > >   if (intel_spi_is_protected(ispi, base, limit))
> > > - ispi->writeable = 0;
> > > + ispi->writeable = false;
> > >  
> > >   end = (limit << 12) + 4096;
> > >   if (end > part->size)  
> > 
>

Re: [PATCH] spi-nor: use true/false for bool

2017-02-12 Thread Nicholas Mc Guire 
On Sun, Feb 12, 2017 at 11:01:44PM +0100, Boris Brezillon wrote:
> +Mika
> 
> On Sun, 12 Feb 2017 22:50:44 +0100
> Boris Brezillon  wrote:
> 
> > On Sun, 12 Feb 2017 17:43:31 +0100
> > Nicholas Mc Guire  wrote:
> > 
> > > writeable in struct intel_spi is a boolean and assignment should be to 
> > > true/false not 1/0 as recommended by boolinit.cocci.
> > > 
> > > Signed-off-by: Nicholas Mc Guire   
> > 
> > Acked-by: Boris Brezillon 
> 
> As asked in my other review, please use the 'mtd: spi-nor: intel'
> prefix (or anything that would clarify the scope of this patch, like
> 'mtd: spi-nor/intel: ').
>

yup - will fix it up - just not yet clear how
to find the proper prefix next time - the method I
had been using seems insufficient.

thx!
hofrat
 
> 
> > 
> > > ---
> > > 
> > > make coccicheck complained with:
> > >  ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool 
> > > to 0/1
> > > 
> > > Patch was compile tested with: multi_v7_defconfig (implies 
> > > CONFIG_MTD_SPI_NOR=y)
> > > 
> > > Patch is against 4.10-rc6 (localversion-next is next-20170210)
> > > 
> > >  drivers/mtd/spi-nor/intel-spi.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/mtd/spi-nor/intel-spi.c 
> > > b/drivers/mtd/spi-nor/intel-spi.c
> > > index a10f602..e43ce63 100644
> > > --- a/drivers/mtd/spi-nor/intel-spi.c
> > > +++ b/drivers/mtd/spi-nor/intel-spi.c
> > > @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi 
> > > *ispi,
> > >* whole partition read-only to be on the safe side.
> > >*/
> > >   if (intel_spi_is_protected(ispi, base, limit))
> > > - ispi->writeable = 0;
> > > + ispi->writeable = false;
> > >  
> > >   end = (limit << 12) + 4096;
> > >   if (end > part->size)  
> > 
>

Re: [PATCH] spi-nor: use true/false for bool

2017-02-12 Thread Boris Brezillon 
+Mika

On Sun, 12 Feb 2017 22:50:44 +0100
Boris Brezillon  wrote:

> On Sun, 12 Feb 2017 17:43:31 +0100
> Nicholas Mc Guire  wrote:
> 
> > writeable in struct intel_spi is a boolean and assignment should be to 
> > true/false not 1/0 as recommended by boolinit.cocci.
> > 
> > Signed-off-by: Nicholas Mc Guire   
> 
> Acked-by: Boris Brezillon 

As asked in my other review, please use the 'mtd: spi-nor: intel'
prefix (or anything that would clarify the scope of this patch, like
'mtd: spi-nor/intel: ').

Thanks,

Boris

> 
> > ---
> > 
> > make coccicheck complained with:
> >  ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 
> > 0/1
> > 
> > Patch was compile tested with: multi_v7_defconfig (implies 
> > CONFIG_MTD_SPI_NOR=y)
> > 
> > Patch is against 4.10-rc6 (localversion-next is next-20170210)
> > 
> >  drivers/mtd/spi-nor/intel-spi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mtd/spi-nor/intel-spi.c 
> > b/drivers/mtd/spi-nor/intel-spi.c
> > index a10f602..e43ce63 100644
> > --- a/drivers/mtd/spi-nor/intel-spi.c
> > +++ b/drivers/mtd/spi-nor/intel-spi.c
> > @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi 
> > *ispi,
> >  * whole partition read-only to be on the safe side.
> >  */
> > if (intel_spi_is_protected(ispi, base, limit))
> > -   ispi->writeable = 0;
> > +   ispi->writeable = false;
> >  
> > end = (limit << 12) + 4096;
> > if (end > part->size)  
>

Re: [PATCH] spi-nor: use true/false for bool

2017-02-12 Thread Boris Brezillon 
+Mika

On Sun, 12 Feb 2017 22:50:44 +0100
Boris Brezillon  wrote:

> On Sun, 12 Feb 2017 17:43:31 +0100
> Nicholas Mc Guire  wrote:
> 
> > writeable in struct intel_spi is a boolean and assignment should be to 
> > true/false not 1/0 as recommended by boolinit.cocci.
> > 
> > Signed-off-by: Nicholas Mc Guire   
> 
> Acked-by: Boris Brezillon 

As asked in my other review, please use the 'mtd: spi-nor: intel'
prefix (or anything that would clarify the scope of this patch, like
'mtd: spi-nor/intel: ').

Thanks,

Boris

> 
> > ---
> > 
> > make coccicheck complained with:
> >  ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 
> > 0/1
> > 
> > Patch was compile tested with: multi_v7_defconfig (implies 
> > CONFIG_MTD_SPI_NOR=y)
> > 
> > Patch is against 4.10-rc6 (localversion-next is next-20170210)
> > 
> >  drivers/mtd/spi-nor/intel-spi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mtd/spi-nor/intel-spi.c 
> > b/drivers/mtd/spi-nor/intel-spi.c
> > index a10f602..e43ce63 100644
> > --- a/drivers/mtd/spi-nor/intel-spi.c
> > +++ b/drivers/mtd/spi-nor/intel-spi.c
> > @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi 
> > *ispi,
> >  * whole partition read-only to be on the safe side.
> >  */
> > if (intel_spi_is_protected(ispi, base, limit))
> > -   ispi->writeable = 0;
> > +   ispi->writeable = false;
> >  
> > end = (limit << 12) + 4096;
> > if (end > part->size)  
>

Re: [PATCH] spi-nor: use true/false for bool

2017-02-12 Thread Boris Brezillon 
On Sun, 12 Feb 2017 17:43:31 +0100
Nicholas Mc Guire  wrote:

> writeable in struct intel_spi is a boolean and assignment should be to 
> true/false not 1/0 as recommended by boolinit.cocci.
> 
> Signed-off-by: Nicholas Mc Guire 

Acked-by: Boris Brezillon 

> ---
> 
> make coccicheck complained with:
>  ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 
> 0/1
> 
> Patch was compile tested with: multi_v7_defconfig (implies 
> CONFIG_MTD_SPI_NOR=y)
> 
> Patch is against 4.10-rc6 (localversion-next is next-20170210)
> 
>  drivers/mtd/spi-nor/intel-spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> index a10f602..e43ce63 100644
> --- a/drivers/mtd/spi-nor/intel-spi.c
> +++ b/drivers/mtd/spi-nor/intel-spi.c
> @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi 
> *ispi,
>* whole partition read-only to be on the safe side.
>*/
>   if (intel_spi_is_protected(ispi, base, limit))
> - ispi->writeable = 0;
> + ispi->writeable = false;
>  
>   end = (limit << 12) + 4096;
>   if (end > part->size)

Re: [PATCH] spi-nor: use true/false for bool

2017-02-12 Thread Boris Brezillon 
On Sun, 12 Feb 2017 17:43:31 +0100
Nicholas Mc Guire  wrote:

> writeable in struct intel_spi is a boolean and assignment should be to 
> true/false not 1/0 as recommended by boolinit.cocci.
> 
> Signed-off-by: Nicholas Mc Guire 

Acked-by: Boris Brezillon 

> ---
> 
> make coccicheck complained with:
>  ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 
> 0/1
> 
> Patch was compile tested with: multi_v7_defconfig (implies 
> CONFIG_MTD_SPI_NOR=y)
> 
> Patch is against 4.10-rc6 (localversion-next is next-20170210)
> 
>  drivers/mtd/spi-nor/intel-spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> index a10f602..e43ce63 100644
> --- a/drivers/mtd/spi-nor/intel-spi.c
> +++ b/drivers/mtd/spi-nor/intel-spi.c
> @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi 
> *ispi,
>* whole partition read-only to be on the safe side.
>*/
>   if (intel_spi_is_protected(ispi, base, limit))
> - ispi->writeable = 0;
> + ispi->writeable = false;
>  
>   end = (limit << 12) + 4096;
>   if (end > part->size)

[PATCH] spi-nor: use true/false for bool

2017-02-12 Thread Nicholas Mc Guire 
writeable in struct intel_spi is a boolean and assignment should be to 
true/false not 1/0 as recommended by boolinit.cocci.

Signed-off-by: Nicholas Mc Guire 
---

make coccicheck complained with:
 ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1

Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)

Patch is against 4.10-rc6 (localversion-next is next-20170210)

 drivers/mtd/spi-nor/intel-spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
index a10f602..e43ce63 100644
--- a/drivers/mtd/spi-nor/intel-spi.c
+++ b/drivers/mtd/spi-nor/intel-spi.c
@@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
 * whole partition read-only to be on the safe side.
 */
if (intel_spi_is_protected(ispi, base, limit))
-   ispi->writeable = 0;
+   ispi->writeable = false;
 
end = (limit << 12) + 4096;
if (end > part->size)
-- 
2.1.4

[PATCH] spi-nor: use true/false for bool

2017-02-12 Thread Nicholas Mc Guire 
writeable in struct intel_spi is a boolean and assignment should be to 
true/false not 1/0 as recommended by boolinit.cocci.

Signed-off-by: Nicholas Mc Guire 
---

make coccicheck complained with:
 ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1

Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)

Patch is against 4.10-rc6 (localversion-next is next-20170210)

 drivers/mtd/spi-nor/intel-spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
index a10f602..e43ce63 100644
--- a/drivers/mtd/spi-nor/intel-spi.c
+++ b/drivers/mtd/spi-nor/intel-spi.c
@@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
 * whole partition read-only to be on the safe side.
 */
if (intel_spi_is_protected(ispi, base, limit))
-   ispi->writeable = 0;
+   ispi->writeable = false;
 
end = (limit << 12) + 4096;
if (end > part->size)
-- 
2.1.4