Re: [PATCH] staging: cxt1e1: fix pointer-integer size mismatch warning

2014-02-04 Thread SeongJae Park 
On Tue, Feb 4, 2014 at 5:23 PM, Dan Carpenter  wrote:
> On Tue, Feb 04, 2014 at 04:01:26PM +0900, SeongJae Park wrote:
>> Fix the pointer-integer size mismatch warning below:
>>   drivers/staging/cxt1e1/functions.c: In function ‘VMETRO_TRACE’:
>>   drivers/staging/cxt1e1/functions.c:268:21: warning: cast from pointer
>>   to integer of different size [-Wpointer-to-int-cast]
>>u_int32_t   y = (u_int32_t) x;
>>^
>
> This function isn't called.  Just delete it from here and also from the
> .h file.
>

Nice review. Thank you for reviewing. I will upload new patch soon.

> regards,
> dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] staging: cxt1e1: fix pointer-integer size mismatch warning

2014-02-04 Thread Dan Carpenter 
On Tue, Feb 04, 2014 at 04:01:26PM +0900, SeongJae Park wrote:
> Fix the pointer-integer size mismatch warning below:
>   drivers/staging/cxt1e1/functions.c: In function ‘VMETRO_TRACE’:
>   drivers/staging/cxt1e1/functions.c:268:21: warning: cast from pointer
>   to integer of different size [-Wpointer-to-int-cast]
>u_int32_t   y = (u_int32_t) x;
>^

This function isn't called.  Just delete it from here and also from the
.h file.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] staging: cxt1e1: fix pointer-integer size mismatch warning

2014-02-04 Thread Dan Carpenter 
On Tue, Feb 04, 2014 at 04:01:26PM +0900, SeongJae Park wrote:
 Fix the pointer-integer size mismatch warning below:
   drivers/staging/cxt1e1/functions.c: In function ‘VMETRO_TRACE’:
   drivers/staging/cxt1e1/functions.c:268:21: warning: cast from pointer
   to integer of different size [-Wpointer-to-int-cast]
u_int32_t   y = (u_int32_t) x;
^

This function isn't called.  Just delete it from here and also from the
.h file.

regards,
dan carpenter

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] staging: cxt1e1: fix pointer-integer size mismatch warning

2014-02-04 Thread SeongJae Park 
On Tue, Feb 4, 2014 at 5:23 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
 On Tue, Feb 04, 2014 at 04:01:26PM +0900, SeongJae Park wrote:
 Fix the pointer-integer size mismatch warning below:
   drivers/staging/cxt1e1/functions.c: In function ‘VMETRO_TRACE’:
   drivers/staging/cxt1e1/functions.c:268:21: warning: cast from pointer
   to integer of different size [-Wpointer-to-int-cast]
u_int32_t   y = (u_int32_t) x;
^

 This function isn't called.  Just delete it from here and also from the
 .h file.


Nice review. Thank you for reviewing. I will upload new patch soon.

 regards,
 dan carpenter

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] staging: cxt1e1: fix pointer-integer size mismatch warning

2014-02-03 Thread SeongJae Park 
Fix the pointer-integer size mismatch warning below:
drivers/staging/cxt1e1/functions.c: In function ‘VMETRO_TRACE’:
drivers/staging/cxt1e1/functions.c:268:21: warning: cast from pointer
to integer of different size [-Wpointer-to-int-cast]
 u_int32_t   y = (u_int32_t) x;
 ^

Signed-off-by: SeongJae Park 
---
 drivers/staging/cxt1e1/functions.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/cxt1e1/functions.c 
b/drivers/staging/cxt1e1/functions.c
index 95218e2..8f19a39 100644
--- a/drivers/staging/cxt1e1/functions.c
+++ b/drivers/staging/cxt1e1/functions.c
@@ -265,7 +265,7 @@ extern ci_t *CI;/* dummy pointer to board 
ZERO's data */
 void
 VMETRO_TRACE (void *x)
 {
-u_int32_t   y = (u_int32_t) x;
+u_int32_t   y = (u_int32_t)(uintptr_t) x;
 
 pci_write_32 ((u_int32_t *) >cpldbase->leds, y);
 }
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] staging: cxt1e1: fix pointer-integer size mismatch warning

2014-02-03 Thread SeongJae Park 
Fix the pointer-integer size mismatch warning below:
drivers/staging/cxt1e1/functions.c: In function ‘VMETRO_TRACE’:
drivers/staging/cxt1e1/functions.c:268:21: warning: cast from pointer
to integer of different size [-Wpointer-to-int-cast]
 u_int32_t   y = (u_int32_t) x;
 ^

Signed-off-by: SeongJae Park sj38.p...@gmail.com
---
 drivers/staging/cxt1e1/functions.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/cxt1e1/functions.c 
b/drivers/staging/cxt1e1/functions.c
index 95218e2..8f19a39 100644
--- a/drivers/staging/cxt1e1/functions.c
+++ b/drivers/staging/cxt1e1/functions.c
@@ -265,7 +265,7 @@ extern ci_t *CI;/* dummy pointer to board 
ZERO's data */
 void
 VMETRO_TRACE (void *x)
 {
-u_int32_t   y = (u_int32_t) x;
+u_int32_t   y = (u_int32_t)(uintptr_t) x;
 
 pci_write_32 ((u_int32_t *) CI-cpldbase-leds, y);
 }
-- 
1.8.3.2

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/