Re: [PATCH] staging: dwc2: fix value used in dwc2_set_all_params

2013-07-11 Thread Matthijs Kooijman
On Thu, Jul 11, 2013 at 02:24:10PM +0200, Julien Delacou wrote:
> From: Julien Delacou 
> 
> This fix uses 'value' parameter as it should be instead
> of hardcoded -1.
Woops!

> Signed-off-by: Julien Delacou 
> Acked-by: Paul Zimmerman 
Reviewed-by: Matthijs Kooijman 

> ---
>  drivers/staging/dwc2/hcd.c |2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
> index 2ed54b1..ca38aaa 100644
> --- a/drivers/staging/dwc2/hcd.c
> +++ b/drivers/staging/dwc2/hcd.c
> @@ -2690,7 +2690,7 @@ void dwc2_set_all_params(struct dwc2_core_params 
> *params, int value)
>   int i;
>  
>   for (i = 0; i < size; i++)
> - p[i] = -1;
> + p[i] = value;
>  }
>  EXPORT_SYMBOL_GPL(dwc2_set_all_params);
>  
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: dwc2: fix value used in dwc2_set_all_params

2013-07-11 Thread Julien Delacou
From: Julien Delacou 

This fix uses 'value' parameter as it should be instead
of hardcoded -1.

Signed-off-by: Julien Delacou 
Acked-by: Paul Zimmerman 
---
 drivers/staging/dwc2/hcd.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
index 2ed54b1..ca38aaa 100644
--- a/drivers/staging/dwc2/hcd.c
+++ b/drivers/staging/dwc2/hcd.c
@@ -2690,7 +2690,7 @@ void dwc2_set_all_params(struct dwc2_core_params *params, 
int value)
int i;
 
for (i = 0; i < size; i++)
-   p[i] = -1;
+   p[i] = value;
 }
 EXPORT_SYMBOL_GPL(dwc2_set_all_params);
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH] staging: dwc2: fix value used in dwc2_set_all_params

2013-07-11 Thread Julien Delacou
From: Julien Delacou julien.dela...@stericsson.com

This fix uses 'value' parameter as it should be instead
of hardcoded -1.

Signed-off-by: Julien Delacou julien.dela...@stericsson.com
Acked-by: Paul Zimmerman pa...@synopys.com
---
 drivers/staging/dwc2/hcd.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
index 2ed54b1..ca38aaa 100644
--- a/drivers/staging/dwc2/hcd.c
+++ b/drivers/staging/dwc2/hcd.c
@@ -2690,7 +2690,7 @@ void dwc2_set_all_params(struct dwc2_core_params *params, 
int value)
int i;
 
for (i = 0; i  size; i++)
-   p[i] = -1;
+   p[i] = value;
 }
 EXPORT_SYMBOL_GPL(dwc2_set_all_params);
 
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] staging: dwc2: fix value used in dwc2_set_all_params

2013-07-11 Thread Matthijs Kooijman
On Thu, Jul 11, 2013 at 02:24:10PM +0200, Julien Delacou wrote:
 From: Julien Delacou julien.dela...@stericsson.com
 
 This fix uses 'value' parameter as it should be instead
 of hardcoded -1.
Woops!

 Signed-off-by: Julien Delacou julien.dela...@stericsson.com
 Acked-by: Paul Zimmerman pa...@synopys.com
Reviewed-by: Matthijs Kooijman matth...@stdin.nl

 ---
  drivers/staging/dwc2/hcd.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/drivers/staging/dwc2/hcd.c b/drivers/staging/dwc2/hcd.c
 index 2ed54b1..ca38aaa 100644
 --- a/drivers/staging/dwc2/hcd.c
 +++ b/drivers/staging/dwc2/hcd.c
 @@ -2690,7 +2690,7 @@ void dwc2_set_all_params(struct dwc2_core_params 
 *params, int value)
   int i;
  
   for (i = 0; i  size; i++)
 - p[i] = -1;
 + p[i] = value;
  }
  EXPORT_SYMBOL_GPL(dwc2_set_all_params);
  
 -- 
 1.7.9.5
 
 --
 To unsubscribe from this list: send the line unsubscribe linux-usb in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/