Re: [HPDD-discuss] [PATCH] staging: lustre: fid: lproc_fid: Removed variables that is never used

[Frank Zago]

On 01/28/2015 04:46 PM, Rickard Strandqvist wrote:

Variable ar assigned a value that is never used.


s/ar/rc/


I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist 
---
  drivers/staging/lustre/lustre/fid/lproc_fid.c |3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/fid/lproc_fid.c 
b/drivers/staging/lustre/lustre/fid/lproc_fid.c
index 6a21f07..feb7425 100644
--- a/drivers/staging/lustre/lustre/fid/lproc_fid.c
+++ b/drivers/staging/lustre/lustre/fid/lproc_fid.c
@@ -63,7 +63,6 @@ static int lprocfs_fid_write_common(const char __user 
*buffer, size_t count,
struct lu_seq_range *range)
  {
struct lu_seq_range tmp;
-   int rc;
char kernbuf[MAX_FID_RANGE_STRLEN];

LASSERT(range != NULL);
@@ -82,7 +81,7 @@ static int lprocfs_fid_write_common(const char __user 
*buffer, size_t count,
}

/* of the form "[0x00024400 - 0x00028000400]" */
-   rc = sscanf(kernbuf, "[%llx - %llx]\n",
+   sscanf(kernbuf, "[%llx - %llx]\n",


I would test rc instead:
  if (rc != 2)
   return -EINVAL;

Regards,
  Frank.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH] staging: lustre: fid: lproc_fid: Removed variables that is never used

[Joe Perches]

On Wed, 2015-01-28 at 23:46 +0100, Rickard Strandqvist wrote:
> Variable ar assigned a value that is never used.
> I have also removed all the code that thereby serves no purpose.
[]
> diff --git a/drivers/staging/lustre/lustre/fid/lproc_fid.c 
> b/drivers/staging/lustre/lustre/fid/lproc_fid.c
[]
> @@ -63,7 +63,6 @@ static int lprocfs_fid_write_common(const char __user 
> *buffer, size_t count,
>   struct lu_seq_range *range)
>  {
>   struct lu_seq_range tmp;
> - int rc;
>   char kernbuf[MAX_FID_RANGE_STRLEN];
>  
>   LASSERT(range != NULL);
> @@ -82,7 +81,7 @@ static int lprocfs_fid_write_common(const char __user 
> *buffer, size_t count,
>   }
>  
>   /* of the form "[0x00024400 - 0x00028000400]" */
> - rc = sscanf(kernbuf, "[%llx - %llx]\n",
> + sscanf(kernbuf, "[%llx - %llx]\n",
>   (unsigned long long *)&tmp.lsr_start,
>   (unsigned long long *)&tmp.lsr_end);
>   if (!range_is_sane(&tmp) || range_is_zero(&tmp) ||

Better to make this test use rc rather than
ignore the return from sscanf

if (rc != 2 || !range_is_sane(etc...))

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH] staging: lustre: fid: lproc_fid: Removed variables that is never used

[Rickard Strandqvist]

Variable ar assigned a value that is never used.
I have also removed all the code that thereby serves no purpose.

This was found using a static code analysis program called cppcheck

Signed-off-by: Rickard Strandqvist 
---
 drivers/staging/lustre/lustre/fid/lproc_fid.c |3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/fid/lproc_fid.c 
b/drivers/staging/lustre/lustre/fid/lproc_fid.c
index 6a21f07..feb7425 100644
--- a/drivers/staging/lustre/lustre/fid/lproc_fid.c
+++ b/drivers/staging/lustre/lustre/fid/lproc_fid.c
@@ -63,7 +63,6 @@ static int lprocfs_fid_write_common(const char __user 
*buffer, size_t count,
struct lu_seq_range *range)
 {
struct lu_seq_range tmp;
-   int rc;
char kernbuf[MAX_FID_RANGE_STRLEN];
 
LASSERT(range != NULL);
@@ -82,7 +81,7 @@ static int lprocfs_fid_write_common(const char __user 
*buffer, size_t count,
}
 
/* of the form "[0x00024400 - 0x00028000400]" */
-   rc = sscanf(kernbuf, "[%llx - %llx]\n",
+   sscanf(kernbuf, "[%llx - %llx]\n",
(unsigned long long *)&tmp.lsr_start,
(unsigned long long *)&tmp.lsr_end);
if (!range_is_sane(&tmp) || range_is_zero(&tmp) ||
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/