Re: [PATCH] staging: rtl8192e: fix typo in a function name

[William Durand]

> On Sat, Feb 13, 2021 at 09:20:14AM +, William Durand wrote:
> > Other function names use the verb 'query' so this function should
> > probably use it too and that's what this patch is about. I didn't
> > find any other occurrence and the code compiles.
> > 
> 
> It's really just assumed that the code still compiles afterwards.
> Sometimes, it's hard for me to right commit messages confidently because
> I don't know if static checker bugs affect real life.  But in this case
> I really think the commit message could be written more confidently.
> 
> Please write it like this:
> "There is a typo here where it says "qurey" but "query" was intended."

Thanks Dan, I'll update the commit message shortly and send a new patch.

Will

Re: [PATCH] staging: rtl8192e: fix typo in a function name

[Dan Carpenter]

On Sat, Feb 13, 2021 at 09:20:14AM +, William Durand wrote:
> Other function names use the verb 'query' so this function should
> probably use it too and that's what this patch is about. I didn't
> find any other occurrence and the code compiles.
> 

It's really just assumed that the code still compiles afterwards.
Sometimes, it's hard for me to right commit messages confidently because
I don't know if static checker bugs affect real life.  But in this case
I really think the commit message could be written more confidently.

Please write it like this:
"There is a typo here where it says "qurey" but "query" was intended."

regards,
dan carpenter

[PATCH] staging: rtl8192e: fix typo in a function name

[William Durand]

Other function names use the verb 'query' so this function should
probably use it too and that's what this patch is about. I didn't
find any other occurrence and the code compiles.

Signed-off-by: William Durand 
---
 drivers/staging/rtl8192e/rtllib_tx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8192e/rtllib_tx.c 
b/drivers/staging/rtl8192e/rtllib_tx.c
index 8add17752eed..50cf10201fdd 100644
--- a/drivers/staging/rtl8192e/rtllib_tx.c
+++ b/drivers/staging/rtl8192e/rtllib_tx.c
@@ -339,7 +339,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_device 
*ieee,
}
 }

-static void rtllib_qurey_ShortPreambleMode(struct rtllib_device *ieee,
+static void rtllib_query_ShortPreambleMode(struct rtllib_device *ieee,
   struct cb_desc *tcb_desc)
 {
tcb_desc->bUseShortPreamble = false;
@@ -928,7 +928,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struct 
net_device *dev)
tcb_desc->bdhcp = 1;
}

-   rtllib_qurey_ShortPreambleMode(ieee, tcb_desc);
+   rtllib_query_ShortPreambleMode(ieee, tcb_desc);
rtllib_tx_query_agg_cap(ieee, txb->fragments[0],
tcb_desc);
rtllib_query_HTCapShortGI(ieee, tcb_desc);
--
2.17.1