Re: [PATCH] staging: speakup: fix line over 80 characters.
On Sun, Mar 17, 2019 at 03:39:46AM +, Jules Irenge wrote: > Fix coding style issues, which solves checkpatch.pl warning: > "WARNING: line over 80 characters". > --- > drivers/staging/speakup/kobjects.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/speakup/kobjects.c > b/drivers/staging/speakup/kobjects.c > index 2eb5af3debb3..abeab64899db 100644 > --- a/drivers/staging/speakup/kobjects.c > +++ b/drivers/staging/speakup/kobjects.c > @@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj, > continue; > } > > - /* Do not replace with kstrtoul: here we need temp to be > updated */ > +/* Do not replace with kstrtoul: here we need temp to be updated */ No, never put code or comments this far to the left. Instead, properly line-wrap them. thanks, greg k-h
Re: [Outreachy kernel] [PATCH] staging: speakup: fix line over 80 characters.
On Sun, 17 Mar 2019, Jules Irenge wrote: > Fix coding style issues, which solves checkpatch.pl warning: > "WARNING: line over 80 characters". > --- > drivers/staging/speakup/kobjects.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/speakup/kobjects.c > b/drivers/staging/speakup/kobjects.c > index 2eb5af3debb3..abeab64899db 100644 > --- a/drivers/staging/speakup/kobjects.c > +++ b/drivers/staging/speakup/kobjects.c > @@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj, > continue; > } > > - /* Do not replace with kstrtoul: here we need temp to be > updated */ > +/* Do not replace with kstrtoul: here we need temp to be updated */ It's only a few characters over 80. Maybe you can rephrase the comment instead. julia > index = simple_strtoul(cp, &temp, 10); > if (index > 255) { > rejected++; > @@ -788,7 +788,7 @@ static ssize_t message_store_helper(const char *buf, > size_t count, > continue; > } > > - /* Do not replace with kstrtoul: here we need temp to be > updated */ > +/* Do not replace with kstrtoul: here we need temp to be updated */ > index = simple_strtoul(cp, &temp, 10); > > while ((temp < linefeed) && (*temp == ' ' || *temp == '\t')) > -- > 2.20.1 > > -- > You received this message because you are subscribed to the Google Groups > "outreachy-kernel" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to outreachy-kernel+unsubscr...@googlegroups.com. > To post to this group, send email to outreachy-ker...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/outreachy-kernel/20190317033946.12585-1-jbi.octave%40gmail.com. > For more options, visit https://groups.google.com/d/optout. >
[PATCH] staging: speakup: fix line over 80 characters.
Fix coding style issues, which solves checkpatch.pl warning: "WARNING: line over 80 characters". --- drivers/staging/speakup/kobjects.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index 2eb5af3debb3..abeab64899db 100644 --- a/drivers/staging/speakup/kobjects.c +++ b/drivers/staging/speakup/kobjects.c @@ -154,7 +154,7 @@ static ssize_t chars_chartab_store(struct kobject *kobj, continue; } - /* Do not replace with kstrtoul: here we need temp to be updated */ +/* Do not replace with kstrtoul: here we need temp to be updated */ index = simple_strtoul(cp, &temp, 10); if (index > 255) { rejected++; @@ -788,7 +788,7 @@ static ssize_t message_store_helper(const char *buf, size_t count, continue; } - /* Do not replace with kstrtoul: here we need temp to be updated */ +/* Do not replace with kstrtoul: here we need temp to be updated */ index = simple_strtoul(cp, &temp, 10); while ((temp < linefeed) && (*temp == ' ' || *temp == '\t')) -- 2.20.1