Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix line over 80 characters checks warning

2019-10-16 Thread Jules Irenge



On Wed, 16 Oct 2019, Julia Lawall wrote:

> >  #ifndef VCHI_BULK_GRANULARITY
> >  #   if __VCCOREVER__ >= 0x0400
> > -#   define VCHI_BULK_GRANULARITY 32 // Allows for the need to do cache 
> > cleans
> > +#  define VCHI_BULK_GRANULARITY 32 // Allows for the need of cache cleans
> >  #   else
> >  #   define VCHI_BULK_GRANULARITY 16
> >  #   endif
> 
> The branches should be indented to the same degree.
> 
> julia
> 
> -- 

Thanks, I have just  updated. 


Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix line over 80 characters checks warning

2019-10-15 Thread Julia Lawall
>  #ifndef VCHI_BULK_GRANULARITY
>  #   if __VCCOREVER__ >= 0x0400
> -#   define VCHI_BULK_GRANULARITY 32 // Allows for the need to do cache 
> cleans
> +#define VCHI_BULK_GRANULARITY 32 // Allows for the need of cache cleans
>  #   else
>  #   define VCHI_BULK_GRANULARITY 16
>  #   endif

The branches should be indented to the same degree.

julia


[PATCH] staging: vc04_services: fix line over 80 characters checks warning

2019-10-15 Thread Jules Irenge
Fix line over 80 characters checks warning.
Issue detected by checkpatch tool.

Signed-off-by: Jules Irenge 
---
 .../vc04_services/interface/vchi/vchi_cfg.h   | 150 ++
 1 file changed, 88 insertions(+), 62 deletions(-)

diff --git a/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h 
b/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h
index 89aa4e6122cd..dbb6a5f07a79 100644
--- a/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h
+++ b/drivers/staging/vc04_services/interface/vchi/vchi_cfg.h
@@ -4,13 +4,17 @@
 #ifndef VCHI_CFG_H_
 #define VCHI_CFG_H_
 
-/
- * Defines in this first section are part of the VCHI API and may be examined 
by VCHI
- * services.
- 
***/
-
-/* Required alignment of base addresses for bulk transfer, if unaligned 
transfers are not enabled */
-/* Really determined by the message driver, and should be available from a 
run-time call. */
+/*
+ * Defines in this first section are part of the VCHI API and may be examined
+ * by VCHI services.
+ */
+
+/* Required alignment of base addresses for bulk transfer, if unaligned
+ * transfers are not enabled
+ *
+ * Really determined by the message driver, and should be available from
+ * a run-time call.
+ */
 #ifndef VCHI_BULK_ALIGN
 #   if __VCCOREVER__ >= 0x0400
 #   define VCHI_BULK_ALIGN 32 // Allows for the need to do cache cleans
@@ -19,12 +23,15 @@
 #   endif
 #endif
 
-/* Required length multiple for bulk transfers, if unaligned transfers are not 
enabled */
-/* May be less than or greater than VCHI_BULK_ALIGN */
-/* Really determined by the message driver, and should be available from a 
run-time call. */
+/* Required length multiple for bulk transfers, if unaligned transfers are
+ * not enabled
+ * May be less than or greater than VCHI_BULK_ALIGN
+ * Really determined by the message driver, and should be available from
+ * a run-time call.
+ */
 #ifndef VCHI_BULK_GRANULARITY
 #   if __VCCOREVER__ >= 0x0400
-#   define VCHI_BULK_GRANULARITY 32 // Allows for the need to do cache 
cleans
+#  define VCHI_BULK_GRANULARITY 32 // Allows for the need of cache cleans
 #   else
 #   define VCHI_BULK_GRANULARITY 16
 #   endif
@@ -39,19 +46,22 @@
 #   endif
 #endif
 
-/**
- * Defines below are system configuration options, and should not be used by 
VCHI services.
- 
*/
+/***
+ * Defines below are system configuration options, and should not be used by
+ * VCHI services.
+ 
**/
 
-/* How many connections can we support? A localhost implementation uses 2 
connections,
- * 1 for host-app, 1 for VMCS, and these are hooked together by a loopback 
MPHI VCFW
- * driver. */
+/* How many connections can we support? A localhost implementation
+ * uses 2 connections, 1 for host-app, 1 for VMCS,
+ * and these are hooked together by a loopback MPHI VCFW  driver.
+ */
 #ifndef VCHI_MAX_NUM_CONNECTIONS
 #   define VCHI_MAX_NUM_CONNECTIONS 3
 #endif
 
-/* How many services can we open per connection? Extending this doesn't cost 
processing time, just a small
- * amount of static memory. */
+/* How many services can we open per connection? Extending this doesn't cost
+ * processing time, just a small amount of static memory.
+ */
 #ifndef VCHI_MAX_SERVICES_PER_CONNECTION
 #  define VCHI_MAX_SERVICES_PER_CONNECTION 36
 #endif
@@ -66,8 +76,9 @@
 #   define VCHI_MAX_BULK_RX_CHANNELS_PER_CONNECTION 1 // 1 MPHI
 #endif
 
-/* How many receive slots do we use. This times VCHI_MAX_MSG_SIZE gives the 
effective
- * receive queue space, less message headers. */
+/* How many receive slots do we use. This times VCHI_MAX_MSG_SIZE gives
+ * the effective receive queue space, less message headers.
+ */
 #ifndef VCHI_NUM_READ_SLOTS
 #  if defined(VCHI_LOCAL_HOST_PORT)
 # define VCHI_NUM_READ_SLOTS 4
@@ -76,92 +87,107 @@
 #  endif
 #endif
 
-/* Do we utilise overrun facility for receive message slots? Can aid peer 
transmit
- * performance. Only define on VideoCore end, talking to host.
+/* Do we utilise overrun facility for receive message slots? Can aid peer
+ * transmit performance. Only define on VideoCore end, talking to host.
  */
 //#define VCHI_MSG_RX_OVERRUN
 
-/* How many transmit slots do we use. Generally don't need many, as the 
hardware driver
- * underneath VCHI will usually have its own buffering. */
+/* How many transmit slots do we use. Generally don't need