Re: [PATCH] tools/vm/page-types.c: fix "kpagecount returned fewer pages than expected" failures

[Naoya Horiguchi]

On Tue, Dec 04, 2018 at 02:24:29PM -0800, Anthony Yznaga wrote:
> Because kpagecount_read() fakes success if map counts are not being
> collected, clamp the page count passed to it by walk_pfn() to the pages
> value returned by the preceding call to kpageflags_read().
> 
> Fixes: 7f1d23e60718 ("tools/vm/page-types.c: include shared map counts")
> Signed-off-by: Anthony Yznaga 

Reviewed-by: Naoya Horiguchi 

> ---
>  tools/vm/page-types.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c
> index 37908a83ddc2..1ff3a6c0367b 100644
> --- a/tools/vm/page-types.c
> +++ b/tools/vm/page-types.c
> @@ -701,7 +701,7 @@ static void walk_pfn(unsigned long voffset,
>   if (kpagecgroup_read(cgi, index, pages) != pages)
>   fatal("kpagecgroup returned fewer pages than expected");
>  
> - if (kpagecount_read(cnt, index, batch) != pages)
> + if (kpagecount_read(cnt, index, pages) != pages)
>   fatal("kpagecount returned fewer pages than expected");
>  
>   for (i = 0; i < pages; i++)
> -- 
> 1.8.3.1
> 
> 

[PATCH] tools/vm/page-types.c: fix "kpagecount returned fewer pages than expected" failures

[Anthony Yznaga]

Because kpagecount_read() fakes success if map counts are not being
collected, clamp the page count passed to it by walk_pfn() to the pages
value returned by the preceding call to kpageflags_read().

Fixes: 7f1d23e60718 ("tools/vm/page-types.c: include shared map counts")
Signed-off-by: Anthony Yznaga 
---
 tools/vm/page-types.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c
index 37908a83ddc2..1ff3a6c0367b 100644
--- a/tools/vm/page-types.c
+++ b/tools/vm/page-types.c
@@ -701,7 +701,7 @@ static void walk_pfn(unsigned long voffset,
if (kpagecgroup_read(cgi, index, pages) != pages)
fatal("kpagecgroup returned fewer pages than expected");
 
-   if (kpagecount_read(cnt, index, batch) != pages)
+   if (kpagecount_read(cnt, index, pages) != pages)
fatal("kpagecount returned fewer pages than expected");
 
for (i = 0; i < pages; i++)
-- 
1.8.3.1

[PATCH] tools/vm/page-types.c: fix "kpagecount returned fewer pages than expected" failures

[Anthony Yznaga]

Because kpagecount_read() fakes success if map counts are not being
collected, clamp the page count passed to it by walk_pfn() to the pages
value returned by the preceding call to kpageflags_read().

Fixes: 7f1d23e60718 ("tools/vm/page-types.c: include shared map counts")
Signed-off-by: Anthony Yznaga 
---
 tools/vm/page-types.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/vm/page-types.c b/tools/vm/page-types.c
index 37908a83ddc2..1ff3a6c0367b 100644
--- a/tools/vm/page-types.c
+++ b/tools/vm/page-types.c
@@ -701,7 +701,7 @@ static void walk_pfn(unsigned long voffset,
if (kpagecgroup_read(cgi, index, pages) != pages)
fatal("kpagecgroup returned fewer pages than expected");
 
-   if (kpagecount_read(cnt, index, batch) != pages)
+   if (kpagecount_read(cnt, index, pages) != pages)
fatal("kpagecount returned fewer pages than expected");
 
for (i = 0; i < pages; i++)
-- 
1.8.3.1