Re: [PATCH] w1: Remove unneeded header file
Hi 28.06.2016, 16:50, "Julia Lawall": >> 24.06.2016, 09:18, "Amitoj Kaur Chawla" : >> > The Coccinelle semantic patch used to make this change is as follows: >> > @ includesmodule @ >> > @@ >> > >> > #include >> > >> > @ depends on includesmodule @ >> > @@ >> > >> > - #include >> > >> > Signed-off-by: Amitoj Kaur Chawla >> >> Looks good to me, but these @@ are pretty cryptic. > > There are two rules. The first checks for an include of module.h. The > second depends on the success of the first one. It removes and include o > moduleparam.h. Ok, I see, it makes much more sense now :) Thank you for clarification
Re: [PATCH] w1: Remove unneeded header file
Hi 28.06.2016, 16:50, "Julia Lawall" : >> 24.06.2016, 09:18, "Amitoj Kaur Chawla" : >> > The Coccinelle semantic patch used to make this change is as follows: >> > @ includesmodule @ >> > @@ >> > >> > #include >> > >> > @ depends on includesmodule @ >> > @@ >> > >> > - #include >> > >> > Signed-off-by: Amitoj Kaur Chawla >> >> Looks good to me, but these @@ are pretty cryptic. > > There are two rules. The first checks for an include of module.h. The > second depends on the success of the first one. It removes and include o > moduleparam.h. Ok, I see, it makes much more sense now :) Thank you for clarification
Re: [PATCH] w1: Remove unneeded header file
On Tue, 28 Jun 2016, Evgeniy Polyakov wrote: > Hi > > 24.06.2016, 09:18, "Amitoj Kaur Chawla": > > Drop redundant include of moduleparam.h > > > > The Coccinelle semantic patch used to make this change is as follows: > > @ includesmodule @ > > @@ > > > > #include > > > > @ depends on includesmodule @ > > @@ > > > > - #include > > > > Signed-off-by: Amitoj Kaur Chawla > > Looks good to me, but these @@ are pretty cryptic. There are two rules. The first checks for an include of module.h. The second depends on the success of the first one. It removes and include o moduleparam.h. julia
Re: [PATCH] w1: Remove unneeded header file
On Tue, 28 Jun 2016, Evgeniy Polyakov wrote: > Hi > > 24.06.2016, 09:18, "Amitoj Kaur Chawla" : > > Drop redundant include of moduleparam.h > > > > The Coccinelle semantic patch used to make this change is as follows: > > @ includesmodule @ > > @@ > > > > #include > > > > @ depends on includesmodule @ > > @@ > > > > - #include > > > > Signed-off-by: Amitoj Kaur Chawla > > Looks good to me, but these @@ are pretty cryptic. There are two rules. The first checks for an include of module.h. The second depends on the success of the first one. It removes and include o moduleparam.h. julia
Re: [PATCH] w1: Remove unneeded header file
Hi 24.06.2016, 09:18, "Amitoj Kaur Chawla": > Drop redundant include of moduleparam.h > > The Coccinelle semantic patch used to make this change is as follows: > @ includesmodule @ > @@ > > #include > > @ depends on includesmodule @ > @@ > > - #include > > Signed-off-by: Amitoj Kaur Chawla Looks good to me, but these @@ are pretty cryptic.
Re: [PATCH] w1: Remove unneeded header file
Hi 24.06.2016, 09:18, "Amitoj Kaur Chawla" : > Drop redundant include of moduleparam.h > > The Coccinelle semantic patch used to make this change is as follows: > @ includesmodule @ > @@ > > #include > > @ depends on includesmodule @ > @@ > > - #include > > Signed-off-by: Amitoj Kaur Chawla Looks good to me, but these @@ are pretty cryptic.
[PATCH] w1: Remove unneeded header file
Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ #include @ depends on includesmodule @ @@ - #include Signed-off-by: Amitoj Kaur Chawla--- drivers/w1/w1.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 89a7847..a02361d 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -22,7 +22,6 @@ #include #include #include -#include #include #include #include -- 1.9.1
[PATCH] w1: Remove unneeded header file
Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ #include @ depends on includesmodule @ @@ - #include Signed-off-by: Amitoj Kaur Chawla --- drivers/w1/w1.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c index 89a7847..a02361d 100644 --- a/drivers/w1/w1.c +++ b/drivers/w1/w1.c @@ -22,7 +22,6 @@ #include #include #include -#include #include #include #include -- 1.9.1