Re: [PATCH] w1: fix timeout_us parameter description

[Evgeniy Polyakov]

Hi

10.08.2016, 06:22, "Wei Yongjun" :
>>  08.08.2016, 16:52, "Wei Yongjun" :
>>>  Fix 'timeout_us' parameter description.

>>>   MODULE_PARM_DESC(timeout, "time in seconds between automatic slave 
>>> searches");
>>>   module_param_named(timeout_us, w1_timeout_us, int, 0);
>>>  -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
>>>  - " searches");
>>>  +MODULE_PARM_DESC(timeout_us,
>>>  + "time in microseconds between automatic slave searches");
>>  I believe there will be no harm to put it to on one line, even if it 
>> crosses some obscure very-long-line rule
>
> Maybe the bad patch description confused you, this patch the typo in the
> first argument of MODULE_PARM_DESC(), use timeout_us instead of timeout.

Yup, you are right, please make it as one line since you are at it

Re: [PATCH] w1: fix timeout_us parameter description

[Evgeniy Polyakov]

Hi

10.08.2016, 06:22, "Wei Yongjun" :
>>  08.08.2016, 16:52, "Wei Yongjun" :
>>>  Fix 'timeout_us' parameter description.

>>>   MODULE_PARM_DESC(timeout, "time in seconds between automatic slave 
>>> searches");
>>>   module_param_named(timeout_us, w1_timeout_us, int, 0);
>>>  -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
>>>  - " searches");
>>>  +MODULE_PARM_DESC(timeout_us,
>>>  + "time in microseconds between automatic slave searches");
>>  I believe there will be no harm to put it to on one line, even if it 
>> crosses some obscure very-long-line rule
>
> Maybe the bad patch description confused you, this patch the typo in the
> first argument of MODULE_PARM_DESC(), use timeout_us instead of timeout.

Yup, you are right, please make it as one line since you are at it

Re: [PATCH] w1: fix timeout_us parameter description

[Wei Yongjun]

Hi

On 08/10/2016 06:54 AM, Evgeniy Polyakov wrote:
> Hi
>
> 08.08.2016, 16:52, "Wei Yongjun" :
>> Fix 'timeout_us' parameter description.
>>
>> Signed-off-by: Wei Yongjun 
>> ---
>>  drivers/w1/w1.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
>> index bb34362..e213c67 100644
>> --- a/drivers/w1/w1.c
>> +++ b/drivers/w1/w1.c
>> @@ -53,8 +53,8 @@ int w1_max_slave_ttl = 10;
>>  module_param_named(timeout, w1_timeout, int, 0);
>>  MODULE_PARM_DESC(timeout, "time in seconds between automatic slave 
>> searches");
>>  module_param_named(timeout_us, w1_timeout_us, int, 0);
>> -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
>> - " searches");
>> +MODULE_PARM_DESC(timeout_us,
>> + "time in microseconds between automatic slave searches");
> I believe there will be no harm to put it to on one line, even if it crosses 
> some obscure very-long-line rule

Maybe the bad patch description confused you, this patch the typo in the
first argument of MODULE_PARM_DESC(), use timeout_us instead of timeout.

Re: [PATCH] w1: fix timeout_us parameter description

[Wei Yongjun]

Hi

On 08/10/2016 06:54 AM, Evgeniy Polyakov wrote:
> Hi
>
> 08.08.2016, 16:52, "Wei Yongjun" :
>> Fix 'timeout_us' parameter description.
>>
>> Signed-off-by: Wei Yongjun 
>> ---
>>  drivers/w1/w1.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
>> index bb34362..e213c67 100644
>> --- a/drivers/w1/w1.c
>> +++ b/drivers/w1/w1.c
>> @@ -53,8 +53,8 @@ int w1_max_slave_ttl = 10;
>>  module_param_named(timeout, w1_timeout, int, 0);
>>  MODULE_PARM_DESC(timeout, "time in seconds between automatic slave 
>> searches");
>>  module_param_named(timeout_us, w1_timeout_us, int, 0);
>> -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
>> - " searches");
>> +MODULE_PARM_DESC(timeout_us,
>> + "time in microseconds between automatic slave searches");
> I believe there will be no harm to put it to on one line, even if it crosses 
> some obscure very-long-line rule

Maybe the bad patch description confused you, this patch the typo in the
first argument of MODULE_PARM_DESC(), use timeout_us instead of timeout.

Re: [PATCH] w1: fix timeout_us parameter description

[Evgeniy Polyakov]

Hi

08.08.2016, 16:52, "Wei Yongjun" :
> Fix 'timeout_us' parameter description.
>
> Signed-off-by: Wei Yongjun 
> ---
>  drivers/w1/w1.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index bb34362..e213c67 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -53,8 +53,8 @@ int w1_max_slave_ttl = 10;
>  module_param_named(timeout, w1_timeout, int, 0);
>  MODULE_PARM_DESC(timeout, "time in seconds between automatic slave 
> searches");
>  module_param_named(timeout_us, w1_timeout_us, int, 0);
> -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
> - " searches");
> +MODULE_PARM_DESC(timeout_us,
> + "time in microseconds between automatic slave searches");

I believe there will be no harm to put it to on one line, even if it crosses 
some obscure very-long-line rule

Re: [PATCH] w1: fix timeout_us parameter description

[Evgeniy Polyakov]

Hi

08.08.2016, 16:52, "Wei Yongjun" :
> Fix 'timeout_us' parameter description.
>
> Signed-off-by: Wei Yongjun 
> ---
>  drivers/w1/w1.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
> index bb34362..e213c67 100644
> --- a/drivers/w1/w1.c
> +++ b/drivers/w1/w1.c
> @@ -53,8 +53,8 @@ int w1_max_slave_ttl = 10;
>  module_param_named(timeout, w1_timeout, int, 0);
>  MODULE_PARM_DESC(timeout, "time in seconds between automatic slave 
> searches");
>  module_param_named(timeout_us, w1_timeout_us, int, 0);
> -MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
> - " searches");
> +MODULE_PARM_DESC(timeout_us,
> + "time in microseconds between automatic slave searches");

I believe there will be no harm to put it to on one line, even if it crosses 
some obscure very-long-line rule

[PATCH] w1: fix timeout_us parameter description

[Wei Yongjun]

Fix 'timeout_us' parameter description.

Signed-off-by: Wei Yongjun 
---
 drivers/w1/w1.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index bb34362..e213c67 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -53,8 +53,8 @@ int w1_max_slave_ttl = 10;
 module_param_named(timeout, w1_timeout, int, 0);
 MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches");
 module_param_named(timeout_us, w1_timeout_us, int, 0);
-MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
- " searches");
+MODULE_PARM_DESC(timeout_us,
+"time in microseconds between automatic slave searches");
 /* A search stops when w1_max_slave_count devices have been found in that
  * search.  The next search will start over and detect the same set of devices
  * on a static 1-wire bus.  Memory is not allocated based on this number, just

[PATCH] w1: fix timeout_us parameter description

[Wei Yongjun]

Fix 'timeout_us' parameter description.

Signed-off-by: Wei Yongjun 
---
 drivers/w1/w1.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index bb34362..e213c67 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -53,8 +53,8 @@ int w1_max_slave_ttl = 10;
 module_param_named(timeout, w1_timeout, int, 0);
 MODULE_PARM_DESC(timeout, "time in seconds between automatic slave searches");
 module_param_named(timeout_us, w1_timeout_us, int, 0);
-MODULE_PARM_DESC(timeout, "time in microseconds between automatic slave"
- " searches");
+MODULE_PARM_DESC(timeout_us,
+"time in microseconds between automatic slave searches");
 /* A search stops when w1_max_slave_count devices have been found in that
  * search.  The next search will start over and detect the same set of devices
  * on a static 1-wire bus.  Memory is not allocated based on this number, just