Re: [PATCH] wireless: airo: remove unnecessary static in writerids()

[David Miller]

From: "Gustavo A. R. Silva" 
Date: Tue, 18 Jul 2017 15:37:11 -0500

> Remove unnecessary static on local function pointer _writer_.
> Such pointer is initialized before being used, on every
> execution path throughout the function. The static has no
> benefit and, removing it reduces the object file size.
> 
> This issue was detected using Coccinelle and the following semantic patch:
 ...
> Signed-off-by: Gustavo A. R. Silva 

Applied.

[PATCH] wireless: airo: remove unnecessary static in writerids()

[Gustavo A. R. Silva]

Remove unnecessary static on local function pointer _writer_.
Such pointer is initialized before being used, on every
execution path throughout the function. The static has no
benefit and, removing it reduces the object file size.

This issue was detected using Coccinelle and the following semantic patch:

@bad exists@
position p;
identifier x;
type T;
@@

static T x@p;
...
x = <+...x...+>

@@
identifier x;
expression e;
type T;
position p != bad.p;
@@

-static
 T x@p;
 ... when != x
 when strict
?x = e;

In the following log you can see a significant difference in the object
file size. This log is the output of the size command, before and after
the code change:

before:
   textdata bss dec hex filename
 113797   191521216  134165   20c15 drivers/net/wireless/cisco/airo.o

after:
   textdata bss dec hex filename
 113881   190961152  134129   20bf1 drivers/net/wireless/cisco/airo.o

Signed-off-by: Gustavo A. R. Silva 
---
 drivers/net/wireless/cisco/airo.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/cisco/airo.c 
b/drivers/net/wireless/cisco/airo.c
index 84143a0..1066d84 100644
--- a/drivers/net/wireless/cisco/airo.c
+++ b/drivers/net/wireless/cisco/airo.c
@@ -7837,7 +7837,7 @@ static int writerids(struct net_device *dev, 
aironet_ioctl *comp) {
struct airo_info *ai = dev->ml_priv;
int  ridcode;
 int  enabled;
-   static int (* writer)(struct airo_info *, u16 rid, const void *, int, 
int);
+   int (*writer)(struct airo_info *, u16 rid, const void *, int, int);
unsigned char *iobuf;
 
/* Only super-user can write RIDs */
-- 
2.5.0