Re: [PATCH] workqueue: remove unused WORK_CPU_END
On Thu, May 22, 2014 at 04:43:44PM +0800, Lai Jiangshan wrote:
> WORK_CPU_END is totally unused since 4e8b22bd. It should be removed.
Please use 12_CHAR_PREFIX_OF_SHA1 ("SUBJ") when referring to other
commits.
> After it is removed, the comment "special cpu IDs" is not precise due to
> there is only one special CPU ID (WORK_CPU_UNBOUND) left, so we also
> change this comment to the description for WORK_CPU_UNBOUND.
>
> Signed-off-by: Lai Jiangshan
Applied to wq/for-3.16.
Thanks.
--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] workqueue: remove unused WORK_CPU_END
WORK_CPU_END is totally unused since 4e8b22bd. It should be removed.
After it is removed, the comment "special cpu IDs" is not precise due to
there is only one special CPU ID (WORK_CPU_UNBOUND) left, so we also
change this comment to the description for WORK_CPU_UNBOUND.
Signed-off-by: Lai Jiangshan
---
include/linux/workqueue.h |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index 7a8800c..860fcca 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -56,9 +56,8 @@ enum {
WORK_NR_COLORS = (1 << WORK_STRUCT_COLOR_BITS) - 1,
WORK_NO_COLOR = WORK_NR_COLORS,
- /* special cpu IDs */
+ /* NOT bound to any CPU, the local CPU will be used if possible. */
WORK_CPU_UNBOUND= NR_CPUS,
- WORK_CPU_END= NR_CPUS + 1,
/*
* Reserve 7 bits off of pwq pointer w/ debugobjects turned off.
--
1.7.4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH] workqueue: remove unused WORK_CPU_END
WORK_CPU_END is totally unused since 4e8b22bd. It should be removed.
After it is removed, the comment special cpu IDs is not precise due to
there is only one special CPU ID (WORK_CPU_UNBOUND) left, so we also
change this comment to the description for WORK_CPU_UNBOUND.
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com
---
include/linux/workqueue.h |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/include/linux/workqueue.h b/include/linux/workqueue.h
index 7a8800c..860fcca 100644
--- a/include/linux/workqueue.h
+++ b/include/linux/workqueue.h
@@ -56,9 +56,8 @@ enum {
WORK_NR_COLORS = (1 WORK_STRUCT_COLOR_BITS) - 1,
WORK_NO_COLOR = WORK_NR_COLORS,
- /* special cpu IDs */
+ /* NOT bound to any CPU, the local CPU will be used if possible. */
WORK_CPU_UNBOUND= NR_CPUS,
- WORK_CPU_END= NR_CPUS + 1,
/*
* Reserve 7 bits off of pwq pointer w/ debugobjects turned off.
--
1.7.4.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH] workqueue: remove unused WORK_CPU_END
On Thu, May 22, 2014 at 04:43:44PM +0800, Lai Jiangshan wrote: WORK_CPU_END is totally unused since 4e8b22bd. It should be removed. Please use 12_CHAR_PREFIX_OF_SHA1 (SUBJ) when referring to other commits. After it is removed, the comment special cpu IDs is not precise due to there is only one special CPU ID (WORK_CPU_UNBOUND) left, so we also change this comment to the description for WORK_CPU_UNBOUND. Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com Applied to wq/for-3.16. Thanks. -- tejun -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
