Re: [PATCH] x86/platform/intel-mid: Fix build error without CONFIG_ACPI

[Yuehaibing]

On 2020/9/1 12:07, Randy Dunlap wrote:
> On 8/31/20 8:58 PM, YueHaibing wrote:
>> arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’:
>> arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function 
>> ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? 
>> [-Werror=implicit-function-declaration]
>>   acpi_noirq_set();
>>   ^~
>>   acpi_irq_get
>>
>> Fixes: a912a7584ec3 ("x86/platform/intel-mid: Move PCI initialization to 
>> arch_init()")
>> Signed-off-by: YueHaibing 
> 
> Bjorn has merged my patch (or so his email says), but apparently it's not
> in linux-next yet.

Thanks for info.

> 
> 
>> ---
>>  arch/x86/pci/intel_mid_pci.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
>> index 00c62115f39c..0aaf31917061 100644
>> --- a/arch/x86/pci/intel_mid_pci.c
>> +++ b/arch/x86/pci/intel_mid_pci.c
>> @@ -33,6 +33,7 @@
>>  #include 
>>  #include 
>>  #include 
>> +#include 
>>  
>>  #define PCIE_CAP_OFFSET 0x100
>>  
>>
> 
> thanks.
> 

Re: [PATCH] x86/platform/intel-mid: Fix build error without CONFIG_ACPI

[Randy Dunlap]

On 8/31/20 8:58 PM, YueHaibing wrote:
> arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’:
> arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function 
> ‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? 
> [-Werror=implicit-function-declaration]
>   acpi_noirq_set();
>   ^~
>   acpi_irq_get
> 
> Fixes: a912a7584ec3 ("x86/platform/intel-mid: Move PCI initialization to 
> arch_init()")
> Signed-off-by: YueHaibing 

Bjorn has merged my patch (or so his email says), but apparently it's not
in linux-next yet.


> ---
>  arch/x86/pci/intel_mid_pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
> index 00c62115f39c..0aaf31917061 100644
> --- a/arch/x86/pci/intel_mid_pci.c
> +++ b/arch/x86/pci/intel_mid_pci.c
> @@ -33,6 +33,7 @@
>  #include 
>  #include 
>  #include 
> +#include 
>  
>  #define PCIE_CAP_OFFSET  0x100
>  
> 

thanks.
-- 
~Randy

[PATCH] x86/platform/intel-mid: Fix build error without CONFIG_ACPI

[YueHaibing]

arch/x86/pci/intel_mid_pci.c: In function ‘intel_mid_pci_init’:
arch/x86/pci/intel_mid_pci.c:303:2: error: implicit declaration of function 
‘acpi_noirq_set’; did you mean ‘acpi_irq_get’? 
[-Werror=implicit-function-declaration]
  acpi_noirq_set();
  ^~
  acpi_irq_get

Fixes: a912a7584ec3 ("x86/platform/intel-mid: Move PCI initialization to 
arch_init()")
Signed-off-by: YueHaibing 
---
 arch/x86/pci/intel_mid_pci.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
index 00c62115f39c..0aaf31917061 100644
--- a/arch/x86/pci/intel_mid_pci.c
+++ b/arch/x86/pci/intel_mid_pci.c
@@ -33,6 +33,7 @@
 #include 
 #include 
 #include 
+#include 
 
 #define PCIE_CAP_OFFSET0x100
 
-- 
2.17.1