Re: [PATCH] x86: add PCI IDs to k8topology_64.c II

2008-02-01 Thread dean gaudet
On Tue, 29 Jan 2008, Andi Kleen wrote:

> > SRAT is essentially just a two dimensional table with node distances.
> 
> Sorry, that was actually SLIT. SRAT is not two dimensional, but also
> relatively simple. SLIT you don't really need to implement.

yeah but i'd heartily recommend implementing SLIT too.  mind you it's 
almost universal non-existence means i've had to resort to userland 
measurements to determine node distances and that won't change.  i guess i 
just wanted to grumble somewhere.

-dean
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] x86: add PCI IDs to k8topology_64.c II

2008-02-01 Thread dean gaudet
On Tue, 29 Jan 2008, Andi Kleen wrote:

  SRAT is essentially just a two dimensional table with node distances.
 
 Sorry, that was actually SLIT. SRAT is not two dimensional, but also
 relatively simple. SLIT you don't really need to implement.

yeah but i'd heartily recommend implementing SLIT too.  mind you it's 
almost universal non-existence means i've had to resort to userland 
measurements to determine node distances and that won't change.  i guess i 
just wanted to grumble somewhere.

-dean
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] x86: add PCI IDs to k8topology_64.c II

2008-01-29 Thread Yinghai Lu
On Jan 29, 2008 12:31 AM, Andi Kleen <[EMAIL PROTECTED]> wrote:
>
> On Mon, Jan 28, 2008 at 11:39:30PM -0800, Yinghai Lu wrote:
> > On Jan 29, 2008 12:09 AM, Andi Kleen <[EMAIL PROTECTED]> wrote:
> > > > SRAT is essentially just a two dimensional table with node distances.
> > >
> > > Sorry, that was actually SLIT. SRAT is not two dimensional, but also
> > > relatively simple. SLIT you don't really need to implement.
> > >
> >
> > need to add some CONFIG option to parse SRAT, MADT etc only. but don't
> > pull DSDT related...
>
> I don't think it needs a CONFIG. The code should handle this case
> by itself in any case. I'm not entirely sure it does currently, but if it
> doesn't it will likely not be very difficult to fix.
>
> Or are you worried about code size? ACPI is around ~270k on x86-64,
> which while certainly not small should not be a problem on x86 NUMA
> systems.

like acpi=off, acpi=tableonly? so it will load dsdt, and some one
module rely on dsdt could not complain ACPI ERROR..

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] x86: add PCI IDs to k8topology_64.c II

2008-01-29 Thread Yinghai Lu
On Jan 29, 2008 12:31 AM, Andi Kleen [EMAIL PROTECTED] wrote:

 On Mon, Jan 28, 2008 at 11:39:30PM -0800, Yinghai Lu wrote:
  On Jan 29, 2008 12:09 AM, Andi Kleen [EMAIL PROTECTED] wrote:
SRAT is essentially just a two dimensional table with node distances.
  
   Sorry, that was actually SLIT. SRAT is not two dimensional, but also
   relatively simple. SLIT you don't really need to implement.
  
 
  need to add some CONFIG option to parse SRAT, MADT etc only. but don't
  pull DSDT related...

 I don't think it needs a CONFIG. The code should handle this case
 by itself in any case. I'm not entirely sure it does currently, but if it
 doesn't it will likely not be very difficult to fix.

 Or are you worried about code size? ACPI is around ~270k on x86-64,
 which while certainly not small should not be a problem on x86 NUMA
 systems.

like acpi=off, acpi=tableonly? so it will load dsdt, and some one
module rely on dsdt could not complain ACPI ERROR..

YH
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] x86: add PCI IDs to k8topology_64.c II

2008-01-28 Thread Andi Kleen
On Mon, Jan 28, 2008 at 11:39:30PM -0800, Yinghai Lu wrote:
> On Jan 29, 2008 12:09 AM, Andi Kleen <[EMAIL PROTECTED]> wrote:
> > > SRAT is essentially just a two dimensional table with node distances.
> >
> > Sorry, that was actually SLIT. SRAT is not two dimensional, but also
> > relatively simple. SLIT you don't really need to implement.
> >
> 
> need to add some CONFIG option to parse SRAT, MADT etc only. but don't
> pull DSDT related...

I don't think it needs a CONFIG. The code should handle this case 
by itself in any case. I'm not entirely sure it does currently, but if it 
doesn't it will likely not be very difficult to fix.

Or are you worried about code size? ACPI is around ~270k on x86-64, 
which while certainly not small should not be a problem on x86 NUMA
systems.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] x86: add PCI IDs to k8topology_64.c II

2008-01-28 Thread Yinghai Lu
On Jan 29, 2008 12:09 AM, Andi Kleen <[EMAIL PROTECTED]> wrote:
> > SRAT is essentially just a two dimensional table with node distances.
>
> Sorry, that was actually SLIT. SRAT is not two dimensional, but also
> relatively simple. SLIT you don't really need to implement.
>

need to add some CONFIG option to parse SRAT, MADT etc only. but don't
pull DSDT related...

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] x86: add PCI IDs to k8topology_64.c II

2008-01-28 Thread Andi Kleen
> SRAT is essentially just a two dimensional table with node distances.

Sorry, that was actually SLIT. SRAT is not two dimensional, but also
relatively simple. SLIT you don't really need to implement.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] x86: add PCI IDs to k8topology_64.c II

2008-01-28 Thread Andi Kleen
 SRAT is essentially just a two dimensional table with node distances.

Sorry, that was actually SLIT. SRAT is not two dimensional, but also
relatively simple. SLIT you don't really need to implement.

-Andi
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] x86: add PCI IDs to k8topology_64.c II

2008-01-28 Thread Yinghai Lu
On Jan 29, 2008 12:09 AM, Andi Kleen [EMAIL PROTECTED] wrote:
  SRAT is essentially just a two dimensional table with node distances.

 Sorry, that was actually SLIT. SRAT is not two dimensional, but also
 relatively simple. SLIT you don't really need to implement.


need to add some CONFIG option to parse SRAT, MADT etc only. but don't
pull DSDT related...

YH
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH] x86: add PCI IDs to k8topology_64.c II

2008-01-28 Thread Andi Kleen
On Mon, Jan 28, 2008 at 11:39:30PM -0800, Yinghai Lu wrote:
 On Jan 29, 2008 12:09 AM, Andi Kleen [EMAIL PROTECTED] wrote:
   SRAT is essentially just a two dimensional table with node distances.
 
  Sorry, that was actually SLIT. SRAT is not two dimensional, but also
  relatively simple. SLIT you don't really need to implement.
 
 
 need to add some CONFIG option to parse SRAT, MADT etc only. but don't
 pull DSDT related...

I don't think it needs a CONFIG. The code should handle this case 
by itself in any case. I'm not entirely sure it does currently, but if it 
doesn't it will likely not be very difficult to fix.

Or are you worried about code size? ACPI is around ~270k on x86-64, 
which while certainly not small should not be a problem on x86 NUMA
systems.

-Andi

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/