Re: [PATCH]video:uvesafb: Fix dereference NULL pointer code path
On 2013-03-30 04:53, Wang YanQing wrote: > platform_device_alloc could failed and return NULL, > we should check this before call platform_device_put. > > Signed-off-by: Wang YanQing > --- > drivers/video/uvesafb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c > index 2f8f82d..230bd45 100644 > --- a/drivers/video/uvesafb.c > +++ b/drivers/video/uvesafb.c > @@ -1975,7 +1975,8 @@ static int __devinit uvesafb_init(void) > err = -ENOMEM; > > if (err) { > - platform_device_put(uvesafb_device); > + if (uvesafb_device) > + platform_device_put(uvesafb_device); > platform_driver_unregister(_driver); > cn_del_callback(_cn_id); > return err; > Thanks, queued to fbdev fixes. Tomi signature.asc Description: OpenPGP digital signature
Re: [PATCH]video:uvesafb: Fix dereference NULL pointer code path
On 2013-03-30 04:53, Wang YanQing wrote: platform_device_alloc could failed and return NULL, we should check this before call platform_device_put. Signed-off-by: Wang YanQing udkni...@gmail.com --- drivers/video/uvesafb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c index 2f8f82d..230bd45 100644 --- a/drivers/video/uvesafb.c +++ b/drivers/video/uvesafb.c @@ -1975,7 +1975,8 @@ static int __devinit uvesafb_init(void) err = -ENOMEM; if (err) { - platform_device_put(uvesafb_device); + if (uvesafb_device) + platform_device_put(uvesafb_device); platform_driver_unregister(uvesafb_driver); cn_del_callback(uvesafb_cn_id); return err; Thanks, queued to fbdev fixes. Tomi signature.asc Description: OpenPGP digital signature
[PATCH]video:uvesafb: Fix dereference NULL pointer code path
platform_device_alloc could failed and return NULL, we should check this before call platform_device_put. Signed-off-by: Wang YanQing --- drivers/video/uvesafb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c index 2f8f82d..230bd45 100644 --- a/drivers/video/uvesafb.c +++ b/drivers/video/uvesafb.c @@ -1975,7 +1975,8 @@ static int __devinit uvesafb_init(void) err = -ENOMEM; if (err) { - platform_device_put(uvesafb_device); + if (uvesafb_device) + platform_device_put(uvesafb_device); platform_driver_unregister(_driver); cn_del_callback(_cn_id); return err; -- 1.7.11.1.116.g8228a23 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH]video:uvesafb: Fix dereference NULL pointer code path
platform_device_alloc could failed and return NULL, we should check this before call platform_device_put. Signed-off-by: Wang YanQing udkni...@gmail.com --- drivers/video/uvesafb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c index 2f8f82d..230bd45 100644 --- a/drivers/video/uvesafb.c +++ b/drivers/video/uvesafb.c @@ -1975,7 +1975,8 @@ static int __devinit uvesafb_init(void) err = -ENOMEM; if (err) { - platform_device_put(uvesafb_device); + if (uvesafb_device) + platform_device_put(uvesafb_device); platform_driver_unregister(uvesafb_driver); cn_del_callback(uvesafb_cn_id); return err; -- 1.7.11.1.116.g8228a23 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH]video:uvesafb: Fix dereference NULL pointer code path
platform_device_alloc could failed and return NULL, we should check this before call platform_device_put. Signed-off-by: Wang YanQing --- drivers/video/uvesafb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c index 2f8f82d..230bd45 100644 --- a/drivers/video/uvesafb.c +++ b/drivers/video/uvesafb.c @@ -1975,7 +1975,8 @@ static int __devinit uvesafb_init(void) err = -ENOMEM; if (err) { - platform_device_put(uvesafb_device); + if (uvesafb_device) + platform_device_put(uvesafb_device); platform_driver_unregister(_driver); cn_del_callback(_cn_id); return err; -- 1.7.11.1.116.g8228a23 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH]video:uvesafb: Fix dereference NULL pointer code path
platform_device_alloc could failed and return NULL, we should check this before call platform_device_put. Signed-off-by: Wang YanQing udkni...@gmail.com --- drivers/video/uvesafb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/video/uvesafb.c b/drivers/video/uvesafb.c index 2f8f82d..230bd45 100644 --- a/drivers/video/uvesafb.c +++ b/drivers/video/uvesafb.c @@ -1975,7 +1975,8 @@ static int __devinit uvesafb_init(void) err = -ENOMEM; if (err) { - platform_device_put(uvesafb_device); + if (uvesafb_device) + platform_device_put(uvesafb_device); platform_driver_unregister(uvesafb_driver); cn_del_callback(uvesafb_cn_id); return err; -- 1.7.11.1.116.g8228a23 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/