Re: [PATCH -mm] es18xx: Shut up uninitialized var build warning

2007-09-02 Thread Rene Herman

On 09/02/2007 10:21 PM, Satyam Sharma wrote:


sound/isa/es18xx.c: In function ‘snd_es18xx_isa_probe’:
sound/isa/es18xx.c:2251: warning: ‘err’ may be used uninitialized in this 
function

gcc is a sad, sad compiler. This warning is bogus so let's shut it up.


Same situation, same comment (and same charset :-( ) as the sb16 one.

Rene.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH -mm] es18xx: Shut up uninitialized var build warning

2007-09-02 Thread Satyam Sharma

sound/isa/es18xx.c: In function ‘snd_es18xx_isa_probe’:
sound/isa/es18xx.c:2251: warning: ‘err’ may be used uninitialized in this 
function

gcc is a sad, sad compiler. This warning is bogus so let's shut it up.

Signed-off-by: Satyam Sharma <[EMAIL PROTECTED]>

---

 sound/isa/es18xx.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.23-rc4-mm1/sound/isa/es18xx.c~fix 2007-09-02 21:16:54.0 
+0530
+++ linux-2.6.23-rc4-mm1/sound/isa/es18xx.c 2007-09-02 21:30:13.0 
+0530
@@ -2248,7 +2248,6 @@ static int __devinit snd_es18xx_isa_prob
 
 static int __devinit snd_es18xx_isa_probe(struct device *pdev, unsigned int 
dev)
 {
-   int err;
static int possible_irqs[] = {5, 9, 10, 7, 11, 12, -1};
static int possible_dmas[] = {1, 0, 3, 5, -1};
 
@@ -2276,6 +2275,8 @@ static int __devinit snd_es18xx_isa_prob
} else {
static unsigned long possible_ports[] = {0x220, 0x240, 0x260, 
0x280};
int i;
+   int uninitialized_var(err);
+
for (i = 0; i < ARRAY_SIZE(possible_ports); i++) {
port[dev] = possible_ports[i];
err = snd_es18xx_isa_probe1(dev, pdev);