Re: [PATCH -mm1 0/2] Fix unlocked call to idr_find()
On Fri, Sep 28, 2007 at 08:12:56AM +0200, Nadia Derbey wrote: > Jarek Poplawski wrote: > >On Thu, Sep 27, 2007 at 04:33:54PM +0200, [EMAIL PROTECTED] wrote: > > > >>This a series of 2 patches that should be applied on top of the other ipc > >>patches, in 2.6.23-rc6-mm1. > > > >... > > > >>They should be applied to 2.6.23-rc6-mm1, in the following order: > > > > > >Didn't you mean 2.6.23-rc8-mm1, btw? > > > >Regards, > >Jarek P. > > > > No, what I wrote is exactly what I meant: unfortunately I couldn't get > the rc8-mm1 yet. > But, Before building the patch, I applied the ipc patches that had been > integrated in rc7-mm1. > Nothing happened in rc8-mm1. > So you should have no problem appying these patches to your rc8-mm1 tree. I didn't manage with rc6-mm1, maybe I've messed something. With rc8-mm2 it's OK - a minor offset only. Cheers, Jarek P. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -mm1 0/2] Fix unlocked call to idr_find()
Jarek Poplawski wrote: On Thu, Sep 27, 2007 at 04:33:54PM +0200, [EMAIL PROTECTED] wrote: This a series of 2 patches that should be applied on top of the other ipc patches, in 2.6.23-rc6-mm1. ... They should be applied to 2.6.23-rc6-mm1, in the following order: Didn't you mean 2.6.23-rc8-mm1, btw? Regards, Jarek P. No, what I wrote is exactly what I meant: unfortunately I couldn't get the rc8-mm1 yet. But, Before building the patch, I applied the ipc patches that had been integrated in rc7-mm1. Nothing happened in rc8-mm1. So you should have no problem appying these patches to your rc8-mm1 tree. Regards, Nadia - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -mm1 0/2] Fix unlocked call to idr_find()
Jarek Poplawski wrote: On Thu, Sep 27, 2007 at 04:33:54PM +0200, [EMAIL PROTECTED] wrote: This a series of 2 patches that should be applied on top of the other ipc patches, in 2.6.23-rc6-mm1. ... They should be applied to 2.6.23-rc6-mm1, in the following order: Didn't you mean 2.6.23-rc8-mm1, btw? Regards, Jarek P. No, what I wrote is exactly what I meant: unfortunately I couldn't get the rc8-mm1 yet. But, Before building the patch, I applied the ipc patches that had been integrated in rc7-mm1. Nothing happened in rc8-mm1. So you should have no problem appying these patches to your rc8-mm1 tree. Regards, Nadia - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -mm1 0/2] Fix unlocked call to idr_find()
On Fri, Sep 28, 2007 at 08:12:56AM +0200, Nadia Derbey wrote: Jarek Poplawski wrote: On Thu, Sep 27, 2007 at 04:33:54PM +0200, [EMAIL PROTECTED] wrote: This a series of 2 patches that should be applied on top of the other ipc patches, in 2.6.23-rc6-mm1. ... They should be applied to 2.6.23-rc6-mm1, in the following order: Didn't you mean 2.6.23-rc8-mm1, btw? Regards, Jarek P. No, what I wrote is exactly what I meant: unfortunately I couldn't get the rc8-mm1 yet. But, Before building the patch, I applied the ipc patches that had been integrated in rc7-mm1. Nothing happened in rc8-mm1. So you should have no problem appying these patches to your rc8-mm1 tree. I didn't manage with rc6-mm1, maybe I've messed something. With rc8-mm2 it's OK - a minor offset only. Cheers, Jarek P. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -mm1 0/2] Fix unlocked call to idr_find()
On Thu, Sep 27, 2007 at 04:33:54PM +0200, [EMAIL PROTECTED] wrote: > > This a series of 2 patches that should be applied on top of the other ipc > patches, in 2.6.23-rc6-mm1. ... > They should be applied to 2.6.23-rc6-mm1, in the following order: Didn't you mean 2.6.23-rc8-mm1, btw? Regards, Jarek P. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH -mm1 0/2] Fix unlocked call to idr_find()
This a series of 2 patches that should be applied on top of the other ipc patches, in 2.6.23-rc6-mm1. The first one is an answer to the following issue pointed out by Jarek: > Jarek Poplawski wrote: > 1. ipc_lock() and ipc_lock_check() are used without ipc_ids.mutex, > but it's probably wrong: they call idr_find() with ipc_ids pointer > which needs this mutex, just like in similar code in: ipc_findkey(), > ipc_get_maxid() or sysvipc_find_ipc(). The second one is a trivial patch that removes an unneeded parameter for 2 routines. They should be applied to 2.6.23-rc6-mm1, in the following order: [PATCH 1/2]: ipc_fix_idr_find_locking.patch [PATCH 2/2]: ipc_remove_unneeded_params.patch Regards, Nadia -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH -mm1 0/2] Fix unlocked call to idr_find()
This a series of 2 patches that should be applied on top of the other ipc patches, in 2.6.23-rc6-mm1. The first one is an answer to the following issue pointed out by Jarek: Jarek Poplawski wrote: 1. ipc_lock() and ipc_lock_check() are used without ipc_ids.mutex, but it's probably wrong: they call idr_find() with ipc_ids pointer which needs this mutex, just like in similar code in: ipc_findkey(), ipc_get_maxid() or sysvipc_find_ipc(). The second one is a trivial patch that removes an unneeded parameter for 2 routines. They should be applied to 2.6.23-rc6-mm1, in the following order: [PATCH 1/2]: ipc_fix_idr_find_locking.patch [PATCH 2/2]: ipc_remove_unneeded_params.patch Regards, Nadia -- - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -mm1 0/2] Fix unlocked call to idr_find()
On Thu, Sep 27, 2007 at 04:33:54PM +0200, [EMAIL PROTECTED] wrote: This a series of 2 patches that should be applied on top of the other ipc patches, in 2.6.23-rc6-mm1. ... They should be applied to 2.6.23-rc6-mm1, in the following order: Didn't you mean 2.6.23-rc8-mm1, btw? Regards, Jarek P. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
