Re: [alsa-devel] [PATCH -next] ASoC: SOF: debug: fix possible memory leak in sof_dfsentry_write()

[Ranjani Sridharan]

On Fri, 2019-07-05 at 08:16 +, Wei Yongjun wrote:
> 'string' is malloced in sof_dfsentry_write() and should be freed
> before leaving from the error handling cases, otherwise it will cause
> memory leak.
> 
> Fixes: 091c12e1f50c ("ASoC: SOF: debug: add new debugfs entries for
> IPC flood test")
> Signed-off-by: Wei Yongjun 
Thanks for fixing this, Wei!
Reviewed-by: Ranjani Sridharan 

> ---
>  sound/soc/sof/debug.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/sof/debug.c b/sound/soc/sof/debug.c
> index 54bb53bfc81b..2388477a965e 100644
> --- a/sound/soc/sof/debug.c
> +++ b/sound/soc/sof/debug.c
> @@ -162,7 +162,7 @@ static ssize_t sof_dfsentry_write(struct file
> *file, const char __user *buffer,
>   else
>   ret = kstrtoul(string, 0, _count);
>   if (ret < 0)
> - return ret;
> + goto out;
>  
>   /* limit max duration/ipc count for flood test */
>   if (flood_duration_test) {
> @@ -191,7 +191,7 @@ static ssize_t sof_dfsentry_write(struct file
> *file, const char __user *buffer,
>   "error: debugfs write failed to
> resume %d\n",
>   ret);
>   pm_runtime_put_noidle(sdev->dev);
> - return ret;
> + goto out;
>   }
>  
>   /* flood test */
> 
> 
> 
> ___
> Alsa-devel mailing list
> alsa-de...@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[PATCH -next] ASoC: SOF: debug: fix possible memory leak in sof_dfsentry_write()

[Wei Yongjun]

'string' is malloced in sof_dfsentry_write() and should be freed
before leaving from the error handling cases, otherwise it will cause
memory leak.

Fixes: 091c12e1f50c ("ASoC: SOF: debug: add new debugfs entries for IPC flood 
test")
Signed-off-by: Wei Yongjun 
---
 sound/soc/sof/debug.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/sof/debug.c b/sound/soc/sof/debug.c
index 54bb53bfc81b..2388477a965e 100644
--- a/sound/soc/sof/debug.c
+++ b/sound/soc/sof/debug.c
@@ -162,7 +162,7 @@ static ssize_t sof_dfsentry_write(struct file *file, const 
char __user *buffer,
else
ret = kstrtoul(string, 0, _count);
if (ret < 0)
-   return ret;
+   goto out;
 
/* limit max duration/ipc count for flood test */
if (flood_duration_test) {
@@ -191,7 +191,7 @@ static ssize_t sof_dfsentry_write(struct file *file, const 
char __user *buffer,
"error: debugfs write failed to resume 
%d\n",
ret);
pm_runtime_put_noidle(sdev->dev);
-   return ret;
+   goto out;
}
 
/* flood test */