Re: [PATCH -next] NTB: Drop kfree for memory allocated with devm_kzalloc

[Lorenzo Pieralisi]

On Wed, Feb 10, 2021 at 07:53:45AM +, Wei Yongjun wrote:
> It's not necessary to free memory allocated with devm_kzalloc
> and using kfree leads to a double free.
> 
> Fixes: 363baf7d6051 ("NTB: Add support for EPF PCI-Express Non-Transparent 
> Bridge")

Squashed it in the commit it is fixing and repushed pci/ntb out.

Thanks,
Lorenzo

> Reported-by: Hulk Robot 
> Signed-off-by: Wei Yongjun 
> ---
>  drivers/ntb/hw/epf/ntb_hw_epf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/ntb/hw/epf/ntb_hw_epf.c b/drivers/ntb/hw/epf/ntb_hw_epf.c
> index 2cccb7dff5dd..b019755e4e21 100644
> --- a/drivers/ntb/hw/epf/ntb_hw_epf.c
> +++ b/drivers/ntb/hw/epf/ntb_hw_epf.c
> @@ -723,7 +723,6 @@ static void ntb_epf_pci_remove(struct pci_dev *pdev)
>   ntb_unregister_device(>ntb);
>   ntb_epf_cleanup_isr(ndev);
>   ntb_epf_deinit_pci(ndev);
> - kfree(ndev);
>  }
>  
>  static const struct ntb_epf_data j721e_data = {
> 

Re: [PATCH -next] NTB: Drop kfree for memory allocated with devm_kzalloc

[Kishon Vijay Abraham I]

On 10/02/21 1:23 pm, Wei Yongjun wrote:
> It's not necessary to free memory allocated with devm_kzalloc
> and using kfree leads to a double free.
> 
> Fixes: 363baf7d6051 ("NTB: Add support for EPF PCI-Express Non-Transparent 
> Bridge")
> Reported-by: Hulk Robot 
> Signed-off-by: Wei Yongjun 
> ---
>  drivers/ntb/hw/epf/ntb_hw_epf.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/ntb/hw/epf/ntb_hw_epf.c b/drivers/ntb/hw/epf/ntb_hw_epf.c
> index 2cccb7dff5dd..b019755e4e21 100644
> --- a/drivers/ntb/hw/epf/ntb_hw_epf.c
> +++ b/drivers/ntb/hw/epf/ntb_hw_epf.c
> @@ -723,7 +723,6 @@ static void ntb_epf_pci_remove(struct pci_dev *pdev)
>   ntb_unregister_device(>ntb);
>   ntb_epf_cleanup_isr(ndev);
>   ntb_epf_deinit_pci(ndev);
> - kfree(ndev);
>  }

Reviewed-by: Kishon Vijay Abraham I 
>  
>  static const struct ntb_epf_data j721e_data = {
> 

[PATCH -next] NTB: Drop kfree for memory allocated with devm_kzalloc

[Wei Yongjun]

It's not necessary to free memory allocated with devm_kzalloc
and using kfree leads to a double free.

Fixes: 363baf7d6051 ("NTB: Add support for EPF PCI-Express Non-Transparent 
Bridge")
Reported-by: Hulk Robot 
Signed-off-by: Wei Yongjun 
---
 drivers/ntb/hw/epf/ntb_hw_epf.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/ntb/hw/epf/ntb_hw_epf.c b/drivers/ntb/hw/epf/ntb_hw_epf.c
index 2cccb7dff5dd..b019755e4e21 100644
--- a/drivers/ntb/hw/epf/ntb_hw_epf.c
+++ b/drivers/ntb/hw/epf/ntb_hw_epf.c
@@ -723,7 +723,6 @@ static void ntb_epf_pci_remove(struct pci_dev *pdev)
ntb_unregister_device(>ntb);
ntb_epf_cleanup_isr(ndev);
ntb_epf_deinit_pci(ndev);
-   kfree(ndev);
 }
 
 static const struct ntb_epf_data j721e_data = {