Re: [PATCH -next] bootconfig: Make symbol 'xbc_namebuf' static

[Masami Hiramatsu]

On Tue, 14 Jul 2020 22:25:04 +0800
Wei Yongjun  wrote:

> Fix sparse build warning:
> 
> init/main.c:305:6: warning:
>  symbol 'xbc_namebuf' was not declared. Should it be static?

Good catch!

Acked-by: Masami Hiramatsu 

Thank you,

> 
> Signed-off-by: Wei Yongjun 
> ---
>  init/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init/main.c b/init/main.c
> index 9127b240fd26..6a24981c727f 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -302,7 +302,7 @@ static void * __init get_boot_config_from_initrd(u32 
> *_size, u32 *_csum)
>  
>  #ifdef CONFIG_BOOT_CONFIG
>  
> -char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
> +static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
>  
>  #define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0)
>  
> 


-- 
Masami Hiramatsu 

[PATCH -next] bootconfig: Make symbol 'xbc_namebuf' static

[Wei Yongjun]

Fix sparse build warning:

init/main.c:305:6: warning:
 symbol 'xbc_namebuf' was not declared. Should it be static?

Signed-off-by: Wei Yongjun 
---
 init/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/init/main.c b/init/main.c
index 9127b240fd26..6a24981c727f 100644
--- a/init/main.c
+++ b/init/main.c
@@ -302,7 +302,7 @@ static void * __init get_boot_config_from_initrd(u32 
*_size, u32 *_csum)
 
 #ifdef CONFIG_BOOT_CONFIG
 
-char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
+static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
 
 #define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0)